fix(identity): async_insert for profile_aliases writes - #323
Merged
Conversation
upsertAlias inserts one row per sign-in batch (the proxy re-emits per batch). Prod CLICKHOUSE_SETTINGS and the CH server default both have async_insert=0, so these were synchronous single-row inserts — at scale that piles up parts on the single-partition ReplacingMergeTree and ties up an API request per insert. Set async_insert=1, wait_for_async_insert=0 on this insert specifically so ClickHouse coalesces them server-side (~1 part/sec). Scoped to the alias write only; nothing else changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #322.
Problem:
upsertAliaswrites one row per sign-in batch (the proxy re-emits per batch). Verified prodCLICKHOUSE_SETTINGSand the CH server default both haveasync_insert=0— so these are synchronous single-row inserts. At dashreels scale (~88% signed-in) that piles up parts on the single-partitionReplicatedReplacingMergeTreeand holds an API request open per insert.Fix: set
async_insert=1, wait_for_async_insert=0on this insert only, so ClickHouse coalesces them server-side (~1 part/sec). Scoped to the alias write; nothing else changes.Gates the prod deploy of the identity-merge write path.