Skip to content

CTM-381:Always send the workspace google project to the DRSHub request body#420

Draft
LizBaldo wants to merge 1 commit intomasterfrom
CTM-381/always-send-google-project-id-to-drshub
Draft

CTM-381:Always send the workspace google project to the DRSHub request body#420
LizBaldo wants to merge 1 commit intomasterfrom
CTM-381/always-send-google-project-id-to-drshub

Conversation

@LizBaldo
Copy link
Collaborator

Jira Ticket: https://broadworkbench.atlassian.net/browse/CTM-381

All TDR clients via DRSHub should now pass the Google Project ID of the requester so the DRSHub resolution can then be billed appropriately if requester pay is enabled.

@LizBaldo LizBaldo changed the title CTM-381:Aalways send the workspace google project to the DRSHub request body CTM-381:Always send the workspace google project to the DRSHub request body Mar 13, 2026
@jgainerdewar
Copy link

I remember there being some special handling for AnVIL URIs in here, should that now be removed?

@LizBaldo
Copy link
Collaborator Author

I remember there being some special handling for AnVIL URIs in here, should that now be removed?

The special handling was for something slightly different actually and I think it should remain in there

The way requester pay works with notebooks is actually different than what i thought initially:

When a requester pays URI is detected (e.g. drs://dg.ANV0...), this hits the Rawls API — not DRSHub — to enable requester pays for the workspace's linked service accounts.
After DRSHub returns the GCS location and credentials, the billing_project (google project id) is used in:
-- gs.get_signed_url(..., requester_pays_user_project=billing_project)when generating a signed URL fallback
-- GSBlob(info.bucket_name, info.key, info.credentials, billing_project) passed into the blob for direct GCS reads/copies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants