Skip to content

PROD-1042: Upgrade to latest TCL#487

Merged
jgainerdewar merged 2 commits intomasterfrom
jd_PROD-1042_upgradetcl
Mar 16, 2026
Merged

PROD-1042: Upgrade to latest TCL#487
jgainerdewar merged 2 commits intomasterfrom
jd_PROD-1042_upgradetcl

Conversation

@jgainerdewar
Copy link
Contributor

RBS is currently unable to deploy because of a mismatch between the Java client k8s version and the k8s cluster version, which upgraded over the weekend. This should resolve it by pulling in a version of TCL that has the upgraded java client for k8s.

@jgainerdewar jgainerdewar requested a review from a team as a code owner March 16, 2026 14:18
@jgainerdewar jgainerdewar requested review from marctalbott and samanehsan and removed request for a team March 16, 2026 14:18
@sonarqubecloud
Copy link

@jgainerdewar
Copy link
Contributor Author

jgainerdewar commented Mar 16, 2026

Why the new nullable check?

The k8s client 25.0.0 bumped OkHttp from 4.12.0 to 5.1.0, and since Gradle resolves to the highest version, that upgrade wins across the entire test classpath — including for the
terra-cloud-resource-lib (CRL) which uses OkHttp 4.10.0.

OkHttp 5.x is a significant upgrade. It could change how HTTP responses are read/buffered, which could affect how Google's AbstractGoogleJsonClient parses JSON responses. If a response body is read slightly
differently (e.g., an empty JSON array [] getting dropped vs preserved), getAccounts() could return null where it previously returned an empty list.

Summary: The k8s client jump from 23 to 25 dragged OkHttp from 4.x to 5.x across the whole test runtime. That likely changed the HTTP response handling for the IAM client, causing getAccounts() to return null
instead of an empty list in certain cases.

@jgainerdewar jgainerdewar merged commit b2ef1fa into master Mar 16, 2026
6 checks passed
@jgainerdewar jgainerdewar deleted the jd_PROD-1042_upgradetcl branch March 16, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants