[chore] Small updates #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
requested review from
ruimartin,
elbywan and
Ayc0
and removed request for
a team and
ruimartin
yoannmoinet
force-pushed
the
yoann/small-updates
branch
from
5d5e2ab to
a96f7b5
Compare
jakub-g
approved these changes
Feb 19, 2025
jakub-g
approved these changes
Feb 19, 2025
Miz85
approved these changes
Feb 19, 2025
| getLogger: getLoggerFactory(build, options.logLevel), | ||
| // This will be updated in the injection plugin on initialization. | ||
| inject: () => { | ||
| throw new Error('Inject function called before it was initialized.'); |
There was a problem hiding this comment.
❓question I'm not very familiar with the code but is that error caught and reported properly elsewhere or could it just break the build?
| @@ -25,11 +23,21 @@ const logPriority: Record<LogLevel, number> = { | |||
| none: 4, | |||
| }; | |||
|
|
|||
| // Exported for testing. | |||
| // Which separator to use for plugin names. | |||
| export const NAME_SEP = '>'; | |||
There was a problem hiding this comment.
nit:
Suggested change
| export const NAME_SEP = '>'; | |
| export const PLUGINS_NAME_SEP = '>'; |
| // Which separator to use for plugin names. | ||
| export const NAME_SEP = '>'; | ||
|
|
||
| const cleanName = (name: string) => { |
There was a problem hiding this comment.
nit:
Suggested change
| const cleanName = (name: string) => { | |
| const cleanPluginsName = (name: string) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Some small updates to lighten #134 and #137
How?
getLoggeron theGlobalContext.injectionsstate to its own plugin, for more simplicity and self contenance.