Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-ui] Quick fixes for web-ui #145

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

[web-ui] Quick fixes for web-ui #145

wants to merge 38 commits into from

Conversation

yoannmoinet
Copy link
Member

@yoannmoinet yoannmoinet commented Feb 27, 2025 •
edited
Loading

What and why?

Related to web-ui's integration.
Upgrading it to latest versions.
Some small fixes where necessary.

How?

  • esbuild: stub file was being removed too soon and sub builds would fail on resolution.
    • instead of creating the file in the outDir, we now use a tmpdir, and we don't delete it.
  • rspack: removal of stub file wasn't happening in case of failed build (using shutdown instead of done now).
    • using shutdown async would randomly crash too, so made it sync.
  • rspack: re-organised the code to be all at the same place.
  • yarn cli prepare-link wasn't reverting to normal after a slight drift from package.json latest definition.
  • small simplification of runBundlers by removing the isolateModules usage.

Follow-ups

Write a test that would catch the esbuild issue better.
The current test might be running too fast and doesn't reproduce the edge case well enough.

@yoannmoinet
Re-org timing of stub injected file
d806111
@yoannmoinet
Fix the prepare-link revert
a4a2613
@yoannmoinet
Fix random rspack crashes
f3efb8b
@yoannmoinet
Slightly change esbuild stub file strategy
e2f6d26 
- use a tmpdir() to store the stub file.
- do not remove it at the end of the build.
- change how we update the initialOptions.
@yoannmoinet
Remove unecessary complexity from runBundlers' isolated runs
6b45388
@yoannmoinet
Add isXpack helper to detect webpack/rspack bundlers
d5001bf
@yoannmoinet
Better and stricter separation of needs for the injection plugin
a02a3c4
@yoannmoinet
Widen the file stub solution for xpack to webpack too.
6aa1fe8
@yoannmoinet
Small inconsequential diff
6a7fb2a
@yoannmoinet
Fix analytics
fc0df3b
@yoannmoinet
Upload artifacts only when failed.
5b58a98
@yoannmoinet
Fix some exports values
c89d1f3
@yoannmoinet
Increase e2e timeout
3563c7e
@yoannmoinet
Add global timeout for CI
5796ea2
@yoannmoinet
Add playwright alias
c9119bc
@yoannmoinet
Fix package.json breaking the bundled types
e2b7f25
@yoannmoinet
Handle 0ms in formatDuration
6c717e7
@yoannmoinet
Add time logger
9f5603d
@yoannmoinet
Add time debugs in some places
50deda4
@yoannmoinet
Revert version bump
370674d
@yoannmoinet
Slight update on metrics sending logs
08fc2f2
@yoannmoinet
Fix esbuild report on external dependencies
68075c8
@yoannmoinet
Add more time debug
95770a6
@yoannmoinet
Add a dimmed starting point for time logs
6279350
@yoannmoinet
Move helpers getAbsolutePath, getNearestCommonDirectory and `debu…
bf3f59e 
…gFilesPlugins` to `@dd/core`
@yoannmoinet
Factorise build commands
08bba97
@yoannmoinet
Fix rollup's build-report with external dependencies support
a67c63c
@yoannmoinet
Remove resetModule from jest as it's not needed anymore and prevents …
52250a5 
…some mocks to work as expected (memfs for isntance)
@yoannmoinet
Clean readme from unecessary information
097f92c
@yoannmoinet
Add some tests
c76c6b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yoannmoinet