Skip to content

Conversation

@yoannmoinet
Copy link
Member

  • Extract cleanIdentifier() function to handle webpack loader prefixes (! and |)
  • Fix QUERY_RX to only match actual query parameters (? and %3F), not pipe characters
  • Apply cleanIdentifier() to module identifiers before storing in build report
  • Store both original and cleaned identifiers in tempDeps map for proper lookups
  • Ensures build report correctly tracks dependencies with webpack loader syntax

- Extract `cleanIdentifier()` function to handle webpack loader prefixes (! and |)
- Fix QUERY_RX to only match actual query parameters (? and %3F), not pipe characters
- Apply cleanIdentifier() to module identifiers before storing in build report
- Store both original and cleaned identifiers in tempDeps map for proper lookups
- Ensures build report correctly tracks dependencies with webpack loader syntax
@datadog-official
Copy link

datadog-official bot commented Oct 20, 2025

⚠️ Tests

⚠️ Warnings

🧪 2 Tests failed

Build report plugin helpers cleanName Should return a cleaned name for "pipe query parameters". from ../plugins/build-report/src/helpers.test.ts (Datadog)
expect(received).toBe(expected) // Object.is equality

Expected: "path.js"
Received: "query=param"
Build report plugin helpers cleanPath Should return a cleaned path for "pipe query parameters". from ../plugins/build-report/src/helpers.test.ts (Datadog)
expect(received).toBe(expected) // Object.is equality

Expected: "/current/working/directory/path.js"
Received: "query=param"

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 75521fb | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants