[v2.0.0] Use unplugin #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayc0
reviewed
Apr 26, 2024
| allow: ['warn', 'error', 'info'], | ||
| }, | ||
| ], | ||
| 'no-console': 0, |
There was a problem hiding this comment.
prefer a string (I can never remember is 0 = off or error)
There was a problem hiding this comment.
Also if it's off, maybe we can just remove the line
Ayc0
reviewed
Apr 26, 2024
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "name": "@dd/factory", | |||
There was a problem hiding this comment.
Do we have the rights on @dd?
And shouldn't it be @datadog/ for consistency?
There was a problem hiding this comment.
This is not published, only internal dependencies.
Ayc0
reviewed
Apr 26, 2024
Comment on lines
+7
to
+15
| "exports": { | ||
| ".": "./src/index.ts", | ||
| "./esbuild-plugin/*": "./src/esbuild-plugin/*.ts", | ||
| "./webpack-plugin/*": "./src/webpack-plugin/*.ts", | ||
| "./common/*": "./src/common/*.ts", | ||
| "./common/metrics/*": "./src/common/metrics/*.ts", | ||
| "./common/output/*": "./src/common/output/*.ts", | ||
| "./*": "./src/*.ts" | ||
| }, |
There was a problem hiding this comment.
You'll need a publishConfig otherwise those won't be valid for the built code
Also isn't "./**": "./src/**.ts" already working for all those options? (except .)
And you may want to add ./package.json (common to include)
There was a problem hiding this comment.
Most of the publication work is done in #65
yoannmoinet
force-pushed
the
yoann/re-design-with-unpluggin
branch
from
e5bdca9 to
c1b40d9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
We want to use unplugin in order to easily support more bundlers (in the future).
How?
We've migrated the existing features in a
telemetryplugin that supportswebpackandesbuild.This change should be iso, and the tests are used to confirm this.