[1.19][azure] Implement excess-ip-release support#665
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1dff73613
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jaredledvina
force-pushed
the
jared.ledvina/azure-ip-release-1-19
branch
from
c1dff73 to
16e5513
Compare
|
@codex review |
jaredledvina
force-pushed
the
jared.ledvina/azure-ip-release-1-19
branch
from
16e5513 to
5a450dd
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: jaredledvina <jared.ledvina@datadoghq.com> Co-authored-by: Cursor <cursoragent@cursor.com>
jaredledvina
force-pushed
the
jared.ledvina/azure-ip-release-1-19
branch
from
5a450dd to
a0a824b
Compare
| flags.Bool(operatorOption.AzureReleaseExcessIPs, false, "Enable releasing excess free IP addresses from Azure network interfaces.") | ||
| option.BindEnv(vp, operatorOption.AzureReleaseExcessIPs) | ||
|
|
||
| flags.Int(operatorOption.ExcessIPReleaseDelay, 180, "Number of seconds operator would wait before it releases an IP previously marked as excess") |
There was a problem hiding this comment.
Note: Duplicated here as on 1.19 the flag is only implemented in the AWS provider
cilium/operator/cmd/provider_aws_flags.go
Lines 29 to 30 in 0e4992c
Upstream, there's the shared provider config we will use.
There was a problem hiding this comment.
Note: this will work in our case because we don't build the omnibus operator, but if we were to try with that change, it would fail as two separate cells would try to bind the same CLI flag.
| flags.Bool(operatorOption.AzureUsePrimaryAddress, false, "Use Azure IP address from interface's primary IPConfigurations") | ||
| option.BindEnvWithLegacyEnvFallback(vp, operatorOption.AzureUsePrimaryAddress, "AZURE_USE_PRIMARY_ADDRESS") | ||
|
|
||
| flags.Bool(operatorOption.AzureReleaseExcessIPs, false, "Enable releasing excess free IP addresses from Azure network interfaces.") |
There was a problem hiding this comment.
Note: for when we want to upstream this, it'll probably be better to create a new global --ipam-release-excess-ips flag that both AWS and Azure use and start deprecating the existing AWS only flag.
2 participants
1.19 specific implementation for excess IP release in Azure