Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not import prometheus by default in python checks #34176

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pgimalac
Copy link
Member

What does this PR do?

Update integrations-core to include DataDog/integrations-core#19644.

Motivation

Avoid importing prometheus by default in Python checks.

Describe how you validated your changes

This shouldn't change anything except lazy loading a dependency so if CI passes it should be ok.

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-runtimes labels Feb 18, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 18, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 64fdfe7ec366d4dae96b0aa3371909ec392d7692

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 866.66MB 866.66MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 876.43MB 876.43MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 876.43MB 876.43MB 0.50MB
datadog-agent-arm64-deb 0.00MB 855.13MB 855.13MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 864.88MB 864.88MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.36MB 41.36MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.44MB 41.44MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.44MB 41.44MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.62MB 39.62MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.30MB 443.30MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.80MB 61.80MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.87MB 61.87MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.87MB 61.87MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.05MB 59.05MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.12MB 59.12MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 56221153 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.87MiB 847.49MiB 202.3MiB 212.33MiB
static_quality_gate_agent_deb_arm64 826.85MiB 836.66MiB 182.26MiB 192.5MiB
static_quality_gate_agent_rpm_amd64 837.86MiB 847.82MiB 205.76MiB 215.76MiB
static_quality_gate_agent_rpm_arm64 826.83MiB 836.66MiB 184.24MiB 194.24MiB
static_quality_gate_agent_suse_amd64 837.86MiB 847.82MiB 205.76MiB 215.76MiB
static_quality_gate_agent_suse_arm64 826.83MiB 836.66MiB 184.24MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 39.52MiB 49.7MiB 10.54MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 37.86MiB 48.1MiB 9.12MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 39.52MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 39.52MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.01MiB 69.0MiB 14.83MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.39MiB 66.4MiB 12.8MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.01MiB 69.0MiB 14.85MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.39MiB 66.4MiB 12.82MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.01MiB 69.0MiB 14.85MiB 24.8MiB
static_quality_gate_docker_agent_amd64 922.67MiB 931.7MiB 308.52MiB 318.67MiB
static_quality_gate_docker_agent_arm64 935.0MiB 944.08MiB 292.57MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.1GiB 383.62MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.1GiB 363.61MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.67MiB 57.88MiB 18.25MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.05MiB 56.27MiB 17.01MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.78MiB 274.78MiB 106.29MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.81MiB 290.82MiB 101.11MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fd988de5-1e48-4ab5-b6fd-6543d96ef887

Baseline: 64fdfe7
Comparison: e12cd87
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.72 [+0.63, +6.81] 1 Logs
quality_gate_idle memory utilization +0.40 [+0.37, +0.43] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.10 [+0.04, +0.15] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.07 [-0.83, +0.97] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.67, +0.76] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.43, +0.51] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.75, +0.82] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.29] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.89, +0.86] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.95, +0.89] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.07 [-0.14, -0.01] 1 Logs
file_tree memory utilization -0.36 [-0.42, -0.30] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.36 [-1.14, +0.41] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.64 [-2.53, -0.76] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant