[Backport 7.72.x] update test that was flakey on windows #42098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=80&v=4){kind=small}
### What does this PR do?
Fixes flakey deployment test on windows
### Motivation
```
=== Failed
=== FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (0.00s)
deployment_test.go:101:
Error Trace: C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101
Error: "0" is not greater than "0"
Test: TestDeploymentRolloutGeneration_OngoingRollout
Messages: Rollout duration should be greater than 0 for ongoing rollout
=== FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (re-run 1) (0.00s)
deployment_test.go:101:
Error Trace: C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101
Error: "0" is not greater than "0"
Test: TestDeploymentRolloutGeneration_OngoingRollout
Messages: Rollout duration should be greater than 0 for ongoing rollout
=== FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (re-run 2) (0.00s)
deployment_test.go:101:
Error Trace: C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101
Error: "0" is not greater than "0"
Test: TestDeploymentRolloutGeneration_OngoingRollout
Messages: Rollout duration should be greater than 0 for ongoing rollout
```
### Describe how you validated your changes
### Additional Notes
(cherry picked from commit 8310fe0)
dd-octo-sts
bot
added
changelog/no-changelog
qa/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8310fe0 from #42005.
What does this PR do?
Fixes flakey deployment test on windows
Motivation
Describe how you validated your changes
Additional Notes