Skip to content

Conversation

ogaca-dd
Copy link
Contributor

What does this PR do?

Add invoke task for the full host profiler

Motivation

Describe how you validated your changes

Run the task locally.

Additional Notes

@ogaca-dd ogaca-dd added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Oct 17, 2025
@github-actions github-actions bot added the medium review PR review might take time label Oct 17, 2025
@ogaca-dd ogaca-dd changed the title Add invoke task for the full host profiler [OTAGENT-587] Add invoke task for the full host profiler Oct 17, 2025
@ogaca-dd ogaca-dd marked this pull request as ready for review October 17, 2025 16:36
@ogaca-dd ogaca-dd requested review from a team as code owners October 17, 2025 16:36
@ogaca-dd ogaca-dd requested a review from Enzu83 October 17, 2025 16:36
@ogaca-dd
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 17, 2025

View all feedbacks in Devflow UI.

2025-10-17 16:40:59 UTC ℹ️ Start processing command /merge


2025-10-17 16:41:07 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-17 20:42:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time


LOADER_TAGS = {"otlp"}

FULL_HOST_PROFILER_TAGS = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had issues with empty tag set, which I fix in #41774 (not yet merged though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait your PR to be merged.

Comment on lines +26 to +32
env = {"GO111MODULE": "on"}
build_tags = get_default_build_tags(build="full-host-profiler")
ldflags = get_version_ldflags(ctx)
if os.environ.get("DELVE"):
gcflags = "all=-N -l"
else:
gcflags = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use get_build_flags like every other build task ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the otel agent does that too 🙃

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7822030

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${674.78}$$ < $${702.15}$$ DataNotFound $${164.64}$$ < $${177.79}$$
agent_deb_amd64_fips DataNotFound $${669.29}$$ < $${696.65}$$ DataNotFound $${163.84}$$ < $${176.53}$$
agent_heroku_amd64 DataNotFound $${336.55}$$ < $${340.18}$$ DataNotFound $${89.83}$$ < $${91.08}$$
agent_msi DataNotFound $${1013.57}$$ < $${1015.38}$$ DataNotFound $${148.44}$$ < $${150.78}$$
agent_rpm_amd64 DataNotFound $${674.77}$$ < $${702.14}$$ DataNotFound $${166.97}$$ < $${180.53}$$
agent_rpm_amd64_fips DataNotFound $${669.28}$$ < $${696.64}$$ DataNotFound $${165.56}$$ < $${178.79}$$
agent_rpm_arm64 DataNotFound $${664.36}$$ < $${686.31}$$ DataNotFound $${153.2}$$ < $${161.22}$$
agent_rpm_arm64_fips DataNotFound $${659.89}$$ < $${681.84}$$ DataNotFound $${152.72}$$ < $${160.18}$$
agent_suse_amd64 DataNotFound $${674.77}$$ < $${702.14}$$ DataNotFound $${166.97}$$ < $${180.53}$$
agent_suse_amd64_fips DataNotFound $${669.28}$$ < $${696.64}$$ DataNotFound $${165.56}$$ < $${178.79}$$
agent_suse_arm64 DataNotFound $${664.36}$$ < $${686.31}$$ DataNotFound $${153.2}$$ < $${161.22}$$
agent_suse_arm64_fips DataNotFound $${659.89}$$ < $${681.84}$$ DataNotFound $${152.72}$$ < $${160.18}$$
docker_agent_amd64 DataNotFound $${746.21}$$ < $${773.59}$$ DataNotFound $${251.82}$$ < $${266.06}$$
docker_agent_arm64 DataNotFound $${759.76}$$ < $${781.7}$$ DataNotFound $${242.43}$$ < $${251.85}$$
docker_agent_jmx_amd64 DataNotFound $${937.08}$$ < $${964.45}$$ DataNotFound $${320.44}$$ < $${334.68}$$
docker_agent_jmx_arm64 DataNotFound $${939.22}$$ < $${961.17}$$ DataNotFound $${307.03}$$ < $${316.44}$$
docker_cluster_agent_amd64 DataNotFound $${213.01}$$ < $${213.74}$$ DataNotFound $${72.26}$$ < $${73.14}$$
docker_cluster_agent_arm64 DataNotFound $${228.92}$$ < $${229.68}$$ DataNotFound $${68.53}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 DataNotFound $${7.07}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 DataNotFound $${38.44}$$ < $${39.3}$$ DataNotFound $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 DataNotFound $${37.13}$$ < $${37.94}$$ DataNotFound $${14.29}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${29.66}$$ < $${30.53}$$ DataNotFound $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 DataNotFound $${28.24}$$ < $${29.11}$$ DataNotFound $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 DataNotFound $${29.66}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 DataNotFound $${29.66}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 DataNotFound $${41.89}$$ < $${54.97}$$ DataNotFound $${10.9}$$ < $${14.45}$$
iot_agent_deb_arm64 DataNotFound $${39.71}$$ < $${51.9}$$ DataNotFound $${9.41}$$ < $${12.63}$$
iot_agent_deb_armhf DataNotFound $${39.58}$$ < $${51.84}$$ DataNotFound $${9.49}$$ < $${12.74}$$
iot_agent_rpm_amd64 DataNotFound $${41.89}$$ < $${54.97}$$ DataNotFound $${10.92}$$ < $${14.47}$$
iot_agent_suse_amd64 DataNotFound $${41.89}$$ < $${54.97}$$ DataNotFound $${10.92}$$ < $${14.47}$$

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 62a03883-840d-4fe9-85bd-94325f9ada7c

Baseline: 8310fe0
Comparison: ad43d86
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -10.89 [-12.04, -9.74] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_memory memory utilization +2.07 [+1.56, +2.59] 1 Logs
quality_gate_logs % cpu utilization +1.68 [-1.11, +4.46] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.25 [+0.20, +0.30] 1 Logs
ddot_logs memory utilization +0.20 [+0.14, +0.26] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.20 [+0.07, +0.32] 1 Logs
otlp_ingest_metrics memory utilization +0.09 [-0.03, +0.21] 1 Logs
quality_gate_idle_all_features memory utilization +0.08 [+0.04, +0.12] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.03 [-0.18, +0.25] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.62, +0.61] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.63, +0.60] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.67, +0.57] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.66, +0.55] 1 Logs
quality_gate_metrics_logs memory utilization -0.06 [-0.26, +0.15] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.06 [-0.21, +0.09] 1 Logs
ddot_metrics memory utilization -0.09 [-0.27, +0.09] 1 Logs
quality_gate_idle memory utilization -0.16 [-0.20, -0.12] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.20 [-0.40, -0.01] 1 Logs
file_tree memory utilization -0.28 [-0.32, -0.24] 1 Logs
otlp_ingest_logs memory utilization -0.49 [-0.62, -0.36] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.31 [-1.38, -1.24] 1 Logs
docker_containers_cpu % cpu utilization -10.89 [-12.04, -9.74] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 8/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

build_tags = get_default_build_tags(build="full-host-profiler")
ldflags = get_version_ldflags(ctx)
if os.environ.get("DELVE"):
gcflags = "all=-N -l"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but should it be gcflags = 'all="-N -l"'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required. See here

Co-authored-by: Pierre Gimalac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants