-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[OTAGENT-587] Add invoke task for the full host profiler #42105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
tasks/build_tags.py
Outdated
|
||
LOADER_TAGS = {"otlp"} | ||
|
||
FULL_HOST_PROFILER_TAGS = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had issues with empty tag set, which I fix in #41774 (not yet merged though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait your PR to be merged.
env = {"GO111MODULE": "on"} | ||
build_tags = get_default_build_tags(build="full-host-profiler") | ||
ldflags = get_version_ldflags(ctx) | ||
if os.environ.get("DELVE"): | ||
gcflags = "all=-N -l" | ||
else: | ||
gcflags = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use get_build_flags
like every other build task ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the otel agent does that too 🙃
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 8310fe0 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
✅ | docker_containers_cpu | % cpu utilization | -10.89 | [-12.04, -9.74] | 1 | Logs |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | docker_containers_memory | memory utilization | +2.07 | [+1.56, +2.59] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +1.68 | [-1.11, +4.46] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.25 | [+0.20, +0.30] | 1 | Logs |
➖ | ddot_logs | memory utilization | +0.20 | [+0.14, +0.26] | 1 | Logs |
➖ | ddot_metrics_sum_cumulative | memory utilization | +0.20 | [+0.07, +0.32] | 1 | Logs |
➖ | otlp_ingest_metrics | memory utilization | +0.09 | [-0.03, +0.21] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.08 | [+0.04, +0.12] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.03 | [-0.18, +0.25] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.62, +0.61] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.63, +0.60] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.67, +0.57] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.66, +0.55] | 1 | Logs |
➖ | quality_gate_metrics_logs | memory utilization | -0.06 | [-0.26, +0.15] | 1 | Logs bounds checks dashboard |
➖ | ddot_metrics_sum_delta | memory utilization | -0.06 | [-0.21, +0.09] | 1 | Logs |
➖ | ddot_metrics | memory utilization | -0.09 | [-0.27, +0.09] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.16 | [-0.20, -0.12] | 1 | Logs bounds checks dashboard |
➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.20 | [-0.40, -0.01] | 1 | Logs |
➖ | file_tree | memory utilization | -0.28 | [-0.32, -0.24] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | -0.49 | [-0.62, -0.36] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.31 | [-1.38, -1.24] | 1 | Logs |
✅ | docker_containers_cpu | % cpu utilization | -10.89 | [-12.04, -9.74] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
❌ | docker_containers_memory | memory_usage | 8/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
build_tags = get_default_build_tags(build="full-host-profiler") | ||
ldflags = get_version_ldflags(ctx) | ||
if os.environ.get("DELVE"): | ||
gcflags = "all=-N -l" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure but should it be gcflags = 'all="-N -l"'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is required. See here
Co-authored-by: Pierre Gimalac <[email protected]>
What does this PR do?
Add invoke task for the full host profiler
Motivation
Describe how you validated your changes
Run the task locally.
Additional Notes