Skip to content

Add *.local and *.internal to NPCollector default exclude filters #51138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexandreYang wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add *.local and *.internal to NPCollector default exclude filters #51138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6407992
empty
AlexandreYang May 20, 2026
bbb5eee
add default exclude filters for *.local and *.internal in NPCollector
AlexandreYang May 20, 2026
61d791b
Merge branch 'main' into alex/netpath_dynamic_tests_default_exclude
AlexandreYang May 21, 2026
af3233c
use regex strategy for *.local and *.internal default excludes
AlexandreYang May 21, 2026
af7c620
document rationale for default exclude filters in NPCollector
AlexandreYang May 21, 2026
fd8cac0
Revert "document rationale for default exclude filters in NPCollector"
AlexandreYang May 21, 2026
3b1f3d2
Revert "use regex strategy for *.local and *.internal default excludes"
AlexandreYang May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions comp/networkpath/npcollector/impl/connfilter/connfilter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,19 @@ filters:
},
expectedErr: "",
},
{
name: "default local and internal domains excluded",
config: ``,
expectedMatches: []expectedMatch{
{domain: "printer.local", shouldMatch: false},
{domain: "foo.bar.local", shouldMatch: false},
{domain: "compute.internal", shouldMatch: false},
{domain: "foo.bar.internal", shouldMatch: false},
{domain: "local.example.com", shouldMatch: true},
{domain: "internal.example.com", shouldMatch: true},
},
expectedCustomFilterCount: 0,
},
{
name: "include all domain",
config: `
Expand Down
8 changes: 8 additions & 0 deletions comp/networkpath/npcollector/impl/connfilter/defaultconnfilters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ func getDefaultConnFilters(site string, monitorIPWithoutDomain bool) []Config {
Type: FilterTypeExclude,
MatchDomain: "*.datadoghq.eu",
},
{
Type: FilterTypeExclude,
MatchDomain: "*.local",
},
{
Type: FilterTypeExclude,
MatchDomain: "*.internal",
},
}
if site != "" {
defaultConfig = append(defaultConfig, Config{
Expand Down
Loading