test(e2e/windows): ignore TiWorker.exe crash dumps#51140
Open
clarkb7 wants to merge 1 commit into
Open
Conversation
TiWorker.exe (Windows Modules Installer Worker) crashes have been observed in dotnet library installer E2E tests. Analysis of the dump shows the AV occurs in MPCLIENT!tlgEnableCallback after Microsoft Defender's MPCLIENT.DLL was unloaded without unregistering its ETW provider — a Microsoft issue unrelated to the Datadog agent. Ref: WINA-2712
clarkb7
added
changelog/no-changelog
Contributor
|
@codex review |
github-actions
Bot
added
the
short review
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
Contributor
Files inventory check summaryFile checks results against ancestor b661dc54: Results for datadog-agent_7.81.0~devel.git.19.09e54c9.pipeline.114380653-1_amd64.deb:No change detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
TiWorker.exetoDefaultIgnoredCrashDumpImagesso Windows Modules Installer Worker crashes are still collected as artifacts but do not fail Windows E2E tests.Motivation
Ref: WINA-2712. TiWorker crashes were failing
TestAgentMSIInstallsDotnetLibrary. Analysis of the dump from job 1698945354 with cdb:MPCLIENT!tlgEnableCallbackin an already-unloadedMPCLIENT.DLL(Microsoft Defender).ntdll!Etwp*notification thread frames.!analyze -vroot cause: "An ETW client DLL was unloaded but failed to unregister the ETW provider GUID prior to unload. This is a problem with the provider."This is a Microsoft Defender ETW unload race, unrelated to the Datadog agent.