test(e2e/windows): enable log_level: debug in service-test fixtures#51141
Open
clarkb7 wants to merge 1 commit into
Open
test(e2e/windows): enable log_level: debug in service-test fixtures#51141clarkb7 wants to merge 1 commit into
clarkb7 wants to merge 1 commit into
Conversation
Add log_level: debug to the core agent, system-probe, and security-agent fixtures used by the Windows service-test suite so that future failures (especially under driver verifier) include debug-level diagnostics.
clarkb7
added
changelog/no-changelog
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
Contributor
Files inventory check summaryFile checks results against ancestor a5a9a89a: Results for datadog-agent_7.81.0~devel.git.128.0b6d103.pipeline.114382410-1_amd64.deb:No change detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
log_level: debugto every fixture used bytest/new-e2e/tests/windows/service-test/— core agent (datadog*.yaml), system-probe (system-probe*.yaml), and security-agent (security-agent*.yaml).Motivation
When these tests fail (especially the driver-verifier variants), the captured agent logs only contain INFO and above. Several startup paths log at DEBUG only (e.g. the workloadmeta-readiness retry in
comp/core/autodiscovery/autodiscoveryimpl/autoconfig.go:174), which makes it hard to tell, from artifacts alone, whether a long gap in the log is one slow call or many fast retries spaced apart. Enabling debug-level logging in the fixtures means future failures land with the information needed to diagnose timing issues without a re-run.Describe how you validated your changes
Test-fixture-only change. No new tests added.