fakeintake: add --rc-key-data flag for ephemeral-env RC signing keys#51148
Draft
KevinFairise2 wants to merge 1 commit into
Draft
fakeintake: add --rc-key-data flag for ephemeral-env RC signing keys#51148KevinFairise2 wants to merge 1 commit into
KevinFairise2 wants to merge 1 commit into
Conversation
Adds a `--rc-key-data` CLI flag (and `WithRemoteConfigKeyData` option) that accepts a hex-encoded 32-byte ed25519 seed. When set, the key is never written to disk and takes precedence over `--rc-key-path`. This lets ephemeral environments (e.g. ECS Fargate) supply a fixed, pre-known signing key at provisioning time so the agent's config_root/director_root can be baked into its config upfront. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@codex review |
github-actions
Bot
added
the
short review
Contributor
|
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
Files inventory check summaryFile checks results against ancestor 2785003b: Results for datadog-agent_7.81.0~devel.git.50.e727fce.pipeline.114421701-1_amd64.deb:No change detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--rc-key-dataCLI flag (andWithRemoteConfigKeyDataoption) that accepts a hex-encoded 32-byte ed25519 seed. When set, the key is never written to disk and takes precedence over--rc-key-path. This lets ephemeral environments (e.g. ECS Fargate) supply a fixed, pre-known signing key at provisioning time so the agent's config_root/director_root can be baked into its config upfront.What does this PR do?
Motivation
Describe how you validated your changes
Additional Notes