fix(windows): remove duplicate strip of datadog-installer.exe

[clarkb7]

What does this PR do?

Remove the duplicate registration of datadog-installer.exe with windows_symbol_stripping_file in omnibus/config/projects/agent.rb. The binary was registered twice (once via the GO_BINARIES loop, once explicitly below it), so omnibus's Windows stripper ran the cp source target + strip pair twice. The second pass copied the already-stripped binary over the .debug file, leaving the published datadog-installer.exe.debug with no DWARF and no .gopclntab.

Motivation

When triaging a Windows installer hang from an xperf trace, addr2line and go tool addr2line both refused to symbolize installer stacks because the .debug file shipped in datadog-installer-*-x86_64.debug.zip had been stripped of all debug info. agent.exe and other Go binaries were unaffected because they are only listed once in GO_BINARIES.

[github-actions]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[datadog-prod-us1-5]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-agent | oracle: [21.3.0-xe]     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

Failed to ping oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor.

DataDog/datadog-agent | unit_tests_notify     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

Command 'ls junit-tests_*.tgz' failed with exit code 2. Error: No such file or directory.

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 925aba1 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 221b5f8f:

Results for datadog-agent_7.81.0~devel.git.256.925aba1.pipeline.115394260-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 221b5f8
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	746.109 MiB
✅	agent_deb_amd64_fips	703.887 MiB
✅	agent_heroku_amd64	310.693 MiB
✅	agent_msi	610.133 MiB
✅	agent_rpm_amd64	746.092 MiB
✅	agent_rpm_amd64_fips	703.870 MiB
✅	agent_rpm_arm64	723.665 MiB
✅	agent_rpm_arm64_fips	684.588 MiB
✅	agent_suse_amd64	746.092 MiB
✅	agent_suse_amd64_fips	703.870 MiB
✅	agent_suse_arm64	723.665 MiB
✅	agent_suse_arm64_fips	684.588 MiB
✅	docker_agent_amd64	806.269 MiB
✅	docker_agent_arm64	808.643 MiB
✅	docker_agent_jmx_amd64	997.189 MiB
✅	docker_agent_jmx_arm64	988.341 MiB
✅	docker_cluster_agent_amd64	207.074 MiB
✅	docker_cluster_agent_arm64	221.016 MiB
✅	docker_cws_instrumentation_amd64	7.154 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.499 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	docker_host_profiler_amd64	302.092 MiB
✅	docker_host_profiler_arm64	313.592 MiB
✅	dogstatsd_deb_amd64	30.155 MiB
✅	dogstatsd_deb_arm64	28.280 MiB
✅	dogstatsd_rpm_amd64	30.155 MiB
✅	dogstatsd_suse_amd64	30.155 MiB
✅	iot_agent_deb_amd64	44.468 MiB
✅	iot_agent_deb_arm64	41.437 MiB
✅	iot_agent_deb_armhf	42.150 MiB
✅	iot_agent_rpm_amd64	44.469 MiB
✅	iot_agent_suse_amd64	44.469 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e63e1b6d-f387-4502-8929-17e92808cc61

Baseline: a53c978
Comparison: 7880749
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.47	[-2.46, +3.41]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.52	[+1.51, +3.54]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.73	[+0.69, +0.77]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.60	[+0.41, +0.79]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.47	[-2.46, +3.41]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.47	[+0.22, +0.72]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.36	[+0.12, +0.59]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.16	[+0.01, +0.32]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.04	[-0.12, +0.19]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.03	[-0.36, +0.42]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.02	[-0.19, +0.22]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.09, +0.10]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.13, +0.12]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.50, +0.48]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.22, +0.18]	1	Logs
➖	ddot_metrics	memory utilization	-0.02	[-0.21, +0.17]	1	Logs
➖	quality_gate_idle	memory utilization	-0.03	[-0.08, +0.02]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.05	[-0.49, +0.39]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.10	[-0.14, -0.06]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	-0.23	[-0.29, -0.16]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.24	[-0.29, -0.19]	1	Logs
➖	docker_containers_memory	memory utilization	-0.42	[-0.52, -0.32]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.45	[-0.64, -0.27]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.48	[-0.58, -0.37]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	541 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	244.14MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	693 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	143.25MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	741.66KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	471.94MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	176.45MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.41MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	344.71 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	375.09MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.