Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make example stacks use new major version #367

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Feb 20, 2025

What does this PR do?

  1. Make the 6 example stacks under examples/ use the new major version by changing dependency files and imports.
  2. Make the Python stacks at integration_tests/stacks_python use the new major version
  3. Delete code that references APIs that no longer exist.
  4. Delete examples/step-functions-go-stack/ddcdkconstruct folder, which was for local testing and was added by mistake.

Motivation

Testing Guidelines

  1. All the six example stacks were deployed successfully: {Node.js, Python, Go} $\times$ {Lambda, Step Function}
  2. Integration test (scripts/run_integration_tests.sh) was successful.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 force-pushed the yiming.luo/v2-in-examples branch from 42f7cd4 to 4ff6542 Compare February 20, 2025 20:51
@lym953 lym953 force-pushed the yiming.luo/fix-go-pkg branch from feaefe1 to 82ef701 Compare February 20, 2025 21:23
@lym953 lym953 force-pushed the yiming.luo/v2-in-examples branch from 4ff6542 to bd90d8b Compare February 20, 2025 21:29
@lym953 lym953 force-pushed the yiming.luo/fix-go-pkg branch from 82ef701 to a7e3ed7 Compare February 20, 2025 21:31
@lym953 lym953 force-pushed the yiming.luo/v2-in-examples branch 3 times, most recently from 93a2a2d to 7c648eb Compare February 20, 2025 21:39
Base automatically changed from yiming.luo/fix-go-pkg to main February 20, 2025 21:42
@lym953 lym953 force-pushed the yiming.luo/v2-in-examples branch 2 times, most recently from d67b117 to 85d8167 Compare February 21, 2025 19:58
@lym953 lym953 changed the base branch from main to yiming.luo/update-py-snapshot February 21, 2025 20:00
@lym953 lym953 force-pushed the yiming.luo/v2-in-examples branch from 85d8167 to 2a778c2 Compare February 21, 2025 20:02
@lym953 lym953 marked this pull request as ready for review February 21, 2025 20:03
@lym953 lym953 requested review from a team as code owners February 21, 2025 20:03
@lym953 lym953 requested a review from hannahqjiang February 21, 2025 20:03
Base automatically changed from yiming.luo/update-py-snapshot to main February 21, 2025 20:29
@lym953 lym953 force-pushed the yiming.luo/v2-in-examples branch from 2a778c2 to 01b765a Compare February 21, 2025 20:30
@lym953 lym953 merged commit e5b4a46 into main Feb 21, 2025
8 checks passed
@lym953 lym953 deleted the yiming.luo/v2-in-examples branch February 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants