APPSEC-60188: downgrade integration response parsing log to debug #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message was incorrectly kept as `warn!` when we donwgraded all these log messages to `debug!` and this is very noisy in customer accounts. JJ-Change-Id: zkowts
RomainMuller
changed the title
| } | ||
| Ok(None) => debug!("aap: no response payload available"), | ||
| Err(e) => warn!("aap: failed to parse invocation result payload: {e}"), | ||
| Err(e) => debug!("aap: failed to parse invocation result payload: {e}"), |
Contributor
There was a problem hiding this comment.
Why is this a noisy log message for customers? Shouldn't this not be happening in most cases?
Contributor
Author
There was a problem hiding this comment.
Basically, if this happens on a given Lambda function, then it is likely to happen for all invocations, as what we are parsing is the "core" structure of the API GW "Lambda Proxy" response... which is likely to be structured identically for all responses.
Ideally, we would produce telemetry logs for these conditions, so that we can be made aware of these issues (as you said, it should not happen unless we have a bug -- as was the case here and it's been fixed via #960) without causing a logs surcharge to the customer.
jchrostek-dd
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message was incorrectly kept as
warn!when we donwgraded all these log messages todebug!and this is very noisy in customer accounts.JJ-Change-Id: zkowts
ZD: 2375557
Jira: APPSEC-60188