Conversation
e1fe582 to
9141673
Compare
|
|
||
| if not isinstance(value, numbers.Number): | ||
| logger.warning( | ||
| "Ignoring metric submission for metric '%s' because the value is not numeric: %r", |
Contributor
There was a problem hiding this comment.
Is there a chance that lambda_metric("kittens", "1") works? If so, then maybe we do something like
try:
int(value)
except:
# log warning and return
return
Contributor
Author
There was a problem hiding this comment.
Yes, that does work surprisingly. Making the change and updating PR description!
purple4reina
approved these changes
Jan 30, 2025
0242219 to
8832023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
lambda_metricis called with an invalid name or value, we skip the metric and log a warning. This ensures that if multiple metrics are sent in one lambda invocation and only one is invalid, the rest still get delivered.Motivation
#347
Testing Guidelines
Unit tests
Manual testing; I have a lambda with this handler:
and I see the correct 5 metrics delivered, while seeing logs
Additional Notes
Types of Changes
Check all that apply