bugfix: error metrics should be sent during exception handling#626
Merged
joeyzhao2018 merged 1 commit intomainfrom Jun 26, 2025
Merged
bugfix: error metrics should be sent during exception handling#626joeyzhao2018 merged 1 commit intomainfrom
joeyzhao2018 merged 1 commit intomainfrom
Conversation
nhulston
reviewed
Jun 25, 2025
datadog_lambda/wrapper.py
Outdated
Comment on lines
167
to
171
| except Exception: | ||
| if not should_use_extension: | ||
| if should_use_extension: | ||
| from datadog_lambda.metric import submit_errors_metric | ||
|
|
||
| submit_errors_metric(context) |
Contributor
There was a problem hiding this comment.
before, it worked like:
except Exception:
from datadog_lambda.metric import submit_errors_metric
submit_errors_metric(context)we weren't checking for extension at all
Contributor
Author
There was a problem hiding this comment.
updated accordingly.
joeyzhao2018
force-pushed
the
joey/fix_error_metrics
branch
4 times, most recently
from
59e1bc0 to
9413991
Compare
Signed-off-by: Joey Zhao <5253430+joeyzhao2018@users.noreply.github.com>
joeyzhao2018
force-pushed
the
joey/fix_error_metrics
branch
from
9413991 to
bb41689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply