Conversation
|
Thank you so much for doing this! It looks like we can now decrease our expectations of unzip layer size in our tests. Would you mind changing the 23 to a 22 in this file as part of this PR? |
|
And once this PR is merged, you can make a similar change in our serverless-tools repo which runs check layer size tests in dd-trace-py. https://github.com/DataDog/serverless-tools/blob/8ffeeabffc821fe72b2d0848ac2abf09fbc94cf6/.gitlab/setup.sh#L72 |
I updated this pull request and created a new one in serverless-tools https://github.com/DataDog/serverless-tools/pull/71 |
APPSEC-58746
PR DataDog/dd-trace-py#12774 was merged to address this.
What does this PR do?
Re-removes the
ddtrace/appsec/_iast/_ast/iastpatch*.sofile from the python layers.Motivation
A change was made by the appsec team to the python tracer which inadvertently caused an import attempt on
ddtrace/appsec/_iast/_ast/iastpatch*.so. This import would fail when using our python layer. We remove this file because it is large and iast doesn't work in serverless anyway.Testing Guidelines
There is another open PR in the python tracer DataDog/dd-trace-py#14420 which will add explicit testing to ensure none of our removed files get imported.
Additional Notes
Note that the mentioned PR is merged but not yet released! Do not merge this until that PR has been released!
Types of Changes
Check all that apply