Skip to content

Conversation

@scottopell
Copy link
Contributor

What does this PR do?

Currently there are two branches in this exception handler that print the exact same text. This PR adds some way to distinguish them if they appear in error logs.

Description of the Change

This PR fixes one small typo in a comment and then adds some additional context to one of the error types in order to distinguish them.

Docs for herror and gaierror

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@scottopell scottopell added the changelog/no-changelog Changes don't appear in changelog label Oct 12, 2023
@scottopell scottopell requested a review from a team as a code owner October 12, 2023 15:06
@scottopell scottopell requested a review from a team October 12, 2023 15:06
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog Changes don't appear in changelog stale Stale - Bot reminder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants