Skip to content

Fix SLO update via dogshell #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

Fix SLO update via dogshell #889

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4c6b3e
Fix SLO update via dogshell
aserrallerios Feb 12, 2025
22b0d18
Do not ignore SLO name on updates
aserrallerios Feb 13, 2025
b3902bd
Merge branch 'master' into patch-1
jack-edmonds-dd Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datadog/dogshell/service_level_objective.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def _update(cls, args):
for threshold_str in args.thresholds.split(","):
parts = threshold_str.split(":")
timeframe = parts[0]
target = parts[1]
target = float(parts[1])

threshold = {"timeframe": timeframe, "target": target}

Expand All @@ -273,6 +273,9 @@ def _update(cls, args):
thresholds.append(threshold)
params["thresholds"] = thresholds

if args.name:
params["name"] = args.name

if args.description:
params["description"] = args.description

Expand Down
Loading