Skip to content

Conversation

@n0ts
Copy link
Contributor

@n0ts n0ts commented Dec 21, 2016

Hi, I add DD_VERSION environment variable in datadog agent scripts.
Could you review it?

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks.
Out of curiosity, why do you need the DD_VERSION variable?

fi
fi
$sudo_cmd yum -y --disablerepo='*' --enablerepo='datadog' install datadog-agent || $sudo_cmd yum -y install datadog-agent
if [ -n "$dd_version" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about assigning dd_agent variable in the if/else block at line 58?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd_agent like 5.8.5

*****
"
$sudo_cmd apt-get install -y --force-yes datadog-agent
if [ -n "$dd_version" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

echo -e "\033[34m\n* Refreshing repositories\n\033[0m"
$sudo_cmd zypper --non-interactive refresh

if [ -n "$dd_version" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@masci masci added this to the Triage milestone Jan 24, 2017
Copy link
Contributor Author

@n0ts n0ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to all same datadog agent version in my production servers.

fi
fi
$sudo_cmd yum -y --disablerepo='*' --enablerepo='datadog' install datadog-agent || $sudo_cmd yum -y install datadog-agent
if [ -n "$dd_version" ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd_agent like 5.8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants