Skip to content

chore: log received and expected if reasonable when len() mismatch #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: log received and expected if reasonable when len() mismatch #156

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db3a6be
edit AssertionError message to show actual received and expected if r…
ZStriker19 Jan 9, 2024
db3af01
formatting
ZStriker19 Jan 9, 2024
66863e5
slight wording edit
ZStriker19 Jan 9, 2024
6cdd05d
remove names
ZStriker19 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ddapm_test_agent/trace_snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,15 +262,11 @@ def _compare_traces(expected: Trace, received: Trace, ignored: Set[str]) -> None

The given traces are assumed to be in BFS order.
"""
if len(received) > len(expected):
names = ["'%s'" % s["name"] for s in received[len(expected) - len(received) :]]
if len(received) != len(expected):
raise AssertionError(
f"Received more spans ({len(received)}) than expected ({len(expected)}). Received unmatched spans: {', '.join(names)}"
)
elif len(expected) > len(received):
names = ["'%s'" % s["name"] for s in expected[len(received) - len(expected) :]]
raise AssertionError(
f"Received fewer spans ({len(received)}) than expected ({len(expected)}). Expected unmatched spans: {', '.join(names)}"
f"Received different number of spans ({len(received)}) than expected ({len(expected)})."
f"If spans<=20, will display received and expected.\nReceived: {received if (len(received) <= 20) else 'too long'}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this render? I imagine the raw python dicts might be difficult to read (which is why we had reduced it to just the span names before). What do you think about formatting them to make them more readable?

f"\nExpected: {expected if (len(expected) <= 20) else 'too long'}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we resort to just the names in this case? Just so that there's at least some signal

)

for s_exp, s_rec in zip(expected, received):
Expand Down