[CHORE] Update DatadogSDKTesting to 2.7.6#3015
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb175a86d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
ypopovych
force-pushed
the
ypopovych/update-datadog-sdk-testing-2.7.5
branch
from
eb175a8 to
bd43337
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae41bf66a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| requirement = { | ||
| kind = upToNextMinorVersion; | ||
| minimumVersion = 2.7.0; | ||
| minimumVersion = 2.7.6; |
There was a problem hiding this comment.
When a supported developer or CI lane still uses the repo's documented minimum Xcode 16 environment (ZEN.md says the minimum accepted Xcode version is 16), resolving this package now fails before the build because dd-sdk-swift-testing 2.7.6 declares swift-tools-version:6.2 whereas the previous 2.7.0 manifest used 5.9. Please either stay on a DatadogSDKTesting release whose manifest Xcode 16 can parse or explicitly raise the repo's Xcode floor along with this bump.
Useful? React with 👍 / 👎.
ypopovych
force-pushed
the
ypopovych/update-datadog-sdk-testing-2.7.5
branch
from
ae41bf6 to
ce44a0c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce44a0c899
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ypopovych
force-pushed
the
ypopovych/update-datadog-sdk-testing-2.7.5
branch
from
596c4cb to
85a4356
Compare
ypopovych
force-pushed
the
ypopovych/update-datadog-sdk-testing-2.7.5
branch
from
85a4356 to
7ecac58
Compare
2 participants
What and why?
Updates the
DatadogSDKTestingdependency from 2.7.0 to 2.7.6. Also enablesDatadogSDKTestingfor all platforms, adds@Suite(.datadogTesting)to Swift Testing suites, and importsDatadogSDKTestingin Swift Testing test targets.DatadogSDKTestingrequires iOS 15+, butPackage.swift's platform floor is iOS 12 and SwiftPM has no per-target deployment override — so it can only be linked throughDatadog.xcworkspace, not declared as aPackage.swiftdependency. Without a fallback, any SPM-only build (swift build/swift test,tools/spm-build.sh) fails to resolveDatadogSDKTestingin the test targets that use it.How?
dd-sdk-swift-testing2.7.6.datadogTestingand added the necessary importTestUtilities/Sources/Helpers/DatadogSDKTestingCompat.swift:@_exported import DatadogSDKTestingwhen it's resolvable (real Xcode-project build), otherwise a local no-op stand-in for.datadogTestingand theTag.dd.retriable/.nonretriable/.tia.skippable/.unskippabletags — so SPM-only builds compile without needing the real dependencyTestUtilities, andTestUtilities's Xcode target already linksDatadogSDKTesting, this fallback lives in one place instead of being duplicated per test fileReview checklist
make api-surfacewhen adding new APIs