[RUM-16387] Store remote configuration in Application Support#3029
Open
maxep wants to merge 1 commit into
Open
[RUM-16387] Store remote configuration in Application Support#3029maxep wants to merge 1 commit into
maxep wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcd9336a62
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The core directory lives under /Library/Caches, which the system may purge under disk pressure — losing the persisted remote configuration and reverting to defaults. Store remote configuration under /Library/Application Support instead, which is not purged. Adds Directory.applicationSupport() and an injectable persistentDirectory on the configuration; the rest of the core stays in Caches.
maxep
force-pushed
the
maxep/RUM-16387/remote-config-persistent-storage
branch
from
dcd9336 to
36b263e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
The SDK core directory lives under
/Library/Caches, which the system may purge under disk pressure. When that happens the persisted remote configuration is lost and the SDK reverts to defaults until the next successful fetch. This stores remote configuration under/Library/Application Supportinstead, which the system does not purge.How?
Directory.applicationSupport()alongsideDirectory.cache().persistentDirectoryon the configuration (defaults to Application Support), mirroringsystemDirectory.RemoteConfigurationProvidernow gets an instance-scoped directory built frompersistentDirectory()(…/Application Support/com.datadoghq/v2/<uuid>/). All other (purgeable) Feature data stays under/Library/Caches.Notes: the config directory is included in iCloud/iTunes backups (Application Support default — intentional). Application Support is used on all platforms; on tvOS persistence remains best-effort (no worse than today's Caches).
Review checklist
make api-surfacewhen adding new APIs