Add pagination metrics for known tests fetch#292
Draft
calvinbayer wants to merge 1 commit into
Draft
Conversation
bbc2c00 to
f3b3530
Compare
Add three new distribution metrics to track known tests pagination: - civisibility.known_tests.pages_fetched - number of pages fetched - civisibility.known_tests.total_fetch_ms - wall-clock time for entire fetch - civisibility.known_tests.total_request_ms - sum of per-page request times Metrics are emitted only on successful completion of pagination. Changes: - Extended KnownTestsResult with metric fields - Added metric definitions to TelemetryMetrics - Updated fetchKnownTests to track timing and emit metrics Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
f3b3530 to
6b3bb0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds three new distribution metrics to track known tests (Early Flake Detection) pagination behavior:
civisibility.known_tests.pages_fetched- Number of pages fetched during paginationcivisibility.known_tests.total_fetch_ms- Wall-clock time from first to last page requestcivisibility.known_tests.total_request_ms- Sum of individual per-page request durationsMotivation
Currently, only per-request timing is tracked. These new metrics provide observability into:
Implementation Details
KnownTestsResultstruct with three metric fieldsTelemetryMetricsfetchKnownTeststo track timing and emit metrics on successTesting
Checklist