[Dynamic Instrumentation] DEBUG-3322 dynamic configuration (in-product enablement) #6627

dudikeleti · 2025-02-05T10:58:23Z

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging · 2025-02-05T11:48:02Z

Datadog Report

Branch report: dudik/debugger-dynamic-configuration
Commit report: 5c60b47
Test service: dd-trace-dotnet

❌ 5424 Failed (0 Known Flaky), 220149 Passed, 3325 Skipped, 31h 21m 53.32s Total Time

❌ Failed Tests (5424)

This report shows up to 5 failed tests.

TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: ExceptionReplay.AspNetCore5.RethrowTest.received.txt
 Verified: ExceptionReplay.AspNetCore5.RethrowTest.verified.txt
 Received Content:
 [
   {
     "dd.span_id": "ScrubbedValue",
     "dd.trace_id": "ScrubbedValue",
     "ddsource": "dd_debugger",
 ...

TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: ExceptionReplay.AspNetCore5.RecursiveExceptionTest.received.txt
 Verified: ExceptionReplay.AspNetCore5.RecursiveExceptionTest.verified.txt
 Received Content:
 [
   {
     "dd.span_id": "ScrubbedValue",
     "dd.trace_id": "ScrubbedValue",
     "ddsource": "dd_debugger",
 ...

TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: ExceptionReplay.AspNetCore5.ExceptionCaughtAndRethrownAsInnerTest.received.txt
 Verified: ExceptionReplay.AspNetCore5.ExceptionCaughtAndRethrownAsInnerTest.verified.txt
 Received Content:
 [
   {
     "dd.span_id": "ScrubbedValue",
     "dd.trace_id": "ScrubbedValue",
     "ddsource": "dd_debugger",
 ...

TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: ExceptionReplay.AspNetCore5.DeterministicComplexExceptionPropagationTest.received.txt
 Verified: ExceptionReplay.AspNetCore5.DeterministicComplexExceptionPropagationTest.verified.txt
 Received Content:
 [
   {
     "dd.span_id": "ScrubbedValue",
     "dd.trace_id": "ScrubbedValue",
     "ddsource": "dd_debugger",
 ...

TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: ExceptionReplay.AspNetCore5.ExceptionCaughtAndRethrownAsInnerTest.received.txt
 Verified: ExceptionReplay.AspNetCore5.ExceptionCaughtAndRethrownAsInnerTest.verified.txt
 Received Content:
 [
   {
     "dd.span_id": "ScrubbedValue",
     "dd.trace_id": "ScrubbedValue",
     "ddsource": "dd_debugger",
 ...

andrewlock · 2025-02-05T12:00:11Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6627) - mean (76ms)  : 71, 80
     .   : milestone, 76,
    master - mean (71ms)  : 65, 77
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6627) - mean (1,049ms)  : 1031, 1067
     .   : milestone, 1049,
    master - mean (1,009ms)  : 985, 1033
     .   : milestone, 1009,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6627) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6627) - mean (714ms)  : 701, 727
     .   : milestone, 714,
    master - mean (699ms)  : 680, 719
     .   : milestone, 699,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6627) - mean (96ms)  : 93, 99
     .   : milestone, 96,
    master - mean (95ms)  : 92, 98
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (6627) - mean (681ms)  : 668, 694
     .   : milestone, 681,
    master - mean (651ms)  : 636, 666
     .   : milestone, 651,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6627) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 186, 197
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6627) - mean (1,108ms)  : 1084, 1133
     .   : milestone, 1108,
    master - mean (1,106ms)  : 1079, 1134
     .   : milestone, 1106,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6627) - mean (270ms)  : 266, 274
     .   : milestone, 270,
    master - mean (271ms)  : 265, 277
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6627) - mean (873ms)  : 850, 896
     .   : milestone, 873,
    master - mean (865ms)  : 833, 897
     .   : milestone, 865,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6627) - mean (262ms)  : 259, 266
     .   : milestone, 262,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6627) - mean (868ms)  : 839, 897
     .   : milestone, 868,
    master - mean (849ms)  : 815, 882
     .   : milestone, 849,

andrewlock · 2025-02-05T12:21:16Z

Benchmarks Report for tracer 🐌

Benchmarks for #6627 compared to master:

1 benchmarks are slower, with geometric mean 1.154
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.86μs	43ns	262ns	0.0203	0.00811	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	55.5ns	324ns	0.0199	0.00996	0	5.8 KB
master	`StartStopWithChild`	net472	15.9μs	38.1ns	142ns	1.04	0.307	0.0944	6.21 KB
#6627	`StartStopWithChild`	net6.0	8.19μs	47.2ns	365ns	0.0163	0.00816	0	5.61 KB
#6627	`StartStopWithChild`	netcoreapp3.1	11μs	63.4ns	482ns	0.0167	0.00557	0	5.81 KB
#6627	`StartStopWithChild`	net472	16.2μs	67.7ns	253ns	1.04	0.311	0.106	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	492μs	486ns	1.82μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	700μs	282ns	1.05μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	848μs	626ns	2.34μs	0.422	3.3 KB
#6627	`WriteAndFlushEnrichedTraces`	net6.0	505μs	775ns	3μs	0	2.7 KB
#6627	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	377ns	1.46μs	0	2.7 KB
#6627	`WriteAndFlushEnrichedTraces`	net472	848μs	540ns	2.09μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	132μs	417ns	1.61μs	0.135	14.47 KB
master	`SendRequest`	netcoreapp3.1	147μs	396ns	1.53μs	0.22	17.27 KB
master	`SendRequest`	net472	0.00199ns	0.000288ns	0.00112ns	0	0 b
#6627	`SendRequest`	net6.0	128μs	511ns	1.98μs	0.191	14.47 KB
#6627	`SendRequest`	netcoreapp3.1	147μs	199ns	772ns	0.221	17.27 KB
#6627	`SendRequest`	net472	0.00354ns	0.00144ns	0.00539ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6627

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.87 KB	41.63 KB	-244 B	-0.58%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	608μs	3.32μs	18.8μs	0.604	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	3.78μs	27.5μs	0.338	0	0	41.69 KB
master	`WriteAndFlushEnrichedTraces`	net472	840μs	2.83μs	10.6μs	8.22	2.47	0.411	53.34 KB
#6627	`WriteAndFlushEnrichedTraces`	net6.0	567μs	2.63μs	9.83μs	0.546	0	0	41.63 KB
#6627	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	704μs	3.94μs	33.7μs	0.334	0	0	41.71 KB
#6627	`WriteAndFlushEnrichedTraces`	net472	855μs	2.24μs	8.67μs	8.39	2.52	0.419	53.33 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.44μs	2.09ns	8.1ns	0.0138	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	2.38ns	9.22ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.07μs	4.15ns	16.1ns	0.156	0.00103	987 B
#6627	`ExecuteNonQuery`	net6.0	1.43μs	1.99ns	7.7ns	0.015	0	1.02 KB
#6627	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.95ns	7.55ns	0.0135	0	1.02 KB
#6627	`ExecuteNonQuery`	net472	2.1μs	2.51ns	9.4ns	0.157	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.21μs	0.404ns	1.51ns	0.0139	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.958ns	3.59ns	0.0128	0	976 B
master	`CallElasticsearch`	net472	2.46μs	2.36ns	9.14ns	0.158	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.37μs	1.01ns	3.76ns	0.013	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	0.965ns	3.61ns	0.0139	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.67μs	1.97ns	7.63ns	0.166	0	1.05 KB
#6627	`CallElasticsearch`	net6.0	1.16μs	0.347ns	1.3ns	0.0139	0	976 B
#6627	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.968ns	3.62ns	0.013	0	976 B
#6627	`CallElasticsearch`	net472	2.53μs	3.4ns	13.2ns	0.157	0	995 B
#6627	`CallElasticsearchAsync`	net6.0	1.28μs	0.963ns	3.73ns	0.0135	0.000642	952 B
#6627	`CallElasticsearchAsync`	netcoreapp3.1	1.59μs	1.63ns	6.12ns	0.0137	0	1.02 KB
#6627	`CallElasticsearchAsync`	net472	2.48μs	2.09ns	8.09ns	0.167	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.44μs	1.02ns	3.96ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.954ns	3.7ns	0.012	952 B
master	`ExecuteAsync`	net472	1.86μs	0.559ns	2.09ns	0.145	915 B
#6627	`ExecuteAsync`	net6.0	1.3μs	1.16ns	4.36ns	0.0134	952 B
#6627	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.901ns	3.49ns	0.0126	952 B
#6627	`ExecuteAsync`	net472	1.86μs	1.24ns	4.64ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.41μs	1.19ns	4.47ns	0.0331	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.35μs	3.47ns	13ns	0.0374	2.85 KB
master	`SendAsync`	net472	7.37μs	2.03ns	7.85ns	0.495	3.12 KB
#6627	`SendAsync`	net6.0	4.39μs	1.04ns	3.9ns	0.0329	2.31 KB
#6627	`SendAsync`	netcoreapp3.1	5.42μs	1.1ns	3.96ns	0.0382	2.85 KB
#6627	`SendAsync`	net472	7.43μs	1.79ns	6.95ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.58μs	0.493ns	1.78ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.19μs	1.07ns	3.99ns	0.0228	1.64 KB
master	`EnrichedLog`	net472	2.67μs	4.35ns	16.9ns	0.25	1.57 KB
#6627	`EnrichedLog`	net6.0	1.59μs	1.36ns	4.9ns	0.023	1.64 KB
#6627	`EnrichedLog`	netcoreapp3.1	2.23μs	0.908ns	3.4ns	0.0223	1.64 KB
#6627	`EnrichedLog`	net472	2.64μs	1.77ns	6.86ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	212ns	822ns	0.0558	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	148ns	573ns	0.0582	0	4.28 KB
master	`EnrichedLog`	net472	151μs	82.1ns	307ns	0.681	0.227	4.46 KB
#6627	`EnrichedLog`	net6.0	111μs	118ns	457ns	0.0551	0	4.29 KB
#6627	`EnrichedLog`	netcoreapp3.1	117μs	440ns	1.7μs	0.0578	0	4.29 KB
#6627	`EnrichedLog`	net472	150μs	186ns	719ns	0.672	0.224	4.47 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.11μs	0.496ns	1.72ns	0.0311	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	2.35ns	8.79ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	5.03μs	1.01ns	3.79ns	0.32	2.02 KB
#6627	`EnrichedLog`	net6.0	2.99μs	1.83ns	7.09ns	0.0299	2.2 KB
#6627	`EnrichedLog`	netcoreapp3.1	4.01μs	1.33ns	4.99ns	0.0282	2.2 KB
#6627	`EnrichedLog`	net472	4.96μs	2.34ns	9.08ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6627

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.154	1,271.89	1,467.57

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.27μs	0.38ns	1.47ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.486ns	1.68ns	0.015	1.14 KB
master	`SendReceive`	net472	2.12μs	2.85ns	11.1ns	0.183	1.16 KB
#6627	`SendReceive`	net6.0	1.46μs	1.64ns	6.35ns	0.016	1.14 KB
#6627	`SendReceive`	netcoreapp3.1	1.81μs	0.733ns	2.74ns	0.0155	1.14 KB
#6627	`SendReceive`	net472	2.1μs	1.12ns	4.21ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	2.77μs	1.19ns	4.44ns	0.022	0	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.97μs	5.6ns	20.9ns	0.0217	0	1.65 KB
master	`EnrichedLog`	net472	4.3μs	3.26ns	12.6ns	0.323	0	2.04 KB
#6627	`EnrichedLog`	net6.0	2.77μs	1.34ns	4.84ns	0.0225	0.00141	1.6 KB
#6627	`EnrichedLog`	netcoreapp3.1	3.89μs	2.56ns	9.21ns	0.0214	0	1.65 KB
#6627	`EnrichedLog`	net472	4.24μs	4.1ns	15.9ns	0.323	0.00212	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`StartFinishSpan`	net6.0	391ns	0.461ns	1.79ns	0.00817	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	557ns	0.82ns	3.18ns	0.00784	0	576 B
master	`StartFinishSpan`	net472	584ns	1.27ns	4.91ns	0.0915	0	578 B
master	`StartFinishScope`	net6.0	515ns	0.487ns	1.89ns	0.00983	0	696 B
master	`StartFinishScope`	netcoreapp3.1	742ns	1.68ns	6.07ns	0.00932	0	696 B
master	`StartFinishScope`	net472	839ns	2.27ns	8.78ns	0.105	0	658 B
#6627	`StartFinishSpan`	net6.0	403ns	0.0741ns	0.267ns	0.00834	0	576 B
#6627	`StartFinishSpan`	netcoreapp3.1	545ns	0.411ns	1.59ns	0.0079	0.000272	576 B
#6627	`StartFinishSpan`	net472	587ns	0.391ns	1.51ns	0.0917	0	578 B
#6627	`StartFinishScope`	net6.0	517ns	0.278ns	1ns	0.0099	0	696 B
#6627	`StartFinishScope`	netcoreapp3.1	671ns	0.396ns	1.53ns	0.0094	0	696 B
#6627	`StartFinishScope`	net472	805ns	0.33ns	1.23ns	0.104	0	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	733ns	1.3ns	5.05ns	0.00951	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	907ns	1.48ns	5.73ns	0.00936	696 B
master	`RunOnMethodBegin`	net472	1.16μs	1.52ns	5.88ns	0.105	658 B
#6627	`RunOnMethodBegin`	net6.0	671ns	0.28ns	1.05ns	0.01	696 B
#6627	`RunOnMethodBegin`	netcoreapp3.1	904ns	0.615ns	2.13ns	0.00958	696 B
#6627	`RunOnMethodBegin`	net472	1.12μs	2.6ns	10.1ns	0.105	658 B

…e remote enablement

dudikeleti force-pushed the dudik/debugger-dynamic-configuration branch 2 times, most recently from 6ec6c06 to 635fe17 Compare February 13, 2025 15:25

dudikeleti changed the title ~~Dudik/debugger dynamic configuration~~ [Dynamic Instrumentation] DEBUG-3322 Support dynamic configuration (in-product enablement) Feb 13, 2025

dudikeleti changed the title ~~[Dynamic Instrumentation] DEBUG-3322 Support dynamic configuration (in-product enablement)~~ [Dynamic Instrumentation] DEBUG-3322 dynamic configuration (in-product enablement) Feb 13, 2025

dudikeleti force-pushed the dudik/debugger-dynamic-configuration branch from 635fe17 to 8527ea2 Compare February 13, 2025 17:46

github-actions bot added the area:debugger label Feb 13, 2025

dudikeleti force-pushed the dudik/debugger-dynamic-configuration branch from 8527ea2 to 4a0c458 Compare February 14, 2025 17:25

dudikeleti and others added 20 commits February 19, 2025 02:14

refactor LiveDebugger to support dynamic configuration

b3c14d9

wip

f7cc164

wip

722a419

WIP: Refactor debugger features to support configuration updates

8b248b5

implement interface correctly

09eb57a

WIP update configuration

7dbb6e3

Fix build

77be3d0

let DebuggerManager to manage the updates

2fa7f72

Fix debugger initialization

b7029a6

wip - set rcm debugger capabilities

4b53fee

temp

a61dd6e

Add mapping for dynamic configs and fix equals logic

151c8f3

fix build after rebase

611d48d

Rename

27ae664

check for enable code origin

5850002

Fix unit tests

5411eff

Make ExceptionDebugging non static

9ed127f

remove initialization from TracerManager

693b7b6

DebuggerManager wip

f643376

Properly disposing Exception Cases as part of Exception Replay for th…

2b6bc72

…e remote enablement

dudikeleti force-pushed the dudik/debugger-dynamic-configuration branch from b28f981 to 2b6bc72 Compare February 19, 2025 01:14

dudikeleti added 3 commits February 19, 2025 15:06

fix service name and change log string to wait for

1ee76f9

support nullable in settings and lock update operation

95189d4

make unit tests pass

d40a7da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] DEBUG-3322 dynamic configuration (in-product enablement) #6627

[Dynamic Instrumentation] DEBUG-3322 dynamic configuration (in-product enablement) #6627

dudikeleti commented Feb 5, 2025

datadog-ddstaging bot commented Feb 5, 2025 •

edited

Loading

andrewlock commented Feb 5, 2025 •

edited

Loading

andrewlock commented Feb 5, 2025 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6627

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6627

Raw results

Raw results

Raw results

Raw results

[Dynamic Instrumentation] DEBUG-3322 dynamic configuration (in-product enablement) #6627

Are you sure you want to change the base?

[Dynamic Instrumentation] DEBUG-3322 dynamic configuration (in-product enablement) #6627

Conversation

dudikeleti commented Feb 5, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Feb 5, 2025 • edited Loading

Datadog Report

❌ Failed Tests (5424)

andrewlock commented Feb 5, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Feb 5, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6627

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6627

Raw results

Raw results

Raw results

Raw results

datadog-ddstaging bot commented Feb 5, 2025 •

edited

Loading

andrewlock commented Feb 5, 2025 •

edited

Loading

andrewlock commented Feb 5, 2025 •

edited

Loading