[serverless] Add lambda span to trace context #6658

nhulston · 2025-02-11T22:22:06Z

Summary of changes

Add the span to trace context when creating the lambda span. Therefore, the _rootSpan in trace context is not null, so GetOrMakeSamplingDecision() works instead of always returning 1.

Also, updates the operation+service names to dd-tracer-serverless-span, which allows us to send the aws.lambda span to the lambda extension, so we can send info like error tracking, custom tags, etc (in the future).
https://github.com/DataDog/datadog-lambda-extension/blob/851fd84d0298f2a9300a905f5f6ac9b73bbe8ee4/bottlecap/src/traces/trace_processor.rs#L103-L105

Reason for change

Fix sampling rules in lambda

And https://docs.google.com/document/d/1dVk9c9SJcNYhnNIcnxj4sVQtWLaeBm0hTt5YOJkhYrw/edit?tab=t.0#heading=h.pt8wcgub5epa

Implementation details

Test coverage

Manual testing showed that sampling rules now work in Lambda

Other details

duncanista · 2025-02-11T22:24:49Z

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaCommon.cs

@@ -32,7 +32,7 @@ internal static Scope CreatePlaceholderScope(Tracer tracer, NameValueHeadersColl
            tags: null,
            parent: context.SpanContext,
            serviceName: PlaceholderServiceName,


Suggested change

serviceName: PlaceholderServiceName,

serviceName: PlaceholderServiceName,

The PlaceholderServiceName must be updated to what the agent expects to reject

andrewlock · 2025-02-11T23:10:22Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6658) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6658) - mean (1,002ms)  : 972, 1032
     .   : milestone, 1002,
    master - mean (1,004ms)  : 974, 1034
     .   : milestone, 1004,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6658) - mean (102ms)  : 99, 104
     .   : milestone, 102,
    master - mean (103ms)  : 101, 106
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6658) - mean (675ms)  : 658, 692
     .   : milestone, 675,
    master - mean (679ms)  : 659, 699
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6658) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (90ms)  : 88, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6658) - mean (635ms)  : 618, 651
     .   : milestone, 635,
    master - mean (633ms)  : 618, 649
     .   : milestone, 633,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6658) - mean (192ms)  : 187, 197
     .   : milestone, 192,
    master - mean (192ms)  : 187, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6658) - mean (1,109ms)  : 1077, 1141
     .   : milestone, 1109,
    master - mean (1,116ms)  : 1074, 1158
     .   : milestone, 1116,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6658) - mean (271ms)  : 267, 275
     .   : milestone, 271,
    master - mean (271ms)  : 266, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6658) - mean (869ms)  : 831, 907
     .   : milestone, 869,
    master - mean (866ms)  : 825, 906
     .   : milestone, 866,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6658) - mean (264ms)  : 259, 268
     .   : milestone, 264,
    master - mean (263ms)  : 258, 268
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6658) - mean (851ms)  : 813, 889
     .   : milestone, 851,
    master - mean (848ms)  : 818, 878
     .   : milestone, 848,

andrewlock · 2025-02-11T23:48:42Z

Benchmarks Report for tracer 🐌

Benchmarks for #6658 compared to master:

3 benchmarks are faster, with geometric mean 1.134
1 benchmarks are slower, with geometric mean 1.117
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.98μs	45.4ns	311ns	0.0155	0.00774	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	52.6ns	258ns	0.0195	0.00973	0	5.8 KB
master	`StartStopWithChild`	net472	16μs	53.4ns	207ns	1.03	0.294	0.0952	6.21 KB
#6658	`StartStopWithChild`	net6.0	8.13μs	45.2ns	275ns	0.0155	0.00776	0	5.61 KB
#6658	`StartStopWithChild`	netcoreapp3.1	9.99μs	52.2ns	276ns	0.0205	0.00512	0	5.8 KB
#6658	`StartStopWithChild`	net472	16μs	56.9ns	221ns	1.04	0.309	0.103	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	493μs	578ns	2.24μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	263ns	984ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	840μs	545ns	2.11μs	0.417	3.3 KB
#6658	`WriteAndFlushEnrichedTraces`	net6.0	493μs	395ns	1.48μs	0	2.7 KB
#6658	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	487ns	1.88μs	0	2.7 KB
#6658	`WriteAndFlushEnrichedTraces`	net472	850μs	262ns	979ns	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	130μs	447ns	1.73μs	0.131	14.47 KB
master	`SendRequest`	netcoreapp3.1	150μs	185ns	716ns	0.225	17.27 KB
master	`SendRequest`	net472	0.00081ns	0.000362ns	0.0014ns	0	0 b
#6658	`SendRequest`	net6.0	129μs	311ns	1.2μs	0.193	14.47 KB
#6658	`SendRequest`	netcoreapp3.1	147μs	390ns	1.51μs	0.22	17.28 KB
#6658	`SendRequest`	net472	0.00128ns	0.000463ns	0.00173ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	587μs	3.11μs	16.2μs	0.561	0	0	41.58 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	3.48μs	17.4μs	0.372	0	0	41.89 KB
master	`WriteAndFlushEnrichedTraces`	net472	837μs	3.84μs	14.9μs	8.22	2.47	0.411	53.31 KB
#6658	`WriteAndFlushEnrichedTraces`	net6.0	583μs	3.31μs	22.7μs	0.579	0	0	41.66 KB
#6658	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	701μs	3.83μs	22.3μs	0.349	0	0	41.71 KB
#6658	`WriteAndFlushEnrichedTraces`	net472	843μs	3.64μs	13.1μs	8.13	2.57	0.428	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6658

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.154	1,433.08	1,241.47

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.43μs	1.15ns	4.44ns	0.0146	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.67ns	6.45ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	1.54ns	5.95ns	0.157	0.00104	987 B
#6658	`ExecuteNonQuery`	net6.0	1.25μs	4.46ns	20.4ns	0.0143	0	1.02 KB
#6658	`ExecuteNonQuery`	netcoreapp3.1	1.82μs	1.58ns	6.12ns	0.0137	0	1.02 KB
#6658	`ExecuteNonQuery`	net472	1.98μs	2.91ns	10.9ns	0.156	0.000981	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	1.95ns	7.55ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.61μs	3.18ns	12.3ns	0.0127	976 B
master	`CallElasticsearch`	net472	2.53μs	2.74ns	10.6ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.39μs	0.608ns	2.36ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.75μs	0.527ns	1.97ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.62μs	1.67ns	6.47ns	0.167	1.05 KB
#6658	`CallElasticsearch`	net6.0	1.21μs	0.878ns	3.4ns	0.0135	976 B
#6658	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.514ns	1.99ns	0.0129	976 B
#6658	`CallElasticsearch`	net472	2.56μs	2.27ns	8.48ns	0.158	995 B
#6658	`CallElasticsearchAsync`	net6.0	1.26μs	0.626ns	2.43ns	0.0132	952 B
#6658	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	0.453ns	1.7ns	0.0139	1.02 KB
#6658	`CallElasticsearchAsync`	net472	2.57μs	1.75ns	6.77ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6658

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.117	1,206.61	1,347.71

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.21μs	0.645ns	2.5ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.947ns	3.67ns	0.013	952 B
master	`ExecuteAsync`	net472	1.84μs	0.772ns	2.78ns	0.145	915 B
#6658	`ExecuteAsync`	net6.0	1.35μs	0.559ns	2.09ns	0.0136	952 B
#6658	`ExecuteAsync`	netcoreapp3.1	1.57μs	0.774ns	3ns	0.0127	952 B
#6658	`ExecuteAsync`	net472	1.89μs	0.92ns	3.56ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.4μs	2.09ns	8.08ns	0.033	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.44μs	3.52ns	13.6ns	0.0379	2.85 KB
master	`SendAsync`	net472	7.57μs	18.5ns	71.6ns	0.495	3.12 KB
#6658	`SendAsync`	net6.0	4.37μs	1.99ns	7.44ns	0.0327	2.31 KB
#6658	`SendAsync`	netcoreapp3.1	5.47μs	11.5ns	44.5ns	0.037	2.85 KB
#6658	`SendAsync`	net472	7.45μs	1.51ns	5.83ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.53μs	1.95ns	7.55ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	0.92ns	3.56ns	0.0225	1.64 KB
master	`EnrichedLog`	net472	2.66μs	1.13ns	4.39ns	0.25	1.57 KB
#6658	`EnrichedLog`	net6.0	1.48μs	0.845ns	3.05ns	0.0234	1.64 KB
#6658	`EnrichedLog`	netcoreapp3.1	2.13μs	0.756ns	2.73ns	0.0213	1.64 KB
#6658	`EnrichedLog`	net472	2.48μs	0.883ns	3.18ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	309ns	1.2μs	0.0568	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	204ns	791ns	0.0578	0	4.28 KB
master	`EnrichedLog`	net472	150μs	137ns	529ns	0.67	0.223	4.46 KB
#6658	`EnrichedLog`	net6.0	114μs	102ns	395ns	0	0	4.28 KB
#6658	`EnrichedLog`	netcoreapp3.1	117μs	163ns	632ns	0.0585	0	4.28 KB
#6658	`EnrichedLog`	net472	149μs	164ns	636ns	0.669	0.223	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.03μs	2.27ns	8.79ns	0.0317	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.14μs	3.12ns	12.1ns	0.0291	2.2 KB
master	`EnrichedLog`	net472	4.84μs	1.26ns	4.89ns	0.32	2.02 KB
#6658	`EnrichedLog`	net6.0	2.96μs	2.13ns	8.24ns	0.0308	2.2 KB
#6658	`EnrichedLog`	netcoreapp3.1	4.18μs	1.47ns	5.68ns	0.0292	2.2 KB
#6658	`EnrichedLog`	net472	4.98μs	4.64ns	18ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.3μs	0.649ns	2.34ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.752ns	2.91ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.05μs	1.18ns	4.56ns	0.183	1.16 KB
#6658	`SendReceive`	net6.0	1.37μs	0.815ns	3.16ns	0.0158	1.14 KB
#6658	`SendReceive`	netcoreapp3.1	1.7μs	0.795ns	2.98ns	0.0155	1.14 KB
#6658	`SendReceive`	net472	2.07μs	3.86ns	14.9ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.67μs	0.988ns	3.83ns	0.0227	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	1.95ns	7.56ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.4μs	4.33ns	16.8ns	0.323	2.04 KB
#6658	`EnrichedLog`	net6.0	2.67μs	1.27ns	4.74ns	0.0215	1.6 KB
#6658	`EnrichedLog`	netcoreapp3.1	3.92μs	1.49ns	5.78ns	0.0215	1.65 KB
#6658	`EnrichedLog`	net472	4.35μs	1.76ns	6.35ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6658

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.129	641.54	568.17
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.118	866.81	775.12

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.572ns	2.22ns	0.00803	576 B
master	`StartFinishSpan`	netcoreapp3.1	642ns	1.53ns	5.92ns	0.00767	576 B
master	`StartFinishSpan`	net472	632ns	0.781ns	3.02ns	0.0918	578 B
master	`StartFinishScope`	net6.0	482ns	0.67ns	2.6ns	0.00988	696 B
master	`StartFinishScope`	netcoreapp3.1	769ns	0.957ns	3.71ns	0.00928	696 B
master	`StartFinishScope`	net472	867ns	1.12ns	4.34ns	0.104	658 B
#6658	`StartFinishSpan`	net6.0	414ns	0.524ns	2.03ns	0.00808	576 B
#6658	`StartFinishSpan`	netcoreapp3.1	568ns	0.967ns	3.75ns	0.00795	576 B
#6658	`StartFinishSpan`	net472	577ns	1.03ns	4.01ns	0.0917	578 B
#6658	`StartFinishScope`	net6.0	492ns	0.556ns	2.15ns	0.00969	696 B
#6658	`StartFinishScope`	netcoreapp3.1	735ns	1.16ns	4.5ns	0.00941	696 B
#6658	`StartFinishScope`	net472	775ns	0.199ns	0.719ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	640ns	0.8ns	3.1ns	0.00982	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	938ns	1.89ns	7.31ns	0.00943	696 B
master	`RunOnMethodBegin`	net472	1.15μs	2.2ns	8.51ns	0.104	658 B
#6658	`RunOnMethodBegin`	net6.0	607ns	0.441ns	1.71ns	0.00979	696 B
#6658	`RunOnMethodBegin`	netcoreapp3.1	955ns	0.987ns	3.82ns	0.00945	696 B
#6658	`RunOnMethodBegin`	net472	1.11μs	0.107ns	0.402ns	0.104	658 B

andrewlock · 2025-02-12T08:16:07Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6658) (11.012M)   : 0, 11011857
    master (11.169M)   : 0, 11169359
    benchmarks/2.9.0 (11.045M)   : 0, 11045405

    section Automatic
    This PR (6658) (7.305M)   : 0, 7305350
    master (7.196M)   : 0, 7195501
    benchmarks/2.9.0 (7.885M)   : 0, 7885346

    section Trace stats
    master (7.448M)   : 0, 7448482

    section Manual
    master (11.019M)   : 0, 11019438

    section Manual + Automatic
    This PR (6658) (6.744M)   : 0, 6743946
    master (6.613M)   : 0, 6612703

    section DD_TRACE_ENABLED=0
    master (10.079M)   : 0, 10079113

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6658) (9.805M)   : 0, 9804523
    master (7.929M)   : 0, 7928969
    benchmarks/2.9.0 (9.586M)   : 0, 9586476

    section Automatic
    This PR (6658) (6.558M)   : 0, 6558278
    master (6.525M)   : 0, 6524855

    section Trace stats
    master (6.732M)   : 0, 6732077

    section Manual
    master (9.719M)   : 0, 9718779

    section Manual + Automatic
    This PR (6658) (5.925M)   : 0, 5925184
    master (6.082M)   : 0, 6081964

    section DD_TRACE_ENABLED=0
    master (8.794M)   : 0, 8794411

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6658) (10.160M)   : 0, 10160402

    section Automatic
    This PR (6658) (6.591M)   : 0, 6590878

    section Manual + Automatic
    This PR (6658) (6.161M)   : 0, 6161066

…context

add lambda span to trace context

1cfa7c8

github-actions bot added area:serverless area:integrations labels Feb 11, 2025

nhulston marked this pull request as ready for review February 11, 2025 22:23

nhulston requested review from a team as code owners February 11, 2025 22:23

duncanista reviewed Feb 11, 2025

View reviewed changes

lucaspimentel self-requested a review February 11, 2025 22:31

update operation name and service name

eb0bf16

lucaspimentel approved these changes Feb 11, 2025

View reviewed changes

duncanista approved these changes Feb 11, 2025

View reviewed changes

nhulston marked this pull request as draft February 12, 2025 19:56

nhulston force-pushed the nicholas.hulston/add-lambda-span-to-trace-context branch 3 times, most recently from 168dad8 to eb0bf16 Compare February 13, 2025 16:57

Merge branch 'master' into nicholas.hulston/add-lambda-span-to-trace-…

f02c942

…context

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[serverless] Add lambda span to trace context #6658

[serverless] Add lambda span to trace context #6658

nhulston commented Feb 11, 2025 •

edited

Loading

duncanista Feb 11, 2025

andrewlock commented Feb 11, 2025 •

edited

Loading

andrewlock commented Feb 11, 2025 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6658

Raw results

Raw results

Slower ⚠️ in #6658

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6658

Raw results

Raw results

andrewlock commented Feb 12, 2025 •

edited

Loading

	serviceName: PlaceholderServiceName,
	serviceName: PlaceholderServiceName,

[serverless] Add lambda span to trace context #6658

Are you sure you want to change the base?

[serverless] Add lambda span to trace context #6658

Conversation

nhulston commented Feb 11, 2025 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

duncanista Feb 11, 2025

Choose a reason for hiding this comment

andrewlock commented Feb 11, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Feb 11, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6658

Raw results

Raw results

Slower ⚠️ in #6658

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6658

Raw results

Raw results

andrewlock commented Feb 12, 2025 • edited Loading

Throughput/Crank Report ⚡

nhulston commented Feb 11, 2025 •

edited

Loading

andrewlock commented Feb 11, 2025 •

edited

Loading

andrewlock commented Feb 11, 2025 •

edited

Loading

andrewlock commented Feb 12, 2025 •

edited

Loading