Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared] Datadog .NET APM Symbols Server #6689

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Shared] Datadog .NET APM Symbols Server #6689

wants to merge 1 commit into from
+527 −0

Conversation

gleocadie
Copy link
Collaborator

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@gleocadie gleocadie changed the title [Shared] Datadog Symbols Server [Shared] Datadog .NET APM Symbols Server Feb 20, 2025
@gleocadie gleocadie force-pushed the gleocadie/add-symbol-server-app branch from fa5b7ef to 86ecc9e Compare February 20, 2025 13:15
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6689) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6689) - mean (997ms)  : 974, 1020
     .   : milestone, 997,
    master - mean (995ms)  : 975, 1014
     .   : milestone, 995,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6689) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6689) - mean (670ms)  : 653, 687
     .   : milestone, 670,
    master - mean (675ms)  : 658, 693
     .   : milestone, 675,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6689) - mean (89ms)  : 86, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 90
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6689) - mean (632ms)  : 614, 650
     .   : milestone, 632,
    master - mean (631ms)  : 608, 653
     .   : milestone, 631,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6689) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (192ms)  : 187, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6689) - mean (1,107ms)  : 1077, 1137
     .   : milestone, 1107,
    master - mean (1,111ms)  : 1086, 1137
     .   : milestone, 1111,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6689) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (272ms)  : 268, 275
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (6689) - mean (870ms)  : 837, 904
     .   : milestone, 870,
    master - mean (865ms)  : 828, 903
     .   : milestone, 865,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6689) - mean (263ms)  : 258, 268
     .   : milestone, 263,
    master - mean (262ms)  : 257, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6689) - mean (846ms)  : 814, 877
     .   : milestone, 846,
    master - mean (847ms)  : 813, 881
     .   : milestone, 847,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6689 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.163
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.86μs 43ns 262ns 0.0203 0.00811 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 55.5ns 324ns 0.0199 0.00996 0 5.8 KB
master StartStopWithChild net472 15.9μs 38.1ns 142ns 1.04 0.307 0.0944 6.21 KB
#6689 StartStopWithChild net6.0 8.3μs 48.5ns 468ns 0.0158 0.00792 0 5.61 KB
#6689 StartStopWithChild netcoreapp3.1 10.4μs 60.3ns 559ns 0.0207 0.0103 0 5.8 KB
#6689 StartStopWithChild net472 16.1μs 55.4ns 215ns 1.04 0.321 0.0962 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 492μs 486ns 1.82μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 700μs 282ns 1.05μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 848μs 626ns 2.34μs 0.422 0 0 3.3 KB
#6689 WriteAndFlushEnrichedTraces net6.0 479μs 672ns 2.52μs 0 0 0 2.7 KB
#6689 WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 815ns 3.16μs 0 0 0 2.7 KB
#6689 WriteAndFlushEnrichedTraces net472 846μs 439ns 1.64μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 132μs 417ns 1.61μs 0.135 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 396ns 1.53μs 0.22 0 0 17.27 KB
master SendRequest net472 0.00199ns 0.000288ns 0.00112ns 0 0 0 0 b
#6689 SendRequest net6.0 132μs 364ns 1.41μs 0.198 0 0 14.47 KB
#6689 SendRequest netcoreapp3.1 140μs 526ns 2.04μs 0.212 0 0 17.27 KB
#6689 SendRequest net472 3.87E‑05ns 3.87E‑05ns 0.00015ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6689

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.87 KB 41.46 KB -412 B -0.98%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 608μs 3.32μs 18.8μs 0.604 0 0 41.87 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 3.78μs 27.5μs 0.338 0 0 41.69 KB
master WriteAndFlushEnrichedTraces net472 840μs 2.83μs 10.6μs 8.22 2.47 0.411 53.34 KB
#6689 WriteAndFlushEnrichedTraces net6.0 552μs 2.79μs 12.5μs 0.561 0 0 41.46 KB
#6689 WriteAndFlushEnrichedTraces netcoreapp3.1 671μs 3.71μs 23.2μs 0.319 0 0 41.88 KB
#6689 WriteAndFlushEnrichedTraces net472 828μs 3.99μs 15.5μs 8.22 2.47 0.411 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6689

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.159 1,442.46 1,245.09

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.44μs 2.09ns 8.1ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.75μs 2.38ns 9.22ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.07μs 4.15ns 16.1ns 0.156 0.00103 0 987 B
#6689 ExecuteNonQuery net6.0 1.25μs 1.26ns 4.72ns 0.0145 0 0 1.02 KB
#6689 ExecuteNonQuery netcoreapp3.1 1.83μs 1.82ns 7.06ns 0.0137 0 0 1.02 KB
#6689 ExecuteNonQuery net472 2.13μs 1.63ns 6.12ns 0.156 0.00106 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.404ns 1.51ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.958ns 3.59ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.46μs 2.36ns 9.14ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.37μs 1.01ns 3.76ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.965ns 3.61ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.67μs 1.97ns 7.63ns 0.166 0 0 1.05 KB
#6689 CallElasticsearch net6.0 1.2μs 0.667ns 2.58ns 0.0138 0 0 976 B
#6689 CallElasticsearch netcoreapp3.1 1.53μs 1.34ns 5.19ns 0.0131 0 0 976 B
#6689 CallElasticsearch net472 2.48μs 1.85ns 7.15ns 0.157 0 0 995 B
#6689 CallElasticsearchAsync net6.0 1.29μs 0.794ns 2.97ns 0.0129 0 0 952 B
#6689 CallElasticsearchAsync netcoreapp3.1 1.68μs 1.1ns 3.96ns 0.0135 0 0 1.02 KB
#6689 CallElasticsearchAsync net472 2.55μs 1.76ns 6.8ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6689

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.138 1,444.80 1,269.23

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.44μs 1.02ns 3.96ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.71μs 0.954ns 3.7ns 0.012 0 0 952 B
master ExecuteAsync net472 1.86μs 0.559ns 2.09ns 0.145 0 0 915 B
#6689 ExecuteAsync net6.0 1.27μs 1.74ns 6.52ns 0.0136 0 0 952 B
#6689 ExecuteAsync netcoreapp3.1 1.6μs 0.798ns 2.99ns 0.013 0 0 952 B
#6689 ExecuteAsync net472 1.88μs 0.856ns 3.2ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.41μs 1.19ns 4.47ns 0.0331 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.35μs 3.47ns 13ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.37μs 2.03ns 7.85ns 0.495 0 0 3.12 KB
#6689 SendAsync net6.0 4.44μs 2.69ns 9.7ns 0.0311 0 0 2.31 KB
#6689 SendAsync netcoreapp3.1 5.5μs 3.78ns 14.6ns 0.0386 0 0 2.85 KB
#6689 SendAsync net472 7.49μs 2.17ns 8.42ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 0.493ns 1.78ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.19μs 1.07ns 3.99ns 0.0228 0 0 1.64 KB
master EnrichedLog net472 2.67μs 4.35ns 16.9ns 0.25 0 0 1.57 KB
#6689 EnrichedLog net6.0 1.5μs 1.01ns 3.79ns 0.023 0 0 1.64 KB
#6689 EnrichedLog netcoreapp3.1 2.18μs 0.986ns 3.82ns 0.022 0 0 1.64 KB
#6689 EnrichedLog net472 2.51μs 0.836ns 3.24ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 212ns 822ns 0.0558 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 148ns 573ns 0.0582 0 0 4.28 KB
master EnrichedLog net472 151μs 82.1ns 307ns 0.681 0.227 0 4.46 KB
#6689 EnrichedLog net6.0 112μs 136ns 528ns 0.0558 0 0 4.28 KB
#6689 EnrichedLog netcoreapp3.1 116μs 205ns 768ns 0.0582 0 0 4.28 KB
#6689 EnrichedLog net472 149μs 221ns 855ns 0.674 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.11μs 0.496ns 1.72ns 0.0311 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.2μs 2.35ns 8.79ns 0.0294 0 0 2.2 KB
master EnrichedLog net472 5.03μs 1.01ns 3.79ns 0.32 0 0 2.02 KB
#6689 EnrichedLog net6.0 2.99μs 0.882ns 3.42ns 0.03 0 0 2.2 KB
#6689 EnrichedLog netcoreapp3.1 4.21μs 1.26ns 4.7ns 0.0295 0 0 2.2 KB
#6689 EnrichedLog net472 4.88μs 1.25ns 4.86ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.27μs 0.38ns 1.47ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 0.486ns 1.68ns 0.015 0 0 1.14 KB
master SendReceive net472 2.12μs 2.85ns 11.1ns 0.183 0 0 1.16 KB
#6689 SendReceive net6.0 1.39μs 0.492ns 1.91ns 0.0159 0 0 1.14 KB
#6689 SendReceive netcoreapp3.1 1.84μs 1.21ns 4.68ns 0.0156 0 0 1.14 KB
#6689 SendReceive net472 2.15μs 1.02ns 3.96ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 1.19ns 4.44ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 5.6ns 20.9ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.3μs 3.26ns 12.6ns 0.323 0 0 2.04 KB
#6689 EnrichedLog net6.0 2.74μs 0.705ns 2.54ns 0.0219 0 0 1.6 KB
#6689 EnrichedLog netcoreapp3.1 3.78μs 1.9ns 7.37ns 0.0207 0 0 1.65 KB
#6689 EnrichedLog net472 4.37μs 5.74ns 22.2ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 391ns 0.461ns 1.79ns 0.00817 0 0 576 B
master StartFinishSpan netcoreapp3.1 557ns 0.82ns 3.18ns 0.00784 0 0 576 B
master StartFinishSpan net472 584ns 1.27ns 4.91ns 0.0915 0 0 578 B
master StartFinishScope net6.0 515ns 0.487ns 1.89ns 0.00983 0 0 696 B
master StartFinishScope netcoreapp3.1 742ns 1.68ns 6.07ns 0.00932 0 0 696 B
master StartFinishScope net472 839ns 2.27ns 8.78ns 0.105 0 0 658 B
#6689 StartFinishSpan net6.0 436ns 1.01ns 3.93ns 0.0081 0 0 576 B
#6689 StartFinishSpan netcoreapp3.1 548ns 1.29ns 4.64ns 0.00797 0 0 576 B
#6689 StartFinishSpan net472 630ns 1.95ns 7.54ns 0.0916 0 0 578 B
#6689 StartFinishScope net6.0 491ns 0.762ns 2.95ns 0.00966 0 0 696 B
#6689 StartFinishScope netcoreapp3.1 714ns 3.91ns 21.8ns 0.00941 0 0 696 B
#6689 StartFinishScope net472 760ns 1.87ns 7.24ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6689

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.194 731.18 612.59

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 733ns 1.3ns 5.05ns 0.00951 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 907ns 1.48ns 5.73ns 0.00936 0 0 696 B
master RunOnMethodBegin net472 1.16μs 1.52ns 5.88ns 0.105 0 0 658 B
#6689 RunOnMethodBegin net6.0 611ns 1.27ns 4.9ns 0.00982 0 0 696 B
#6689 RunOnMethodBegin netcoreapp3.1 936ns 2.35ns 9.11ns 0.00941 0 0 696 B
#6689 RunOnMethodBegin net472 1.12μs 2.66ns 10.3ns 0.104 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gleocadie @andrewlock