Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail uninstall if the GAC lib has additional references #6698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't fail uninstall if the GAC lib has additional references #6698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tracer/src/Datadog.FleetInstaller/GacInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ private static unsafe bool TryGacUninstall(ILogger log, IEnumerable<(string Asse
{
log.WriteInfo($"Assembly '{gacAssemblyPath}' was already uninstalled from the GAC.");
}
else if (disposition is Fusion.UninstallDisposition.IASSEMBLYCACHE_UNINSTALL_DISPOSITION_HAS_INSTALL_REFERENCES)
{
log.WriteInfo($"Assembly '{gacAssemblyPath}' has additional install references. It was not removed from the GAC, but will be removed when all references are removed.");
}
else if (retValue == HResult.Code.S_OK)
{
log.WriteInfo($"Successfully uninstalled assembly '{gacAssemblyPath}' from the GAC.");
Expand Down
Loading