Add process tags to client-side stats #7791
Open
+39
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Update benchmark call to new Api constructor
The Api constructor now requires a propagateProcessTags boolean, and all production call sites were updated accordingly. The benchmark still calls the old four-argument overload (new Api(..., partialFlushEnabled: false)), so the Benchmarks.Trace project no longer compiles. Building or running benchmarks will fail with a missing parameter error until this call passes the new argument (and any trailing optional parameters).
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7791) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (74ms) : 70, 79
master - mean (76ms) : 71, 80
section Bailout
This PR (7791) - mean (80ms) : 72, 88
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (7791) - mean (1,108ms) : 1027, 1189
master - mean (1,123ms) : 1040, 1206
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (117ms) : 108, 126
master - mean (117ms) : 110, 125
section Bailout
This PR (7791) - mean (119ms) : 111, 128
master - mean (119ms) : 110, 129
section CallTarget+Inlining+NGEN
This PR (7791) - mean (803ms) : 761, 844
master - mean (815ms) : 772, 857
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (102ms) : 95, 110
master - mean (105ms) : 99, 110
section Bailout
This PR (7791) - mean (103ms) : 97, 110
master - mean (106ms) : 99, 113
section CallTarget+Inlining+NGEN
This PR (7791) - mean (742ms) : 708, 777
master - mean (759ms) : 720, 799
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (101ms) : 95, 107
master - mean (107ms) : 97, 116
section Bailout
This PR (7791) - mean (102ms) : 96, 109
master - mean (104ms) : 97, 111
section CallTarget+Inlining+NGEN
This PR (7791) - mean (698ms) : 668, 729
master - mean (724ms) : 697, 751
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (195ms) : 191, 200
master - mean (192ms) : 189, 196
section Bailout
This PR (7791) - mean (200ms) : 195, 204
master - mean (196ms) : 193, 200
section CallTarget+Inlining+NGEN
This PR (7791) - mean (1,183ms) : 1094, 1272
master - mean (1,156ms) : 1110, 1202
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (277ms) : 270, 284
master - mean (276ms) : 271, 282
section Bailout
This PR (7791) - mean (281ms) : 269, 293
master - mean (276ms) : 272, 280
section CallTarget+Inlining+NGEN
This PR (7791) - mean (947ms) : 894, 1000
master - mean (938ms) : 893, 983
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (271ms) : 262, 279
master - mean (268ms) : 262, 274
section Bailout
This PR (7791) - mean (269ms) : 265, 273
master - mean (289ms) : 282, 296
section CallTarget+Inlining+NGEN
This PR (7791) - mean (930ms) : 873, 987
master - mean (948ms) : 882, 1015
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7791) - mean (271ms) : 265, 278
master - mean (272ms) : 261, 282
section Bailout
This PR (7791) - mean (270ms) : 265, 276
master - mean (272ms) : 264, 280
section CallTarget+Inlining+NGEN
This PR (7791) - mean (856ms) : 834, 879
master - mean (865ms) : 827, 904
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
adding process tags at the ClientStatsPayload level.
See proto in the agent
Reason for change
AIDM-195
Implementation details
Test coverage
piggybacked on existing tests
Other details
I realized that dotnet doesn't write the service name at the top level, but only in the buckets. Doesn't seem to be a big issue, but there could be a win here by writing the service in the buckets only when there is an override.