Skip to content

Kr igor/apms 1755 v3 #7793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Kr igor/apms 1755 v3 #7793

wants to merge 9 commits into from

Conversation

@kr-igor
Copy link
Contributor

@kr-igor kr-igor commented Nov 6, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:data-streams-monitoring labels Nov 6, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 6, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7793) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.64 ± (75.38 - 75.99) ms74.61 ± (74.49 - 75.18) ms-1.4%✅
.NET Framework 4.8 - Bailout
duration78.77 ± (78.77 - 79.36) ms80.50 ± (80.54 - 81.31) ms+2.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1114.22 ± (1117.39 - 1128.56) ms1106.96 ± (1110.53 - 1122.28) ms-0.7%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.95 ± (22.88 - 23.03) ms23.15 ± (23.07 - 23.23) ms+0.9%✅⬆️
process.time_to_main_ms86.94 ± (86.52 - 87.37) ms88.25 ± (87.85 - 88.64) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.93) MB10.86 ± (10.86 - 10.87) MB-0.5%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.94 ± (22.87 - 23.01) ms22.82 ± (22.74 - 22.89) ms-0.5%✅
process.time_to_main_ms88.80 ± (88.36 - 89.25) ms88.30 ± (87.88 - 88.73) ms-0.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.90 ± (10.90 - 10.91) MB-0.4%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms221.20 ± (219.64 - 222.75) ms221.15 ± (219.86 - 222.44) ms-0.0%✅
process.time_to_main_ms551.39 ± (549.98 - 552.81) ms546.52 ± (545.37 - 547.67) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.64 ± (52.61 - 52.66) MB52.43 ± (52.41 - 52.45) MB-0.4%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.73 ± (21.66 - 21.79) ms21.76 ± (21.68 - 21.84) ms+0.2%✅⬆️
process.time_to_main_ms75.68 ± (75.36 - 75.99) ms75.17 ± (74.76 - 75.58) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.61) MB10.58 ± (10.58 - 10.59) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.75 ± (21.67 - 21.83) ms21.93 ± (21.86 - 22.00) ms+0.8%✅⬆️
process.time_to_main_ms77.29 ± (76.91 - 77.66) ms77.62 ± (77.24 - 78.00) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.66 ± (10.66 - 10.66) MB10.63 ± (10.62 - 10.63) MB-0.3%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms206.65 ± (205.37 - 207.92) ms207.86 ± (206.56 - 209.17) ms+0.6%✅⬆️
process.time_to_main_ms514.40 ± (513.32 - 515.49) ms506.80 ± (505.72 - 507.88) ms-1.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.87 ± (51.84 - 51.89) MB51.57 ± (51.53 - 51.60) MB-0.6%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms20.13 ± (20.04 - 20.22) ms19.73 ± (19.66 - 19.79) ms-2.0%✅
process.time_to_main_ms77.56 ± (77.04 - 78.09) ms73.93 ± (73.60 - 74.25) ms-4.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.64 ± (7.64 - 7.65) MB7.62 ± (7.61 - 7.62) MB-0.3%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.79 ± (19.73 - 19.86) ms19.81 ± (19.73 - 19.89) ms+0.1%✅⬆️
process.time_to_main_ms75.93 ± (75.62 - 76.25) ms76.22 ± (75.77 - 76.67) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.72) MB7.68 ± (7.67 - 7.69) MB-0.4%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms189.72 ± (188.80 - 190.63) ms188.62 ± (187.65 - 189.58) ms-0.6%✅
process.time_to_main_ms492.66 ± (491.56 - 493.77) ms480.26 ± (479.35 - 481.16) ms-2.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed39.01 ± (38.97 - 39.04) MB38.74 ± (38.70 - 38.78) MB-0.7%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.06 ± (192.08 - 192.76) ms192.38 ± (192.34 - 193.17) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration196.17 ± (196.13 - 196.85) ms196.25 ± (196.03 - 196.58) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1150.43 ± (1152.67 - 1159.10) ms1174.74 ± (1176.17 - 1187.05) ms+2.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.57 ± (187.13 - 188.02) ms189.33 ± (188.88 - 189.79) ms+0.9%✅⬆️
process.time_to_main_ms80.42 ± (80.19 - 80.65) ms81.50 ± (81.27 - 81.73) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.09 ± (16.06 - 16.11) MB16.02 ± (16.00 - 16.04) MB-0.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms186.34 ± (186.09 - 186.60) ms186.56 ± (186.22 - 186.90) ms+0.1%✅⬆️
process.time_to_main_ms81.40 ± (81.27 - 81.53) ms81.93 ± (81.78 - 82.08) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.06 - 16.17) MB16.07 ± (16.05 - 16.10) MB-0.3%✅
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms391.82 ± (389.14 - 394.51) ms397.30 ± (394.54 - 400.06) ms+1.4%✅⬆️
process.time_to_main_ms515.23 ± (514.60 - 515.86) ms515.53 ± (514.94 - 516.12) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed62.87 ± (62.71 - 63.03) MB62.75 ± (62.59 - 62.90) MB-0.2%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms190.34 ± (189.97 - 190.72) ms191.56 ± (191.17 - 191.96) ms+0.6%✅⬆️
process.time_to_main_ms69.28 ± (69.08 - 69.47) ms69.70 ± (69.52 - 69.89) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.94 ± (15.78 - 16.09) MB16.34 ± (16.29 - 16.40) MB+2.6%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)19 ± (19 - 19)+3.9%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms204.21 ± (203.77 - 204.64) ms190.79 ± (190.53 - 191.06) ms-6.6%✅
process.time_to_main_ms75.97 ± (75.71 - 76.23) ms70.57 ± (70.45 - 70.69) ms-7.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.25 ± (16.22 - 16.27) MB16.26 ± (16.13 - 16.38) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-2.5%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms419.32 ± (416.21 - 422.43) ms408.79 ± (405.87 - 411.70) ms-2.5%✅
process.time_to_main_ms496.23 ± (495.06 - 497.40) ms480.30 ± (479.74 - 480.87) ms-3.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.56 ± (62.43 - 62.69) MB62.06 ± (61.91 - 62.21) MB-0.8%✅
runtime.dotnet.threads.count29 ± (29 - 29)30 ± (29 - 30)+0.3%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms192.36 ± (191.87 - 192.86) ms190.07 ± (189.58 - 190.56) ms-1.2%✅
process.time_to_main_ms69.82 ± (69.61 - 70.02) ms69.35 ± (69.18 - 69.52) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.64 ± (11.62 - 11.65) MB11.72 ± (11.70 - 11.75) MB+0.7%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.6%✅
.NET 8 - Bailout
process.internal_duration_ms191.25 ± (190.76 - 191.75) ms190.00 ± (189.57 - 190.43) ms-0.7%✅
process.time_to_main_ms70.67 ± (70.52 - 70.83) ms70.57 ± (70.41 - 70.73) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.78 ± (11.75 - 11.81) MB11.81 ± (11.78 - 11.83) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms364.26 ± (362.74 - 365.77) ms358.61 ± (357.09 - 360.14) ms-1.5%✅
process.time_to_main_ms470.00 ± (468.94 - 471.06) ms457.72 ± (456.81 - 458.63) ms-2.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.64 ± (50.60 - 50.67) MB50.28 ± (50.25 - 50.32) MB-0.7%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.4%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (75ms)  : 70, 80
    master - mean (76ms)  : 71, 80

    section Bailout
    This PR (7793) - mean (81ms)  : 75, 86
    master - mean (79ms)  : 75, 83

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (1,116ms)  : 1026, 1206
    master - mean (1,123ms)  : 1040, 1206
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (119ms)  : 111, 127
    master - mean (117ms)  : 110, 125

    section Bailout
    This PR (7793) - mean (119ms)  : 110, 127
    master - mean (119ms)  : 110, 129

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (807ms)  : 771, 843
    master - mean (815ms)  : 772, 857
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (104ms)  : 97, 111
    master - mean (105ms)  : 99, 110

    section Bailout
    This PR (7793) - mean (106ms)  : 99, 113
    master - mean (106ms)  : 99, 113

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (746ms)  : 713, 779
    master - mean (759ms)  : 720, 799
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (102ms)  : 94, 110
    master - mean (107ms)  : 97, 116

    section Bailout
    This PR (7793) - mean (104ms)  : 94, 114
    master - mean (104ms)  : 97, 111

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (701ms)  : 669, 734
    master - mean (724ms)  : 697, 751
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (193ms)  : 189, 197
    master - mean (192ms)  : 189, 196

    section Bailout
    This PR (7793) - mean (196ms)  : 194, 199
    master - mean (196ms)  : 193, 200

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (1,182ms)  : 1097, 1266
    master - mean (1,156ms)  : 1110, 1202
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (280ms)  : 268, 291
    master - mean (276ms)  : 271, 282

    section Bailout
    This PR (7793) - mean (276ms)  : 273, 280
    master - mean (276ms)  : 272, 280

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (947ms)  : 905, 989
    master - mean (938ms)  : 893, 983
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (270ms)  : 262, 278
    master - mean (268ms)  : 262, 274

    section Bailout
    This PR (7793) - mean (269ms)  : 266, 273
    master - mean (289ms)  : 282, 296

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (921ms)  : 877, 965
    master - mean (948ms)  : 882, 1015
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7793) - mean (269ms)  : 263, 275
    master - mean (272ms)  : 261, 282

    section Bailout
    This PR (7793) - mean (270ms)  : 263, 277
    master - mean (272ms)  : 264, 280

    section CallTarget+Inlining+NGEN
    This PR (7793) - mean (848ms)  : 823, 873
    master - mean (865ms)  : 827, 904
Loading

@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7793 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.257
  • 6 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7793

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 5.99 KB 6.03 KB 35 B 0.58%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.4μs 58.6ns 389ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 14.2μs 72.1ns 330ns 0 0 0 5.67 KB
master StartStopWithChild net472 22.4μs 88.4ns 342ns 1.05 0.418 0.105 5.99 KB
#7793 StartStopWithChild net6.0 10.5μs 57.8ns 361ns 0 0 0 5.52 KB
#7793 StartStopWithChild netcoreapp3.1 13.7μs 73.1ns 373ns 0 0 0 5.68 KB
#7793 StartStopWithChild net472 21.6μs 108ns 469ns 0.975 0.325 0.108 6.03 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 64.7ns 242ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.06ms 846ns 3.28μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 71.4ns 267ns 0 0 0 3.35 KB
#7793 WriteAndFlushEnrichedTraces net6.0 967μs 3.18μs 12.3μs 0 0 0 2.71 KB
#7793 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 67.1ns 232ns 0 0 0 2.7 KB
#7793 WriteAndFlushEnrichedTraces net472 1.2ms 279ns 1.08μs 0 0 0 3.35 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.07μs 1.45ns 5.62ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.46μs 7.77ns 38.9ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.03μs 0.654ns 2.53ns 0.195 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 6.99μs 35.2ns 153ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 9.01μs 24.8ns 96.2ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.6μs 4.46ns 17.3ns 0.726 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 325ns 1.22ns 4.71ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 414ns 2.12ns 9.94ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 295ns 0.0121ns 0.0419ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.43μs 1.62ns 6.26ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.81μs 36.9ns 143ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.73μs 4.21ns 16.3ns 0.574 0 0 3.8 KB
#7793 AllCycleSimpleBody net6.0 1.08μs 5.57ns 24.9ns 0 0 0 1.22 KB
#7793 AllCycleSimpleBody netcoreapp3.1 1.37μs 7.59ns 49.8ns 0 0 0 1.2 KB
#7793 AllCycleSimpleBody net472 1.03μs 0.642ns 2.31ns 0.192 0 0 1.23 KB
#7793 AllCycleMoreComplexBody net6.0 7.46μs 37.3ns 167ns 0 0 0 4.72 KB
#7793 AllCycleMoreComplexBody netcoreapp3.1 8.87μs 35.6ns 138ns 0 0 0 4.62 KB
#7793 AllCycleMoreComplexBody net472 7.54μs 1.7ns 6.36ns 0.718 0 0 4.74 KB
#7793 ObjectExtractorSimpleBody net6.0 324ns 0.136ns 0.49ns 0 0 0 280 B
#7793 ObjectExtractorSimpleBody netcoreapp3.1 393ns 2.2ns 13.2ns 0 0 0 272 B
#7793 ObjectExtractorSimpleBody net472 300ns 0.013ns 0.0467ns 0.0445 0 0 281 B
#7793 ObjectExtractorMoreComplexBody net6.0 6.37μs 1.97ns 7.61ns 0 0 0 3.78 KB
#7793 ObjectExtractorMoreComplexBody netcoreapp3.1 7.91μs 4.22ns 16.3ns 0 0 0 3.69 KB
#7793 ObjectExtractorMoreComplexBody net472 6.61μs 2.84ns 11ns 0.597 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.7μs 260ns 971ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98.4μs 168ns 649ns 0 0 0 32.4 KB
master EncodeArgs net472 112μs 20.3ns 78.5ns 5.04 0 0 32.51 KB
master EncodeLegacyArgs net6.0 146μs 216ns 837ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 201μs 577ns 2.23μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 20.2ns 75.7ns 0 0 0 2.17 KB
#7793 EncodeArgs net6.0 80.3μs 38.4ns 149ns 0 0 0 32.4 KB
#7793 EncodeArgs netcoreapp3.1 98.1μs 132ns 511ns 0 0 0 32.4 KB
#7793 EncodeArgs net472 111μs 25.4ns 98.4ns 4.97 0 0 32.51 KB
#7793 EncodeLegacyArgs net6.0 145μs 83.2ns 322ns 0 0 0 2.14 KB
#7793 EncodeLegacyArgs netcoreapp3.1 198μs 308ns 1.19μs 0 0 0 2.14 KB
#7793 EncodeLegacyArgs net472 264μs 92.6ns 359ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 400μs 102ns 368ns 0 0 0 4.56 KB
master RunWafRealisticBenchmark netcoreapp3.1 828μs 13.1μs 131μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 30.2ns 113ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 287μs 85.1ns 318ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 309μs 221ns 827ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 309μs 29.2ns 109ns 0 0 0 2.29 KB
#7793 RunWafRealisticBenchmark net6.0 395μs 64.8ns 234ns 0 0 0 4.55 KB
#7793 RunWafRealisticBenchmark netcoreapp3.1 815μs 10μs 100μs 0 0 0 4.48 KB
#7793 RunWafRealisticBenchmark net472 437μs 60.9ns 236ns 0 0 0 4.66 KB
#7793 RunWafRealisticBenchmarkWithAttack net6.0 288μs 22.7ns 78.6ns 0 0 0 2.24 KB
#7793 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 301μs 339ns 1.31μs 0 0 0 2.22 KB
#7793 RunWafRealisticBenchmarkWithAttack net472 310μs 25.1ns 97.4ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 60.4ns 218ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 72.8μs 98.1ns 367ns 0 0 0 17.42 KB
master SendRequest net472 0.00895ns 0.0023ns 0.00862ns 0 0 0 0 b
#7793 SendRequest net6.0 61μs 82.1ns 284ns 0 0 0 14.52 KB
#7793 SendRequest netcoreapp3.1 72.7μs 133ns 479ns 0 0 0 17.42 KB
#7793 SendRequest net472 0.000253ns 0.000157ns 0.000608ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7793

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 1.524 826,041.59 1,258,916.19

More allocations ⚠️ in #7793

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 6 B 2 B 50.00%

Fewer allocations 🎉 in #7793

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 4 B 2 B -2 B -50.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1 B 0 b -1 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.95ms 5.87μs 22.7μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.08ms 6.07μs 23.5μs 0 0 0 640 KB
master OriginalCharSlice net472 2.59ms 529ns 1.91μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.46ms 320ns 1.24μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.75ms 544ns 2.11μs 0 0 0 1 B
master OptimizedCharSlice net472 1.9ms 262ns 1.02μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 826μs 26.8ns 100ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 840μs 141ns 544ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.22ms 248ns 959ns 0 0 0 0 b
#7793 OriginalCharSlice net6.0 1.88ms 8μs 31μs 0 0 0 640.01 KB
#7793 OriginalCharSlice netcoreapp3.1 2.14ms 10.7μs 48.9μs 0 0 0 640 KB
#7793 OriginalCharSlice net472 2.6ms 378ns 1.42μs 100 0 0 641.95 KB
#7793 OptimizedCharSlice net6.0 1.49ms 231ns 894ns 0 0 0 2 B
#7793 OptimizedCharSlice netcoreapp3.1 1.65ms 437ns 1.69μs 0 0 0 1 B
#7793 OptimizedCharSlice net472 2.02ms 303ns 1.13μs 0 0 0 0 b
#7793 OptimizedCharSliceWithPool net6.0 1.26ms 72.7ns 272ns 0 0 0 6 B
#7793 OptimizedCharSliceWithPool netcoreapp3.1 799μs 91.2ns 341ns 0 0 0 0 b
#7793 OptimizedCharSliceWithPool net472 1.13ms 76ns 294ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7793

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.144 642,108.12 734,517.19

Fewer allocations 🎉 in #7793

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.17 KB 41.84 KB -329 B -0.78%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 642μs 488ns 1.89μs 0 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 692μs 2.32μs 8.38μs 0 0 0 42.17 KB
master WriteAndFlushEnrichedTraces net472 897μs 4.28μs 16.6μs 8.33 0 0 56.12 KB
#7793 WriteAndFlushEnrichedTraces net6.0 744μs 3.67μs 15.6μs 0 0 0 41.82 KB
#7793 WriteAndFlushEnrichedTraces netcoreapp3.1 725μs 4.06μs 26μs 0 0 0 41.84 KB
#7793 WriteAndFlushEnrichedTraces net472 884μs 2.29μs 8.88μs 8.33 0 0 56.12 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.9μs 1.28ns 4.78ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.68μs 11.8ns 45.6ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.9μs 6.14ns 21.3ns 0.144 0.0144 0 987 B
#7793 ExecuteNonQuery net6.0 1.86μs 9.25ns 38.1ns 0 0 0 1.02 KB
#7793 ExecuteNonQuery netcoreapp3.1 2.56μs 5.22ns 20.2ns 0 0 0 1.02 KB
#7793 ExecuteNonQuery net472 2.86μs 3.25ns 12.6ns 0.143 0.0143 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.74μs 0.596ns 2.31ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.2μs 11.4ns 54.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.52μs 1.9ns 7.36ns 0.158 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.92μs 4.09ns 15.3ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 8.99ns 33.6ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.7μs 1.85ns 6.93ns 0.166 0 0 1.1 KB
#7793 CallElasticsearch net6.0 1.74μs 8.3ns 33.2ns 0 0 0 1.03 KB
#7793 CallElasticsearch netcoreapp3.1 2.24μs 9.69ns 37.5ns 0 0 0 1.03 KB
#7793 CallElasticsearch net472 3.59μs 8.06ns 31.2ns 0.163 0 0 1.04 KB
#7793 CallElasticsearchAsync net6.0 1.92μs 0.915ns 3.54ns 0 0 0 1.01 KB
#7793 CallElasticsearchAsync netcoreapp3.1 2.39μs 8.97ns 33.6ns 0 0 0 1.08 KB
#7793 CallElasticsearchAsync net472 3.63μs 3.04ns 11.8ns 0.163 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.83μs 1.05ns 3.95ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.53μs 11.6ns 44.8ns 0 0 0 952 B
master ExecuteAsync net472 2.56μs 1.3ns 5.04ns 0.142 0 0 915 B
#7793 ExecuteAsync net6.0 1.94μs 9.65ns 42.1ns 0 0 0 952 B
#7793 ExecuteAsync netcoreapp3.1 2.49μs 1.55ns 6.01ns 0 0 0 952 B
#7793 ExecuteAsync net472 2.63μs 0.453ns 1.76ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.86μs 10.9ns 40.8ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.33μs 26.3ns 102ns 0 0 0 2.9 KB
master SendAsync net472 12.1μs 7.49ns 28ns 0.482 0 0 3.18 KB
#7793 SendAsync net6.0 6.81μs 15.5ns 58ns 0 0 0 2.36 KB
#7793 SendAsync netcoreapp3.1 8.41μs 20.7ns 80.2ns 0 0 0 2.9 KB
#7793 SendAsync net472 12.4μs 7.29ns 28.2ns 0.495 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7793

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 1.139 46,700.00 53,200.00

Fewer allocations 🎉 in #7793

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 44.04 KB 42.73 KB -1.31 KB -2.98%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 46.16 KB 43.25 KB -2.91 KB -6.31%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.06 KB 246.83 KB -27.22 KB -9.93%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.2μs 260ns 2.45μs 0 0 0 46.16 KB
master StringConcatBenchmark netcoreapp3.1 46.8μs 168ns 606ns 0 0 0 44.04 KB
master StringConcatBenchmark net472 56.8μs 227ns 849ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 470μs 1.36μs 4.71μs 0 0 0 278.21 KB
master StringConcatAspectBenchmark netcoreapp3.1 553μs 1.31μs 4.9μs 0 0 0 274.06 KB
master StringConcatAspectBenchmark net472 411μs 2.01μs 13.3μs 0 0 0 278.53 KB
#7793 StringConcatBenchmark net6.0 42.3μs 201ns 751ns 0 0 0 43.25 KB
#7793 StringConcatBenchmark netcoreapp3.1 53.7μs 310ns 2.36μs 0 0 0 42.73 KB
#7793 StringConcatBenchmark net472 57.7μs 98.4ns 355ns 0 0 0 57.34 KB
#7793 StringConcatAspectBenchmark net6.0 495μs 2.18μs 10.9μs 0 0 0 278.54 KB
#7793 StringConcatAspectBenchmark netcoreapp3.1 504μs 1.36μs 4.9μs 0 0 0 246.83 KB
#7793 StringConcatAspectBenchmark net472 409μs 2.32μs 15.7μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 10.7ns 41.6ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.6μs 17ns 70.3ns 0 0 0 1.7 KB
master EnrichedLog net472 4.04μs 4.82ns 18ns 0.24 0 0 1.64 KB
#7793 EnrichedLog net6.0 2.67μs 12.9ns 56.3ns 0 0 0 1.7 KB
#7793 EnrichedLog netcoreapp3.1 3.58μs 17ns 66ns 0 0 0 1.7 KB
#7793 EnrichedLog net472 3.86μs 7.57ns 29.3ns 0.25 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 137μs 243ns 875ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 130μs 678ns 3.96μs 0 0 0 4.31 KB
master EnrichedLog net472 174μs 980ns 6.65μs 0 0 0 4.51 KB
#7793 EnrichedLog net6.0 123μs 20.7ns 74.5ns 0 0 0 4.31 KB
#7793 EnrichedLog netcoreapp3.1 128μs 67.8ns 235ns 0 0 0 4.31 KB
#7793 EnrichedLog net472 167μs 72.8ns 282ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.96μs 25.1ns 109ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.68μs 30.2ns 117ns 0 0 0 2.26 KB
master EnrichedLog net472 7.55μs 9.55ns 37ns 0.3 0 0 2.08 KB
#7793 EnrichedLog net6.0 5.12μs 9.77ns 37.8ns 0 0 0 2.26 KB
#7793 EnrichedLog netcoreapp3.1 6.68μs 9.97ns 37.3ns 0 0 0 2.26 KB
#7793 EnrichedLog net472 7.56μs 8.08ns 31.3ns 0.302 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 3.2ns 12.4ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.69μs 12ns 43.1ns 0 0 0 1.2 KB
master SendReceive net472 3.04μs 2.74ns 10.6ns 0.183 0 0 1.2 KB
#7793 SendReceive net6.0 2.04μs 3ns 11.6ns 0 0 0 1.2 KB
#7793 SendReceive netcoreapp3.1 2.5μs 12.6ns 55ns 0 0 0 1.2 KB
#7793 SendReceive net472 3.12μs 4.3ns 16.6ns 0.188 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.31μs 16.4ns 61.5ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.77μs 9.03ns 35ns 0 0 0 1.63 KB
master EnrichedLog net472 6.52μs 7.68ns 29.7ns 0.293 0 0 2.03 KB
#7793 EnrichedLog net6.0 4.3μs 13.2ns 51.3ns 0 0 0 1.58 KB
#7793 EnrichedLog netcoreapp3.1 5.58μs 10.5ns 40.8ns 0 0 0 1.63 KB
#7793 EnrichedLog net472 6.8μs 6.66ns 25.8ns 0.306 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 769ns 4.12ns 21.8ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 943ns 4.54ns 17.6ns 0 0 0 576 B
master StartFinishSpan net472 919ns 0.765ns 2.96ns 0.0877 0 0 578 B
master StartFinishScope net6.0 938ns 0.458ns 1.71ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.2μs 5.39ns 20.9ns 0 0 0 696 B
master StartFinishScope net472 1.13μs 0.537ns 2.08ns 0.101 0 0 658 B
#7793 StartFinishSpan net6.0 796ns 3.8ns 15.7ns 0 0 0 576 B
#7793 StartFinishSpan netcoreapp3.1 995ns 2.73ns 10.6ns 0 0 0 576 B
#7793 StartFinishSpan net472 918ns 0.657ns 2.46ns 0.0875 0 0 578 B
#7793 StartFinishScope net6.0 918ns 2.64ns 10.2ns 0 0 0 696 B
#7793 StartFinishScope netcoreapp3.1 1.21μs 4.56ns 17.7ns 0 0 0 696 B
#7793 StartFinishScope net472 1.1μs 0.821ns 3.07ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.05μs 0.921ns 3.57ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.43μs 5.48ns 21.2ns 0 0 0 696 B
master RunOnMethodBegin net472 1.46μs 0.823ns 3.19ns 0.102 0 0 658 B
#7793 RunOnMethodBegin net6.0 1.08μs 5.89ns 34.9ns 0 0 0 696 B
#7793 RunOnMethodBegin netcoreapp3.1 1.39μs 6.87ns 29.1ns 0 0 0 696 B
#7793 RunOnMethodBegin net472 1.42μs 1.02ns 3.8ns 0.0995 0 0 658 B

@kr-igor kr-igor closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:data-streams-monitoring area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kr-igor