Gleocadie/add more tests for managed code cache#8308
Draft
Gleocadie/add more tests for managed code cache#8308
Conversation
BenchmarksBenchmark execution time: 2026-03-18 17:20:38 Comparing candidate commit d8e77ff in PR branch Found 5 performance improvements and 7 performance regressions! Performance is the same for 161 metrics, 19 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1
|
gleocadie
force-pushed
the
gleocadie/add_more_tests_for_managed_code_cache
branch
from
0978f63 to
f62e8a8
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8308) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (74ms) : 72, 77
master - mean (71ms) : 70, 73
section Bailout
This PR (8308) - mean (79ms) : 77, 81
master - mean (76ms) : 75, 77
section CallTarget+Inlining+NGEN
This PR (8308) - mean (1,096ms) : 1048, 1145
master - mean (1,061ms) : 1023, 1099
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (117ms) : 113, 121
master - mean (111ms) : 109, 114
section Bailout
This PR (8308) - mean (119ms) : 115, 122
master - mean (113ms) : 111, 114
section CallTarget+Inlining+NGEN
This PR (8308) - mean (759ms) : 733, 786
master - mean (744ms) : 724, 764
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (104ms) : 101, 107
master - mean (99ms) : 96, 102
section Bailout
This PR (8308) - mean (105ms) : crit, 103, 108
master - mean (99ms) : 97, 101
section CallTarget+Inlining+NGEN
This PR (8308) - mean (742ms) : 707, 778
master - mean (723ms) : 676, 769
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (102ms) : 98, 106
master - mean (98ms) : 95, 100
section Bailout
This PR (8308) - mean (104ms) : 101, 107
master - mean (99ms) : 98, 101
section CallTarget+Inlining+NGEN
This PR (8308) - mean (680ms) : 644, 716
master - mean (657ms) : 634, 681
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (202ms) : 191, 213
master - mean (194ms) : 189, 200
section Bailout
This PR (8308) - mean (200ms) : 194, 207
master - mean (197ms) : 193, 201
section CallTarget+Inlining+NGEN
This PR (8308) - mean (1,184ms) : 1126, 1242
master - mean (1,162ms) : 1090, 1233
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (283ms) : 274, 292
master - mean (277ms) : 273, 282
section Bailout
This PR (8308) - mean (284ms) : 274, 294
master - mean (279ms) : 273, 285
section CallTarget+Inlining+NGEN
This PR (8308) - mean (915ms) : 881, 949
master - mean (904ms) : 873, 936
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (274ms) : 267, 281
master - mean (271ms) : 265, 277
section Bailout
This PR (8308) - mean (276ms) : 266, 285
master - mean (271ms) : 268, 274
section CallTarget+Inlining+NGEN
This PR (8308) - mean (941ms) : 914, 968
master - mean (938ms) : 903, 973
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8308) - mean (272ms) : 267, 276
master - mean (271ms) : 264, 278
section Bailout
This PR (8308) - mean (271ms) : 265, 276
master - mean (271ms) : 265, 276
section CallTarget+Inlining+NGEN
This PR (8308) - mean (846ms) : 816, 876
master - mean (840ms) : 810, 870
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
gleocadie
force-pushed
the
gleocadie/add_more_tests_for_managed_code_cache
branch
from
374e609 to
d8e77ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details