Add srv_src field to client stats payload by NachoEchevarria · Pull Request #8339 · DataDog/dd-trace-dotnet

NachoEchevarria · 2026-03-19T12:24:07Z

Summary of changes

Add srv_src field to the client stats payload, propagating the service name source alongside trace stats.

Reason for change

Per the service name source RFC, the source must be propagated in both trace and stats payloads. The trace payload (_dd.svc_src span meta) was added in PR #8302. This completes the implementation by adding srv_src at the stats bucket level.

Implementation details

StatsAggregationKey.cs: Added ServiceSource field. It participates in equality and hash code, so stats with different sources aggregate into distinct buckets.
StatsAggregator.cs: BuildKey() now reads span.Context.ServiceNameSource and passes it to the aggregation key.
StatsBuffer.cs: SerializeBucket() conditionally serializes srv_src when ServiceSource is non-null (dynamic map size: 13 with source, 12 without).

Test coverage

KeyEquality_WithServiceSource: Verifies that keys with different sources are not equal.
Serialization_WithServiceSource: Verifies srv_src is serialized when present and absent when null.
Existing StatsBufferTests and StatsAggregatorTests updated and passing.

Other details

APMLP-1015

Related agent PR: DataDog/datadog-agent#45982
Reference Java implementation: DataDog/dd-trace-java#10653

pr-commenter · 2026-03-19T13:05:28Z

Benchmarks

Benchmark execution time: 2026-03-20 11:48:24

Comparing candidate commit d6e12c2 in PR branch nacho/ServiceSourceStats with baseline commit b0dc7b1 in branch master.

Found 3 performance improvements and 5 performance regressions! Performance is the same for 257 metrics, 23 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

🟥 execution_time [+110.793ms; +112.733ms] or [+127.782%; +130.019%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

🟩 execution_time [-24.773ms; -18.325ms] or [-11.287%; -8.349%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

🟩 throughput [+212004.710op/s; +264296.080op/s] or [+9.454%; +11.785%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

🟥 execution_time [+95.557µs; +107.483µs] or [+5.125%; +5.764%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

🟥 execution_time [+11.820ms; +15.905ms] or [+6.001%; +8.076%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

🟥 allocated_mem [+14.994KB; +15.027KB] or [+5.814%; +5.827%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

🟥 allocated_mem [+14.956KB; +14.984KB] or [+5.818%; +5.829%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

🟩 execution_time [-35.002ms; -31.740ms] or [-17.228%; -15.623%]

dd-trace-dotnet-ci-bot · 2026-03-19T13:22:51Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8339) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	69.31 ± (69.54 - 69.99) ms	68.86 ± (68.96 - 69.24) ms	-0.7%	✅
.NET Framework 4.8 - Bailout
duration	73.09 ± (73.02 - 73.28) ms	72.61 ± (72.59 - 72.89) ms	-0.7%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1044.03 ± (1046.70 - 1054.47) ms	1044.08 ± (1045.08 - 1051.44) ms	+0.0%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	21.90 ± (21.87 - 21.94) ms	21.85 ± (21.83 - 21.88) ms	-0.2%	✅
process.time_to_main_ms	79.85 ± (79.68 - 80.03) ms	79.90 ± (79.73 - 80.07) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.89 ± (10.89 - 10.89) MB	10.90 ± (10.90 - 10.91) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	21.88 ± (21.85 - 21.91) ms	21.74 ± (21.72 - 21.77) ms	-0.6%	✅
process.time_to_main_ms	81.31 ± (81.16 - 81.45) ms	80.84 ± (80.69 - 80.98) ms	-0.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.94 ± (10.93 - 10.94) MB	10.94 ± (10.94 - 10.94) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	220.38 ± (219.28 - 221.48) ms	217.05 ± (216.06 - 218.05) ms	-1.5%	✅
process.time_to_main_ms	472.68 ± (472.05 - 473.32) ms	474.39 ± (473.72 - 475.06) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.24 ± (47.21 - 47.27) MB	47.26 ± (47.23 - 47.28) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.3%	✅
.NET 6 - Baseline
process.internal_duration_ms	20.78 ± (20.75 - 20.81) ms	20.76 ± (20.73 - 20.79) ms	-0.1%	✅
process.time_to_main_ms	69.91 ± (69.76 - 70.07) ms	69.51 ± (69.37 - 69.64) ms	-0.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.62 ± (10.62 - 10.62) MB	10.63 ± (10.63 - 10.63) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.52 ± (20.50 - 20.54) ms	20.73 ± (20.71 - 20.75) ms	+1.0%	✅⬆️
process.time_to_main_ms	70.16 ± (70.07 - 70.26) ms	70.70 ± (70.59 - 70.81) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.73 ± (10.73 - 10.74) MB	10.74 ± (10.74 - 10.75) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	206.33 ± (204.11 - 208.56) ms	204.80 ± (202.52 - 207.08) ms	-0.7%	✅
process.time_to_main_ms	473.56 ± (472.71 - 474.41) ms	472.70 ± (472.05 - 473.36) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.03 ± (48.97 - 49.10) MB	49.01 ± (48.95 - 49.08) MB	-0.0%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	18.85 ± (18.82 - 18.88) ms	18.92 ± (18.90 - 18.95) ms	+0.4%	✅⬆️
process.time_to_main_ms	68.63 ± (68.48 - 68.77) ms	68.81 ± (68.66 - 68.96) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.69 ± (7.68 - 7.69) MB	7.68 ± (7.67 - 7.68) MB	-0.1%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	18.88 ± (18.86 - 18.91) ms	18.92 ± (18.89 - 18.95) ms	+0.2%	✅⬆️
process.time_to_main_ms	69.67 ± (69.55 - 69.79) ms	69.63 ± (69.50 - 69.75) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.74 ± (7.73 - 7.75) MB	7.75 ± (7.74 - 7.76) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	157.63 ± (156.77 - 158.48) ms	158.47 ± (157.46 - 159.47) ms	+0.5%	✅⬆️
process.time_to_main_ms	451.64 ± (451.12 - 452.16) ms	450.91 ± (450.24 - 451.57) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	36.53 ± (36.51 - 36.55) MB	36.54 ± (36.53 - 36.56) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅⬆️

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	195.58 ± (195.53 - 196.34) ms	192.66 ± (192.74 - 193.56) ms	-1.5%	✅
.NET Framework 4.8 - Bailout
duration	197.34 ± (197.14 - 197.92) ms	198.56 ± (198.40 - 199.17) ms	+0.6%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1143.98 ± (1144.38 - 1151.56) ms	1152.18 ± (1155.08 - 1164.10) ms	+0.7%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	188.27 ± (187.94 - 188.59) ms	187.75 ± (187.43 - 188.07) ms	-0.3%	✅
process.time_to_main_ms	80.90 ± (80.73 - 81.08) ms	80.76 ± (80.57 - 80.95) ms	-0.2%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.14 ± (16.10 - 16.17) MB	16.08 ± (16.05 - 16.11) MB	-0.3%	✅
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (19 - 20)	-0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	188.05 ± (187.62 - 188.48) ms	188.39 ± (187.96 - 188.82) ms	+0.2%	✅⬆️
process.time_to_main_ms	82.62 ± (82.44 - 82.80) ms	82.23 ± (82.07 - 82.40) ms	-0.5%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.09 ± (16.07 - 16.12) MB	16.18 ± (16.15 - 16.21) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	21 ± (20 - 21)	21 ± (21 - 21)	+0.9%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	397.34 ± (395.60 - 399.08) ms	392.77 ± (390.95 - 394.59) ms	-1.1%	✅
process.time_to_main_ms	474.27 ± (473.58 - 474.95) ms	474.12 ± (473.56 - 474.68) ms	-0.0%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	57.93 ± (57.78 - 58.08) MB	57.53 ± (57.37 - 57.69) MB	-0.7%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (29 - 30)	-0.5%	✅
.NET 6 - Baseline
process.internal_duration_ms	192.60 ± (192.19 - 193.00) ms	192.68 ± (192.30 - 193.07) ms	+0.0%	✅⬆️
process.time_to_main_ms	70.45 ± (70.24 - 70.66) ms	70.54 ± (70.33 - 70.76) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.15 ± (16.02 - 16.28) MB	16.32 ± (16.23 - 16.41) MB	+1.1%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 19)	19 ± (19 - 19)	+3.7%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	191.69 ± (191.36 - 192.03) ms	191.19 ± (190.85 - 191.53) ms	-0.3%	✅
process.time_to_main_ms	71.18 ± (71.06 - 71.30) ms	71.33 ± (71.23 - 71.44) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.17 ± (16.04 - 16.31) MB	16.20 ± (16.06 - 16.34) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (19 - 20)	-0.3%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	428.23 ± (426.42 - 430.04) ms	427.98 ± (426.34 - 429.63) ms	-0.1%	✅
process.time_to_main_ms	476.18 ± (475.42 - 476.94) ms	477.35 ± (476.64 - 478.07) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	60.22 ± (60.15 - 60.29) MB	60.24 ± (60.16 - 60.31) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	190.84 ± (190.41 - 191.27) ms	190.79 ± (190.36 - 191.22) ms	-0.0%	✅
process.time_to_main_ms	70.21 ± (70.00 - 70.43) ms	70.00 ± (69.82 - 70.18) ms	-0.3%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.77 ± (11.74 - 11.79) MB	11.80 ± (11.78 - 11.82) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	-0.1%	✅
.NET 8 - Bailout
process.internal_duration_ms	190.29 ± (189.98 - 190.61) ms	189.28 ± (189.02 - 189.53) ms	-0.5%	✅
process.time_to_main_ms	70.94 ± (70.81 - 71.06) ms	71.01 ± (70.92 - 71.10) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.85 ± (11.82 - 11.88) MB	11.85 ± (11.82 - 11.88) MB	-0.0%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.7%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	351.91 ± (350.56 - 353.26) ms	352.68 ± (351.39 - 353.98) ms	+0.2%	✅⬆️
process.time_to_main_ms	452.69 ± (452.09 - 453.29) ms	454.30 ± (453.58 - 455.03) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	48.41 ± (48.36 - 48.45) MB	48.52 ± (48.48 - 48.56) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.1%	✅

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (69ms)  : 67, 71
    master - mean (70ms)  : 66, 73

    section Bailout
    This PR (8339) - mean (73ms)  : 71, 74
    master - mean (73ms)  : 72, 74

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (1,048ms)  : 1003, 1093
    master - mean (1,051ms)  : 995, 1106

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (107ms)  : 104, 111
    master - mean (107ms)  : 104, 111

    section Bailout
    This PR (8339) - mean (108ms)  : 106, 110
    master - mean (109ms)  : 107, 110

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (727ms)  : 707, 748
    master - mean (730ms)  : 711, 750

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (95ms)  : 93, 98
    master - mean (96ms)  : 93, 99

    section Bailout
    This PR (8339) - mean (97ms)  : 95, 98
    master - mean (96ms)  : 94, 98

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (704ms)  : 659, 749
    master - mean (709ms)  : 668, 751

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (94ms)  : 92, 97
    master - mean (94ms)  : 92, 97

    section Bailout
    This PR (8339) - mean (95ms)  : 93, 97
    master - mean (95ms)  : 93, 97

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (639ms)  : 607, 671
    master - mean (641ms)  : 615, 667

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (193ms)  : 188, 198
    master - mean (196ms)  : 191, 201

    section Bailout
    This PR (8339) - mean (199ms)  : 195, 203
    master - mean (198ms)  : 194, 201

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (1,160ms)  : 1095, 1225
    master - mean (1,148ms)  : 1097, 1199

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (277ms)  : 272, 282
    master - mean (277ms)  : 273, 282

    section Bailout
    This PR (8339) - mean (279ms)  : 273, 286
    master - mean (279ms)  : 274, 284

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (900ms)  : 868, 931
    master - mean (903ms)  : 876, 929

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (271ms)  : 266, 277
    master - mean (272ms)  : 266, 277

    section Bailout
    This PR (8339) - mean (271ms)  : 267, 274
    master - mean (271ms)  : 267, 275

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (939ms)  : 913, 964
    master - mean (936ms)  : 909, 963

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8339) - mean (271ms)  : 262, 280
    master - mean (271ms)  : 263, 278

    section Bailout
    This PR (8339) - mean (270ms)  : 266, 273
    master - mean (271ms)  : 266, 275

    section CallTarget+Inlining+NGEN
    This PR (8339) - mean (836ms)  : 813, 859
    master - mean (835ms)  : 814, 855

andrewlock

As discussed, we're missing a lot from the spec, but hey 🤷‍♂️

andrewlock · 2026-03-20T12:16:46Z

tracer/src/Datadog.Trace/Agent/StatsBuffer.cs


+            if (hasServiceSource)
+            {
+                MessagePackBinary.WriteString(stream, "srv_src");


Based on the stats computation spec, I think this should be service_source, but given that none of our keys match here, I don't know what's correct 😅

Suggested change

MessagePackBinary.WriteString(stream, "srv_src");

MessagePackBinary.WriteString(stream, "service_source");

We should wait for clarification. Thanks for finding that!

andrewlock · 2026-03-20T12:16:52Z

tracer/test/Datadog.Trace.TestHelpers/Stats/MockClientGroupedStats.cs

    [Key("TopLevelHits")]
    public long TopLevelHits { get; set; }
+
+    [Key("srv_src")]


Suggested change

[Key("srv_src")]

[Key("service_source")]

NachoEchevarria added 27 commits March 19, 2026 13:16

initial implementation

e7ea99d

update snapshots

43c805c

update snapshots

45a3914

fix duplicated

fa1e92c

Avoid two calls to GetServiceName

dfd5800

Add warning comments for enum sync

891cd46

rename param

92b5de7

Remove not needed

9495c55

Remove not needed

1603764

Refactor: Use ServiceNameMetadata to decrease double method calls.

83c03be

Fix unit tests

fb7e24a

remove integration arrays

b487692

Refactor schemas

76423c9

Use opt.service_mapping even if default

2e0044c

Fix dbscopefactory

d76c65e

Final check serviceNameEqualsDefault

6ef7bb5

SpanMessagePackFormatter opt case

18105ba

Add unit tests

42401b0

Minor refactor

564ff19

remove hardcoded

19abb0a

Initial implementation

3df9559

Fix unit. Azure Aws add source.

571a6e8

fix unit tests and integration tests

cbf0b86

Update v1 rules

02ecf55

Update OTEL

1721030

Remove commas

5bc3666

serivoce source stats. Initial implementation.

337c5fe

NachoEchevarria added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Mar 19, 2026

NachoEchevarria changed the title ~~Nacho/service source stats~~ Add srv_src field to client stats payload Mar 19, 2026

NachoEchevarria and others added 2 commits March 20, 2026 11:14

protect against empty strings

c80fcaf

Merge branch 'master' into nacho/ServiceSourceStats

d6e12c2

NachoEchevarria marked this pull request as ready for review March 20, 2026 11:34

NachoEchevarria requested a review from a team as a code owner March 20, 2026 11:34

andrewlock approved these changes Mar 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add srv_src field to client stats payload#8339

Add srv_src field to client stats payload#8339
NachoEchevarria wants to merge 29 commits intomasterfrom
nacho/ServiceSourceStats

NachoEchevarria commented Mar 19, 2026 •

edited by atlassian bot

Loading

Uh oh!

pr-commenter bot commented Mar 19, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 19, 2026 •

edited

Loading

FakeDbCommand

HttpMessageHandler

Uh oh!

andrewlock left a comment

Uh oh!

andrewlock Mar 20, 2026

Uh oh!

NachoEchevarria Mar 20, 2026

Uh oh!

andrewlock Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	MessagePackBinary.WriteString(stream, "srv_src");
	MessagePackBinary.WriteString(stream, "service_source");

Conversation

NachoEchevarria commented Mar 19, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

pr-commenter bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

andrewlock Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

NachoEchevarria Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

andrewlock Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NachoEchevarria commented Mar 19, 2026 •

edited by atlassian bot

Loading

pr-commenter bot commented Mar 19, 2026 •

edited

Loading

dd-trace-dotnet-ci-bot bot commented Mar 19, 2026 •

edited

Loading