Skip to content

Configure GeneratePackageVersions to support a "cooldown" on dependencies#8371

Open
bouwkast wants to merge 7 commits intomasterfrom
steven/package-version-release-date-support
Open

Configure GeneratePackageVersions to support a "cooldown" on dependencies#8371
bouwkast wants to merge 7 commits intomasterfrom
steven/package-version-release-date-support

Conversation

@bouwkast
Copy link
Copy Markdown
Collaborator

@bouwkast bouwkast commented Mar 25, 2026

Summary of changes

default cooldown period is 2 days

Adds a configurable cooldown period to the GeneratePackageVersions to support remediation efforts for follow up after #incident-51602.

To use supply the optional parameter --PackageVersionCooldownDays X where X is some number of days. The current period is at the moment is going to be 2 days.

After running the tool a "cooldown" report is generated, this file will contain packages that we see have a newer version, but will not incorporate into the test, the fallback version that falls within the cooldown period is provided. This file content will show up in the output of future test package version bump PRs.

Note that this is for automated updates, so if it sees something already updated it will honor it.

Here's an example output ran locally with 14 days set:

## Package Version Cooldown Report

The following versions were published less than **14 days** ago and have been overridden.
These require manual review before inclusion.

| Package | Integration | Overridden Version | Published | Age (days) | Using Instead |
|---------|-------------|--------------------|-----------|------------|---------------|
| AWSSDK.Core | AwsSdk | 4.0.3.22 | 2026-03-25 | 0 | 4.0.3.21 |
| AWSSDK.S3 | AwsS3 | 4.0.19.2 | 2026-03-25 | 0 | 4.0.19.1 |
| StackExchange.Redis | StackExchangeRedis | 2.12.8 | 2026-03-25 | 0 | 2.12.4 |

Reason for change

In #8364 and #incident-51602 all automated dependency updaters to be disabled temporarily, to re-enable we need to supply a 2 day "cooldown" to any version that we update to (in other words the version of the NuGet must be published for at least 2 days before we can update to it).

Implementation details

I made Claude do this 🤖

  • NuGetPackageHelper now captures the Published date from IPackageSearchMetadata via a new VersionWithDate record (previously discarded)
  • NuGetVersionCache stores the new {Version, Published} format
  • PackageVersionGenerator.ApplyCooldown filters selected versions after LatestMajors/LatestMinors/LatestSpecific selection:
    • Versions outside the cooldown window pass through unchanged
    • Versions at or below the baseline (derived from supported_versions.json MaxVersionTestedInclusive) are kept even if
      within cooldown -- no downgrades
    • Versions above the baseline and within cooldown are overridden to the best available fallback
  • CooldownReport collects overridden versions and renders a markdown table saved to tracer/build/cooldown_report.md
  • The GitHub Actions workflow reads the report and appends it to the auto-bump PR body
  • Honeypot IntegrationGroups.cs fixes: MSTest.TestFramework now maps to itself, Hangfire.Core maps to Hangfire.Core (was Hangfire), OpenFeature mapping moved to Datadog.FeatureFlags.OpenFeature

Test coverage

I ran GeneratePackageVersions --PackageVersionCooldownDays 14 locally seems good enough IMO (also ran without, with different days etc)

[WRN] GeneratePackageVersi: 3 package version(s) were excluded due to the 14-day cooldown period
[WRN] GeneratePackageVersi:   AWSSDK.Core 4.0.3.22 overridden (published 2026-03-25, using: 4.0.3.21)
[WRN] GeneratePackageVersi:   AWSSDK.S3 4.0.19.2 overridden (published 2026-03-25, using: 4.0.19.1)
[WRN] GeneratePackageVersi:   StackExchange.Redis 2.12.8 overridden (published 2026-03-25, using: 2.12.4)

Other details

The workflow file (auto_bump_test_package_versions.yml) will be re-enabled with this PR

@bouwkast bouwkast added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Mar 25, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 25, 2026

Benchmarks

Benchmark execution time: 2026-03-27 21:03:59

Comparing candidate commit c71f249 in PR branch steven/package-version-release-date-support with baseline commit 5ff69b3 in branch master.

Found 6 performance improvements and 15 performance regressions! Performance is the same for 249 metrics, 18 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 execution_time [-22.107ms; -21.702ms] or [-9.997%; -9.814%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+83.766ms; +83.858ms] or [+67.190%; +67.264%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+92.791ms; +92.941ms] or [+82.296%; +82.430%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 execution_time [+11.980ms; +17.283ms] or [+5.985%; +8.634%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 throughput [-84194.796op/s; -58207.498op/s] or [-8.978%; -6.207%]
  • 🟩 execution_time [-21.749ms; -16.301ms] or [-10.134%; -7.596%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 execution_time [+15.960ms; +21.929ms] or [+8.036%; +11.041%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 execution_time [+13.465ms; +16.935ms] or [+6.747%; +8.486%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+18.708ms; +24.451ms] or [+9.544%; +12.474%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+24.182ms; +24.987ms] or [+13.531%; +13.981%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+28.808ms; +33.811ms] or [+15.676%; +18.398%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 throughput [-288.651op/s; -209.503op/s] or [-17.996%; -13.062%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟥 throughput [-187.084op/s; -137.220op/s] or [-35.496%; -26.035%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 throughput [+49.869op/s; +60.346op/s] or [+5.273%; +6.381%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+12.096ms; +15.791ms] or [+6.259%; +8.170%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-18.685KB; -18.651KB] or [-6.734%; -6.722%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+13.575ms; +19.421ms] or [+7.263%; +10.391%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+12.626ms; +15.935ms] or [+6.766%; +8.540%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟩 execution_time [-38.294ms; -36.524ms] or [-19.391%; -18.494%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟥 execution_time [+16.381ms; +21.470ms] or [+8.479%; +11.113%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 execution_time [-20.477ms; -15.516ms] or [-9.407%; -7.128%]

@dd-trace-dotnet-ci-bot
Copy link
Copy Markdown

dd-trace-dotnet-ci-bot bot commented Mar 25, 2026

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8371) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration71.60 ± (71.61 - 71.90) ms71.74 ± (71.86 - 72.15) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration76.15 ± (76.08 - 76.42) ms76.19 ± (76.08 - 76.46) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1075.10 ± (1076.27 - 1082.46) ms1075.59 ± (1075.58 - 1083.65) ms+0.0%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.41 ± (22.37 - 22.44) ms22.43 ± (22.38 - 22.47) ms+0.1%✅⬆️
process.time_to_main_ms83.43 ± (83.24 - 83.63) ms84.01 ± (83.78 - 84.24) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.92 ± (10.91 - 10.92) MB10.92 ± (10.91 - 10.92) MB-0.0%
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.34 ± (22.31 - 22.38) ms22.33 ± (22.30 - 22.36) ms-0.1%
process.time_to_main_ms84.90 ± (84.70 - 85.09) ms85.19 ± (84.98 - 85.39) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.96) MB10.95 ± (10.94 - 10.95) MB-0.1%
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms226.35 ± (225.06 - 227.65) ms224.05 ± (222.83 - 225.27) ms-1.0%
process.time_to_main_ms534.46 ± (533.37 - 535.55) ms533.03 ± (531.97 - 534.08) ms-0.3%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.26 ± (48.23 - 48.29) MB48.24 ± (48.21 - 48.27) MB-0.0%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.3%
.NET 6 - Baseline
process.internal_duration_ms21.14 ± (21.10 - 21.17) ms20.96 ± (20.93 - 21.00) ms-0.8%
process.time_to_main_ms72.06 ± (71.88 - 72.23) ms71.95 ± (71.78 - 72.12) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.65) MB10.64 ± (10.64 - 10.64) MB-0.1%
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.05 ± (21.01 - 21.09) ms21.01 ± (20.97 - 21.05) ms-0.2%
process.time_to_main_ms73.27 ± (73.11 - 73.43) ms73.11 ± (72.94 - 73.28) ms-0.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.75 ± (10.75 - 10.76) MB10.75 ± (10.75 - 10.75) MB-0.1%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms216.21 ± (214.65 - 217.77) ms213.33 ± (212.13 - 214.53) ms-1.3%
process.time_to_main_ms530.28 ± (528.80 - 531.77) ms534.75 ± (533.58 - 535.92) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed50.05 ± (50.02 - 50.09) MB50.18 ± (50.15 - 50.20) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.4%
.NET 8 - Baseline
process.internal_duration_ms19.26 ± (19.22 - 19.29) ms19.31 ± (19.27 - 19.34) ms+0.2%✅⬆️
process.time_to_main_ms71.75 ± (71.61 - 71.89) ms71.86 ± (71.69 - 72.03) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.69 ± (7.69 - 7.70) MB7.68 ± (7.67 - 7.68) MB-0.2%
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.22 ± (19.18 - 19.26) ms19.39 ± (19.36 - 19.42) ms+0.9%✅⬆️
process.time_to_main_ms72.84 ± (72.67 - 73.02) ms73.28 ± (73.10 - 73.46) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.77 ± (7.76 - 7.78) MB7.77 ± (7.76 - 7.77) MB-0.0%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms161.44 ± (160.71 - 162.16) ms159.89 ± (159.08 - 160.69) ms-1.0%
process.time_to_main_ms492.12 ± (491.14 - 493.10) ms493.22 ± (492.05 - 494.38) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.98 ± (36.96 - 37.00) MB36.90 ± (36.88 - 36.93) MB-0.2%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration220.50 ± (221.00 - 223.02) ms217.52 ± (216.96 - 218.86) ms-1.3%
.NET Framework 4.8 - Bailout
duration224.21 ± (224.51 - 226.46) ms225.44 ± (225.39 - 227.68) ms+0.5%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1257.56 ± (1255.96 - 1263.72) ms1256.77 ± (1257.75 - 1264.76) ms-0.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms213.62 ± (212.96 - 214.28) ms214.29 ± (213.45 - 215.13) ms+0.3%✅⬆️
process.time_to_main_ms91.72 ± (91.46 - 91.98) ms91.53 ± (91.22 - 91.85) ms-0.2%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed15.88 ± (15.86 - 15.89) MB15.87 ± (15.85 - 15.88) MB-0.1%
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.1%
.NET Core 3.1 - Bailout
process.internal_duration_ms212.33 ± (211.71 - 212.95) ms214.36 ± (213.52 - 215.20) ms+1.0%✅⬆️
process.time_to_main_ms93.12 ± (92.87 - 93.37) ms92.81 ± (92.53 - 93.09) ms-0.3%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed15.89 ± (15.88 - 15.90) MB15.97 ± (15.96 - 15.99) MB+0.5%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.4%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms425.69 ± (424.33 - 427.04) ms423.99 ± (422.46 - 425.52) ms-0.4%
process.time_to_main_ms572.04 ± (570.79 - 573.29) ms570.10 ± (568.73 - 571.47) ms-0.3%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed59.15 ± (59.11 - 59.19) MB59.07 ± (59.02 - 59.12) MB-0.1%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.3%
.NET 6 - Baseline
process.internal_duration_ms217.34 ± (216.73 - 217.96) ms221.76 ± (220.59 - 222.92) ms+2.0%✅⬆️
process.time_to_main_ms79.15 ± (78.93 - 79.37) ms79.66 ± (79.36 - 79.97) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.18 ± (16.16 - 16.20) MB16.16 ± (16.15 - 16.18) MB-0.1%
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.1%
.NET 6 - Bailout
process.internal_duration_ms216.30 ± (215.71 - 216.88) ms222.16 ± (221.14 - 223.18) ms+2.7%✅⬆️
process.time_to_main_ms80.30 ± (80.08 - 80.52) ms81.53 ± (81.25 - 81.80) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.14 ± (16.12 - 16.15) MB16.17 ± (16.16 - 16.19) MB+0.2%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.2%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms454.40 ± (452.58 - 456.22) ms457.50 ± (454.17 - 460.82) ms+0.7%✅⬆️
process.time_to_main_ms576.04 ± (574.70 - 577.38) ms575.48 ± (574.16 - 576.80) ms-0.1%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed60.54 ± (60.45 - 60.63) MB60.59 ± (60.51 - 60.68) MB+0.1%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.1%
.NET 8 - Baseline
process.internal_duration_ms215.74 ± (214.91 - 216.56) ms222.71 ± (221.37 - 224.04) ms+3.2%✅⬆️
process.time_to_main_ms78.03 ± (77.80 - 78.25) ms78.76 ± (78.49 - 79.02) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.45 ± (11.44 - 11.47) MB11.45 ± (11.43 - 11.47) MB-0.0%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.2%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms225.18 ± (223.71 - 226.65) ms216.34 ± (215.30 - 217.38) ms-3.9%
process.time_to_main_ms80.78 ± (80.50 - 81.06) ms79.57 ± (79.36 - 79.79) ms-1.5%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.42 ± (11.41 - 11.44) MB11.50 ± (11.48 - 11.51) MB+0.6%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.1%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms478.06 ± (476.50 - 479.62) ms474.91 ± (471.85 - 477.98) ms-0.7%
process.time_to_main_ms534.79 ± (533.53 - 536.05) ms532.07 ± (530.90 - 533.24) ms-0.5%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)-0.4%
runtime.dotnet.mem.committed50.77 ± (50.73 - 50.82) MB50.71 ± (50.65 - 50.76) MB-0.1%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (72ms)  : 70, 74
    master - mean (72ms)  : 70, 74

    section Bailout
    This PR (8371) - mean (76ms)  : 74, 79
    master - mean (76ms)  : 74, 78

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (1,080ms)  : 1022, 1137
    master - mean (1,079ms)  : 1035, 1123

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (113ms)  : 109, 117
    master - mean (113ms)  : 109, 116

    section Bailout
    This PR (8371) - mean (114ms)  : 111, 117
    master - mean (114ms)  : 111, 116

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (795ms)  : 779, 812
    master - mean (798ms)  : 772, 824

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (99ms)  : 96, 102
    master - mean (99ms)  : 96, 102

    section Bailout
    This PR (8371) - mean (100ms)  : 97, 103
    master - mean (100ms)  : 98, 103

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (788ms)  : 768, 808
    master - mean (784ms)  : 765, 803

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (99ms)  : 95, 102
    master - mean (99ms)  : 95, 102

    section Bailout
    This PR (8371) - mean (100ms)  : 97, 104
    master - mean (100ms)  : 97, 103

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (695ms)  : 682, 709
    master - mean (691ms)  : 666, 716

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (218ms)  : 203, 233
    master - mean (222ms)  : 207, 237

    section Bailout
    This PR (8371) - mean (227ms)  : 210, 243
    master - mean (225ms)  : 210, 240

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (1,261ms)  : 1212, 1311
    master - mean (1,260ms)  : 1202, 1317

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (316ms)  : 302, 330
    master - mean (315ms)  : 304, 326

    section Bailout
    This PR (8371) - mean (317ms)  : 300, 334
    master - mean (315ms)  : 303, 327

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (1,037ms)  : 1005, 1068
    master - mean (1,037ms)  : 999, 1075

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (312ms)  : 291, 333
    master - mean (306ms)  : 294, 318

    section Bailout
    This PR (8371) - mean (313ms)  : 292, 335
    master - mean (306ms)  : 295, 318

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (1,073ms)  : 1012, 1133
    master - mean (1,071ms)  : 1033, 1109

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8371) - mean (313ms)  : 292, 334
    master - mean (305ms)  : 291, 318

    section Bailout
    This PR (8371) - mean (308ms)  : 287, 328
    master - mean (317ms)  : 292, 342

    section CallTarget+Inlining+NGEN
    This PR (8371) - mean (1,041ms)  : 977, 1106
    master - mean (1,050ms)  : 1007, 1094

Loading

@bouwkast bouwkast force-pushed the steven/package-version-release-date-support branch from 84b9b6e to 545f246 Compare March 26, 2026 15:01
@bouwkast bouwkast marked this pull request as ready for review March 26, 2026 16:09
@bouwkast bouwkast requested review from a team as code owners March 26, 2026 16:09
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems weird 🤔

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it "Hangfire.Core" and not "Hangfire" I couldn't get it to honor the cooldown as the NuGet name was wrong

new object[] { string.Empty },
#else
#if NET48
new object[] { "1.5.14" },
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird 😅

Copy link
Copy Markdown
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering, would it be easiest to just filter at the source when we load from NuGet? 🤔 and then everything else filters through. I guess you're trying to make it stable, but if we just forced 48 hours always then it would always be stable 🤷‍♂️ Not worried either way, just a thought 😄

NugetPackages.Add("Microsoft.VisualStudio.TraceDataCollector", Array.Empty<string>());
NugetPackages.Add("Microsoft.TestPlatform.CrossPlatEngine", Array.Empty<string>());
NugetPackages.Add("MSTest.TestFramework", Array.Empty<string>());
NugetPackages.Add("MSTest.TestFramework", new [] { "MSTest.TestFramework" });
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what are these even for again? 😅 do we need them in the manual instrumentation ones too?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue is that the ones I had to update here were all getting around as the "name"/"key" for them all comes from various locations and there are several disconnects, probably could do with a refactoring somewhere to make sure the names and keys all are consistent amongst all files somehow

If that answers it

@bouwkast bouwkast force-pushed the steven/package-version-release-date-support branch from c4c28ec to c71f249 Compare March 27, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants