Skip to content

go.mod: replace mapstructure and parseutil #3329

Merged
eliottness merged 3 commits intov2-devfrom
eliottness/update-deps
Mar 27, 2025
Merged

go.mod: replace mapstructure and parseutil #3329
eliottness merged 3 commits intov2-devfrom
eliottness/update-deps

Conversation

@eliottness
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Replace github.com/hashicorp/go-secure-stdlib/parseutil with strconv
  • Replace github.com/mitchellh/mapstructure with github.com/go-viper/mapstructure/v2
  • Run find -name go.mod -execdir go mod tidy \;

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 21, 2025
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 21, 2025

Datadog Report

Branch report: eliottness/update-deps
Commit report: ee1c541
Test service: dd-trace-go

✅ 0 Failed, 4493 Passed, 65 Skipped, 23m 21.74s Total Time

@eliottness eliottness force-pushed the eliottness/update-deps branch 2 times, most recently from ad9df63 to 1a92492 Compare March 21, 2025 13:44
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 21, 2025

Benchmarks

Benchmark execution time: 2025-03-27 09:00:43

Comparing candidate commit 7e7abef in PR branch eliottness/update-deps with baseline commit 0b8b4d6 in branch v2-dev.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 55 metrics, 0 unstable metrics.

scenario:BenchmarkStartSpan-24

  • 🟥 execution_time [+71.245ns; +92.755ns] or [+2.989%; +3.891%]

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
…tructure

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness force-pushed the eliottness/update-deps branch from 1a92492 to 7e7abef Compare March 27, 2025 08:30
@eliottness eliottness marked this pull request as ready for review March 27, 2025 08:52
@eliottness eliottness requested review from a team as code owners March 27, 2025 08:52
Copy link
Copy Markdown
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliottness eliottness merged commit 1fd1443 into v2-dev Mar 27, 2025
197 checks passed
@eliottness eliottness deleted the eliottness/update-deps branch March 27, 2025 10:58
@darccio darccio added the v2.0 label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs v2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants