Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade k8s.io/apimachinery dependency from v0.32.2 to v0.31.4 #3348

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Mar 26, 2025

What does this PR do?

Removes the indirect line setting k8s.io/apimachinery to v0.32.2, effectively ensuring the right version is used across all the impacted modules.

Motivation

go mod tidy didn't remove it although the root module doesn't use it directly.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners March 26, 2025 11:40
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 26, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 26, 2025

Datadog Report

Branch report: dario.castane/remove-extra-k8s-dependency
Commit report: 45b10f7
Test service: dd-trace-go

✅ 0 Failed, 4480 Passed, 65 Skipped, 22m 41.69s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2025

Benchmarks

Benchmark execution time: 2025-03-26 11:56:14

Comparing candidate commit 1385ebc in PR branch dario.castane/remove-extra-k8s-dependency with baseline commit 57473e2 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

@darccio darccio merged commit 991155b into v2-dev Mar 27, 2025
195 of 197 checks passed
@darccio darccio deleted the dario.castane/remove-extra-k8s-dependency branch March 27, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants