Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-discovery): report go instead of golang #3352

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

dmehala
Copy link
Contributor

@dmehala dmehala commented Mar 27, 2025

What does this PR do?

This change the language reported to be go instead of golang to be coherent with the RFC and the telemetry module.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@dmehala dmehala requested a review from a team as a code owner March 27, 2025 08:49
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 27, 2025

Datadog Report

Branch report: dmehala/fix/service-discovery-report-lang
Commit report: f38b1a9
Test service: dd-trace-go

✅ 0 Failed, 5487 Passed, 72 Skipped, 10m 13.02s Total Time

@dmehala dmehala requested a review from darccio March 27, 2025 09:14
@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-03-27 11:24:21

Comparing candidate commit d1d3943 in PR branch dmehala/fix/service-discovery-report-lang with baseline commit 1be9aea in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 1 unstable metrics.

@dmehala
Copy link
Contributor Author

dmehala commented Mar 27, 2025

@darccio or @kakkoyun I am not authorized to merge, can any of you do it please?

@darccio darccio merged commit 67026ce into main Mar 27, 2025
178 checks passed
@darccio darccio deleted the dmehala/fix/service-discovery-report-lang branch March 27, 2025 14:35
@darccio
Copy link
Member

darccio commented Mar 27, 2025

Done @dmehala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants