Move span pointers handling into instrumentations#10974
Move span pointers handling into instrumentations#10974PerfectSlayer wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054624
Total [baseline] (8.854 s) : 0, 8853925
Agent [candidate] (1.074 s) : 0, 1073605
Total [candidate] (8.875 s) : 0, 8874980
section iast
Agent [baseline] (1.225 s) : 0, 1225340
Total [baseline] (9.551 s) : 0, 9551316
Agent [candidate] (1.234 s) : 0, 1233953
Total [candidate] (9.565 s) : 0, 9564995
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (627.632 ms) : 0, 627632
BytebuddyAgent [candidate] (638.414 ms) : 0, 638414
AgentMeter [baseline] (29.377 ms) : 0, 29377
AgentMeter [candidate] (29.94 ms) : 0, 29940
GlobalTracer [baseline] (256.318 ms) : 0, 256318
GlobalTracer [candidate] (260.244 ms) : 0, 260244
AppSec [baseline] (31.689 ms) : 0, 31689
AppSec [candidate] (32.311 ms) : 0, 32311
Debugger [baseline] (59.45 ms) : 0, 59450
Debugger [candidate] (60.509 ms) : 0, 60509
Remote Config [baseline] (582.956 µs) : 0, 583
Remote Config [candidate] (592.356 µs) : 0, 592
Telemetry [baseline] (8.076 ms) : 0, 8076
Telemetry [candidate] (8.226 ms) : 0, 8226
Flare Poller [baseline] (4.264 ms) : 0, 4264
Flare Poller [candidate] (5.86 ms) : 0, 5860
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (795.759 ms) : 0, 795759
BytebuddyAgent [candidate] (801.655 ms) : 0, 801655
AgentMeter [baseline] (11.352 ms) : 0, 11352
AgentMeter [candidate] (11.63 ms) : 0, 11630
GlobalTracer [baseline] (246.75 ms) : 0, 246750
GlobalTracer [candidate] (248.641 ms) : 0, 248641
IAST [baseline] (25.335 ms) : 0, 25335
IAST [candidate] (25.514 ms) : 0, 25514
AppSec [baseline] (26.525 ms) : 0, 26525
AppSec [candidate] (26.652 ms) : 0, 26652
Debugger [baseline] (68.047 ms) : 0, 68047
Debugger [candidate] (68.276 ms) : 0, 68276
Remote Config [baseline] (522.012 µs) : 0, 522
Remote Config [candidate] (522.978 µs) : 0, 523
Telemetry [baseline] (10.415 ms) : 0, 10415
Telemetry [candidate] (10.175 ms) : 0, 10175
Flare Poller [baseline] (3.456 ms) : 0, 3456
Flare Poller [candidate] (3.54 ms) : 0, 3540
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054975
Total [baseline] (11.005 s) : 0, 11005136
Agent [candidate] (1.062 s) : 0, 1062460
Total [candidate] (11.054 s) : 0, 11054236
section appsec
Agent [baseline] (1.246 s) : 0, 1246030
Total [baseline] (11.156 s) : 0, 11155687
Agent [candidate] (1.247 s) : 0, 1246863
Total [candidate] (11.184 s) : 0, 11183944
section iast
Agent [baseline] (1.238 s) : 0, 1238043
Total [baseline] (11.321 s) : 0, 11321148
Agent [candidate] (1.228 s) : 0, 1227605
Total [candidate] (11.352 s) : 0, 11352211
section profiling
Agent [baseline] (1.183 s) : 0, 1182965
Total [baseline] (10.984 s) : 0, 10983640
Agent [candidate] (1.195 s) : 0, 1195245
Total [candidate] (11.075 s) : 0, 11074852
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (626.539 ms) : 0, 626539
BytebuddyAgent [candidate] (632.903 ms) : 0, 632903
AgentMeter [baseline] (29.28 ms) : 0, 29280
AgentMeter [candidate] (29.579 ms) : 0, 29579
GlobalTracer [baseline] (256.269 ms) : 0, 256269
GlobalTracer [candidate] (257.854 ms) : 0, 257854
AppSec [baseline] (31.761 ms) : 0, 31761
AppSec [candidate] (31.938 ms) : 0, 31938
Debugger [baseline] (60.312 ms) : 0, 60312
Debugger [candidate] (60.604 ms) : 0, 60604
Remote Config [baseline] (586.021 µs) : 0, 586
Remote Config [candidate] (582.396 µs) : 0, 582
Telemetry [baseline] (9.545 ms) : 0, 9545
Telemetry [candidate] (8.104 ms) : 0, 8104
Flare Poller [baseline] (3.565 ms) : 0, 3565
Flare Poller [candidate] (3.564 ms) : 0, 3564
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (658.925 ms) : 0, 658925
BytebuddyAgent [candidate] (659.09 ms) : 0, 659090
AgentMeter [baseline] (12.152 ms) : 0, 12152
AgentMeter [candidate] (12.104 ms) : 0, 12104
GlobalTracer [baseline] (257.79 ms) : 0, 257790
GlobalTracer [candidate] (257.512 ms) : 0, 257512
IAST [baseline] (24.117 ms) : 0, 24117
IAST [candidate] (24.17 ms) : 0, 24170
AppSec [baseline] (177.169 ms) : 0, 177169
AppSec [candidate] (177.707 ms) : 0, 177707
Debugger [baseline] (65.962 ms) : 0, 65962
Debugger [candidate] (66.338 ms) : 0, 66338
Remote Config [baseline] (630.43 µs) : 0, 630
Remote Config [candidate] (623.362 µs) : 0, 623
Telemetry [baseline] (8.344 ms) : 0, 8344
Telemetry [candidate] (8.431 ms) : 0, 8431
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.531 ms) : 0, 3531
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (803.569 ms) : 0, 803569
BytebuddyAgent [candidate] (796.613 ms) : 0, 796613
AgentMeter [baseline] (11.716 ms) : 0, 11716
AgentMeter [candidate] (11.408 ms) : 0, 11408
GlobalTracer [baseline] (248.893 ms) : 0, 248893
GlobalTracer [candidate] (247.308 ms) : 0, 247308
IAST [baseline] (25.595 ms) : 0, 25595
IAST [candidate] (25.312 ms) : 0, 25312
AppSec [baseline] (26.786 ms) : 0, 26786
AppSec [candidate] (26.481 ms) : 0, 26481
Debugger [baseline] (70.947 ms) : 0, 70947
Debugger [candidate] (70.286 ms) : 0, 70286
Remote Config [baseline] (545.362 µs) : 0, 545
Remote Config [candidate] (523.656 µs) : 0, 524
Telemetry [baseline] (9.11 ms) : 0, 9110
Telemetry [candidate] (9.076 ms) : 0, 9076
Flare Poller [baseline] (3.464 ms) : 0, 3464
Flare Poller [candidate] (3.444 ms) : 0, 3444
section profiling
crashtracking [baseline] (1.169 ms) : 0, 1169
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (683.488 ms) : 0, 683488
BytebuddyAgent [candidate] (691.767 ms) : 0, 691767
AgentMeter [baseline] (9.009 ms) : 0, 9009
AgentMeter [candidate] (9.094 ms) : 0, 9094
GlobalTracer [baseline] (214.439 ms) : 0, 214439
GlobalTracer [candidate] (217.059 ms) : 0, 217059
AppSec [baseline] (32.357 ms) : 0, 32357
AppSec [candidate] (32.571 ms) : 0, 32571
Debugger [baseline] (65.996 ms) : 0, 65996
Debugger [candidate] (65.031 ms) : 0, 65031
Remote Config [baseline] (558.375 µs) : 0, 558
Remote Config [candidate] (575.254 µs) : 0, 575
Telemetry [baseline] (7.704 ms) : 0, 7704
Telemetry [candidate] (7.783 ms) : 0, 7783
Flare Poller [baseline] (3.475 ms) : 0, 3475
Flare Poller [candidate] (5.117 ms) : 0, 5117
ProfilingAgent [baseline] (93.897 ms) : 0, 93897
ProfilingAgent [candidate] (93.594 ms) : 0, 93594
Profiling [baseline] (94.455 ms) : 0, 94455
Profiling [candidate] (94.147 ms) : 0, 94147
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (18.331 ms) : 18141, 18521
. : milestone, 18331,
appsec (18.394 ms) : 18205, 18583
. : milestone, 18394,
code_origins (17.408 ms) : 17234, 17582
. : milestone, 17408,
iast (18.059 ms) : 17877, 18240
. : milestone, 18059,
profiling (18.479 ms) : 18289, 18669
. : milestone, 18479,
tracing (18.0 ms) : 17819, 18181
. : milestone, 18000,
section candidate
no_agent (18.341 ms) : 18153, 18528
. : milestone, 18341,
appsec (18.361 ms) : 18172, 18550
. : milestone, 18361,
code_origins (17.881 ms) : 17702, 18060
. : milestone, 17881,
iast (18.123 ms) : 17942, 18305
. : milestone, 18123,
profiling (19.595 ms) : 19398, 19793
. : milestone, 19595,
tracing (17.779 ms) : 17600, 17958
. : milestone, 17779,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1218
. : milestone, 1206,
iast (3.128 ms) : 3087, 3168
. : milestone, 3128,
iast_FULL (5.898 ms) : 5837, 5959
. : milestone, 5898,
iast_GLOBAL (3.405 ms) : 3356, 3455
. : milestone, 3405,
profiling (2.187 ms) : 2167, 2207
. : milestone, 2187,
tracing (1.772 ms) : 1759, 1786
. : milestone, 1772,
section candidate
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.238 ms) : 3194, 3281
. : milestone, 3238,
iast_FULL (6.073 ms) : 6011, 6135
. : milestone, 6073,
iast_GLOBAL (3.456 ms) : 3406, 3505
. : milestone, 3456,
profiling (1.99 ms) : 1972, 2008
. : milestone, 1990,
tracing (1.765 ms) : 1751, 1780
. : milestone, 1765,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.733 ms) : 3516, 3951
. : milestone, 3733,
iast (2.267 ms) : 2198, 2336
. : milestone, 2267,
iast_GLOBAL (2.292 ms) : 2223, 2361
. : milestone, 2292,
profiling (2.095 ms) : 2040, 2150
. : milestone, 2095,
tracing (2.081 ms) : 2028, 2135
. : milestone, 2081,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.727 ms) : 3510, 3944
. : milestone, 3727,
iast (2.249 ms) : 2181, 2318
. : milestone, 2249,
iast_GLOBAL (2.296 ms) : 2227, 2366
. : milestone, 2296,
profiling (2.103 ms) : 2047, 2160
. : milestone, 2103,
tracing (2.059 ms) : 2005, 2112
. : milestone, 2059,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~2645dc6f73, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
appsec (14.493 s) : 14493000, 14493000
. : milestone, 14493000,
iast (18.529 s) : 18529000, 18529000
. : milestone, 18529000,
iast_GLOBAL (17.978 s) : 17978000, 17978000
. : milestone, 17978000,
profiling (15.803 s) : 15803000, 15803000
. : milestone, 15803000,
tracing (14.901 s) : 14901000, 14901000
. : milestone, 14901000,
section candidate
no_agent (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
appsec (14.692 s) : 14692000, 14692000
. : milestone, 14692000,
iast (18.248 s) : 18248000, 18248000
. : milestone, 18248000,
iast_GLOBAL (18.07 s) : 18070000, 18070000
. : milestone, 18070000,
profiling (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
tracing (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
|
|
The following files add Groovy tests to modules that are candidates for migration to Java / JUnit 5:
Consider writing these tests in Java / JUnit 5 instead to help with the ongoing migration effort. |
The file was moved as part of the refactoring. The logic stays the same but I can port it in a follow up PR if we like. |
What Does This Do
This PR moves the span pointers handling into their related instrumentations.
Motivation
The goal is to avoid using span tags as context storage and create span links where the data is.
This will fix the design issue of having to inject writable span links in tags processing.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.