writer impl #8372
Draft
writer impl #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
158
to
325
| private PayloadV2() { | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
| LOGGER.error("Exception occurred", e); | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
🟠 Code Quality Violation
Avoid printStackTrace(); use a logger call instead. (...read more)
Use a logging framework instead of printStackTrace() when handling exceptions. printStackTrace() can be useful during development for quick debugging, but it is not suitable for production code.
gary-huang
force-pushed
the
gary/impl-llm-obs-api
branch
2 times, most recently
from
680ec94 to
b1d7aeb
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
from
113bf8c to
9052dc4
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 11 performance regressions! Performance is the same for 43 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049969
Total [baseline] (8.678 s) : 0, 8677878
Agent [candidate] (1.067 s) : 0, 1067268
Total [candidate] (8.652 s) : 0, 8652270
section iast
Agent [baseline] (1.175 s) : 0, 1174956
Total [baseline] (9.224 s) : 0, 9223609
Agent [candidate] (1.194 s) : 0, 1194029
Total [candidate] (9.285 s) : 0, 9285252
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1173059
Total [baseline] (9.22 s) : 0, 9220376
Agent [candidate] (1.19 s) : 0, 1189535
Total [candidate] (9.235 s) : 0, 9235294
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1172116
Total [baseline] (9.2 s) : 0, 9200386
Agent [candidate] (1.184 s) : 0, 1184350
Total [candidate] (9.246 s) : 0, 9245670
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.232 ms) : 0, 722232
BytebuddyAgent [candidate] (718.601 ms) : 0, 718601
GlobalTracer [baseline] (241.566 ms) : 0, 241566
GlobalTracer [candidate] (262.65 ms) : 0, 262650
AppSec [baseline] (55.78 ms) : 0, 55780
AppSec [candidate] (57.929 ms) : 0, 57929
Remote Config [baseline] (705.115 µs) : 0, 705
Remote Config [candidate] (712.939 µs) : 0, 713
Telemetry [baseline] (14.433 ms) : 0, 14433
Telemetry [candidate] (12.338 ms) : 0, 12338
section iast
BytebuddyAgent [baseline] (838.655 ms) : 0, 838655
BytebuddyAgent [candidate] (834.918 ms) : 0, 834918
GlobalTracer [baseline] (231.08 ms) : 0, 231080
GlobalTracer [candidate] (254.776 ms) : 0, 254776
AppSec [baseline] (57.568 ms) : 0, 57568
AppSec [candidate] (58.047 ms) : 0, 58047
IAST [baseline] (22.924 ms) : 0, 22924
IAST [candidate] (21.745 ms) : 0, 21745
Remote Config [baseline] (618.333 µs) : 0, 618
Remote Config [candidate] (668.601 µs) : 0, 669
Telemetry [baseline] (8.816 ms) : 0, 8816
Telemetry [candidate] (8.85 ms) : 0, 8850
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.429 ms) : 0, 837429
BytebuddyAgent [candidate] (832.669 ms) : 0, 832669
GlobalTracer [baseline] (230.604 ms) : 0, 230604
GlobalTracer [candidate] (252.848 ms) : 0, 252848
AppSec [baseline] (57.428 ms) : 0, 57428
AppSec [candidate] (57.922 ms) : 0, 57922
IAST [baseline] (22.995 ms) : 0, 22995
IAST [candidate] (21.584 ms) : 0, 21584
Remote Config [baseline] (607.792 µs) : 0, 608
Remote Config [candidate] (669.129 µs) : 0, 669
Telemetry [baseline] (8.694 ms) : 0, 8694
Telemetry [candidate] (8.798 ms) : 0, 8798
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.099 ms) : 0, 837099
BytebuddyAgent [candidate] (829.703 ms) : 0, 829703
GlobalTracer [baseline] (231.116 ms) : 0, 231116
GlobalTracer [candidate] (252.174 ms) : 0, 252174
AppSec [baseline] (52.529 ms) : 0, 52529
AppSec [candidate] (57.024 ms) : 0, 57024
IAST [baseline] (26.854 ms) : 0, 26854
IAST [candidate] (21.072 ms) : 0, 21072
Remote Config [baseline] (623.388 µs) : 0, 623
Remote Config [candidate] (662.282 µs) : 0, 662
Telemetry [baseline] (8.569 ms) : 0, 8569
Telemetry [candidate] (8.626 ms) : 0, 8626
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047175
Total [baseline] (10.391 s) : 0, 10390820
Agent [candidate] (1.062 s) : 0, 1061779
Total [candidate] (10.471 s) : 0, 10470755
section appsec
Agent [baseline] (1.189 s) : 0, 1188542
Total [baseline] (10.766 s) : 0, 10766367
Agent [candidate] (1.195 s) : 0, 1194880
Total [candidate] (10.776 s) : 0, 10775579
section iast
Agent [baseline] (1.187 s) : 0, 1186671
Total [baseline] (10.977 s) : 0, 10976879
Agent [candidate] (1.19 s) : 0, 1189794
Total [candidate] (10.969 s) : 0, 10969023
section profiling
Agent [baseline] (1.262 s) : 0, 1261601
Total [baseline] (10.934 s) : 0, 10933641
Agent [candidate] (1.279 s) : 0, 1278689
Total [candidate] (10.825 s) : 0, 10824805
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.272 ms) : 0, 722272
BytebuddyAgent [candidate] (714.766 ms) : 0, 714766
GlobalTracer [baseline] (240.913 ms) : 0, 240913
GlobalTracer [candidate] (261.536 ms) : 0, 261536
AppSec [baseline] (55.759 ms) : 0, 55759
AppSec [candidate] (58.392 ms) : 0, 58392
Remote Config [baseline] (697.006 µs) : 0, 697
Remote Config [candidate] (716.104 µs) : 0, 716
Telemetry [baseline] (12.255 ms) : 0, 12255
Telemetry [candidate] (11.305 ms) : 0, 11305
section appsec
BytebuddyAgent [baseline] (738.717 ms) : 0, 738717
BytebuddyAgent [candidate] (734.471 ms) : 0, 734471
GlobalTracer [baseline] (237.255 ms) : 0, 237255
GlobalTracer [candidate] (259.322 ms) : 0, 259322
AppSec [baseline] (177.495 ms) : 0, 177495
AppSec [candidate] (166.783 ms) : 0, 166783
IAST [baseline] (21.662 ms) : 0, 21662
IAST [candidate] (20.454 ms) : 0, 20454
Remote Config [baseline] (661.122 µs) : 0, 661
Remote Config [candidate] (665.765 µs) : 0, 666
Telemetry [baseline] (8.304 ms) : 0, 8304
Telemetry [candidate] (8.311 ms) : 0, 8311
section iast
BytebuddyAgent [baseline] (847.799 ms) : 0, 847799
BytebuddyAgent [candidate] (833.087 ms) : 0, 833087
GlobalTracer [baseline] (232.723 ms) : 0, 232723
GlobalTracer [candidate] (252.714 ms) : 0, 252714
AppSec [baseline] (57.926 ms) : 0, 57926
AppSec [candidate] (57.802 ms) : 0, 57802
IAST [baseline] (23.183 ms) : 0, 23183
IAST [candidate] (21.658 ms) : 0, 21658
Remote Config [baseline] (627.09 µs) : 0, 627
Remote Config [candidate] (666.147 µs) : 0, 666
Telemetry [baseline] (8.933 ms) : 0, 8933
Telemetry [candidate] (8.744 ms) : 0, 8744
section profiling
BytebuddyAgent [baseline] (708.568 ms) : 0, 708568
BytebuddyAgent [candidate] (705.662 ms) : 0, 705662
GlobalTracer [baseline] (349.755 ms) : 0, 349755
GlobalTracer [candidate] (374.284 ms) : 0, 374284
AppSec [baseline] (55.514 ms) : 0, 55514
AppSec [candidate] (53.809 ms) : 0, 53809
Remote Config [baseline] (665.79 µs) : 0, 666
Remote Config [candidate] (694.428 µs) : 0, 694
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (8.769 ms) : 0, 8769
ProfilingAgent [baseline] (96.009 ms) : 0, 96009
ProfilingAgent [candidate] (93.514 ms) : 0, 93514
Profiling [baseline] (96.034 ms) : 0, 96034
Profiling [candidate] (93.538 ms) : 0, 93538
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.372 ms) : 1352, 1392
. : milestone, 1372,
appsec (1.76 ms) : 1737, 1783
. : milestone, 1760,
appsec_no_iast (1.753 ms) : 1728, 1777
. : milestone, 1753,
iast (1.519 ms) : 1496, 1543
. : milestone, 1519,
profiling (1.511 ms) : 1487, 1535
. : milestone, 1511,
tracing (1.485 ms) : 1459, 1511
. : milestone, 1485,
section candidate
no_agent (1.353 ms) : 1333, 1372
. : milestone, 1353,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.77 ms) : 1747, 1793
. : milestone, 1770,
iast (1.507 ms) : 1484, 1529
. : milestone, 1507,
profiling (1.506 ms) : 1483, 1529
. : milestone, 1506,
tracing (1.495 ms) : 1471, 1519
. : milestone, 1495,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (379.494 µs) : 359, 400
. : milestone, 379,
iast (510.35 µs) : 488, 532
. : milestone, 510,
iast_FULL (724.737 µs) : 703, 747
. : milestone, 725,
iast_GLOBAL (549.813 µs) : 528, 571
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (513.847 µs) : 491, 536
. : milestone, 514,
iast_INACTIVE (456.09 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (498.331 µs) : 475, 522
. : milestone, 498,
tracing (453.64 µs) : 432, 475
. : milestone, 454,
section candidate
no_agent (385.176 µs) : 364, 406
. : milestone, 385,
iast (498.494 µs) : 477, 520
. : milestone, 498,
iast_FULL (658.955 µs) : 638, 680
. : milestone, 659,
iast_GLOBAL (533.216 µs) : 511, 556
. : milestone, 533,
iast_HARDCODED_SECRET_DISABLED (500.657 µs) : 479, 522
. : milestone, 501,
iast_INACTIVE (465.978 µs) : 444, 487
. : milestone, 466,
iast_TELEMETRY_OFF (484.914 µs) : 464, 506
. : milestone, 485,
tracing (457.834 µs) : 437, 479
. : milestone, 458,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
appsec (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
iast (19.103 s) : 19103000, 19103000
. : milestone, 19103000,
iast_GLOBAL (17.764 s) : 17764000, 17764000
. : milestone, 17764000,
profiling (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
tracing (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
section candidate
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
iast (18.526 s) : 18526000, 18526000
. : milestone, 18526000,
iast_GLOBAL (18.027 s) : 18027000, 18027000
. : milestone, 18027000,
profiling (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
tracing (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9ee77d9810, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.351 ms) : 2307, 2395
. : milestone, 2351,
iast (2.098 ms) : 2043, 2153
. : milestone, 2098,
iast_GLOBAL (2.143 ms) : 2088, 2198
. : milestone, 2143,
profiling (1.952 ms) : 1908, 1995
. : milestone, 1952,
tracing (1.941 ms) : 1898, 1983
. : milestone, 1941,
section candidate
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.335 ms) : 2292, 2378
. : milestone, 2335,
iast (2.097 ms) : 2042, 2151
. : milestone, 2097,
iast_GLOBAL (2.14 ms) : 2085, 2195
. : milestone, 2140,
profiling (1.973 ms) : 1929, 2016
. : milestone, 1973,
tracing (1.939 ms) : 1896, 1981
. : milestone, 1939,
|
gary-huang
force-pushed
the
gary/impl-llm-obs-api
branch
from
b1d7aeb to
3bcbe81
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
from
9052dc4 to
dd8c1ed
Compare
gary-huang
force-pushed
the
gary/impl-llm-obs-api
branch
from
3bcbe81 to
c437b9c
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
2 times, most recently
from
88cbf86 to
ce8a6d3
Compare
gary-huang
force-pushed
the
gary/impl-llm-obs-api
branch
from
c437b9c to
8247b74
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
2 times, most recently
from
fc30660 to
061b18d
Compare
gary-huang
force-pushed
the
gary/impl-llm-obs-api
branch
from
8247b74 to
871d358
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
from
061b18d to
5c305b9
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
from
5c305b9 to
9ee77d9
Compare
| private static class PayloadV2 extends Payload { | ||
| private static int size = 0; | ||
|
|
||
| private PayloadV2() {} |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
gary-huang
force-pushed
the
gary/impl-llm-obs-api
branch
6 times, most recently
from
94136c5 to
7064f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]