Create metric: appsec.waf.input_truncated #8375

Mariovido · 2025-02-12T15:15:01Z

What Does This Do

This adds a new value to some metrics which is necessary for the consolidation of ASM Span Tags, Metrics, and Logs across all supported languages. The newly value will be implemented in the following metrics:

appsec.waf.input_truncated:
- truncation_reason: Bit with the type of truncation (1, 2, 4)

Motivation

Our goal is to implement all the missing ASM Span Tags, Metrics, and Logs.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-56479

smola · 2025-02-12T15:51:07Z

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/GatewayBridge.java

+        final long objectTooDeep =
+            wafMetrics.getWafInputsTruncatedCount(InputTruncatedType.OBJECT_TOO_DEEP);
+
+        WafMetricCollector.get().wafInputTruncated(TruncatedType.STRING_TOO_LONG, stringTooLong);


Don't call these when the counters are 0. It'll try to increment the atomic counters by 0 and it's all pointless.

Changed to only add when is greater than 0

smola · 2025-02-12T15:57:38Z

internal-api/src/main/java/datadog/trace/api/telemetry/TruncatedType.java

@@ -0,0 +1,22 @@
+package datadog.trace.api.telemetry;
+
+public enum TruncatedType {


As discussed offline, this is pretty much redundant with InputTruncatedType.

The final decision has been the removal of InputTruncatedType from libddwaf-java and keep this type in the dd-trace-java.
For reference this is the PR where the removal is done: DataDog/libddwaf-java#146

pr-commenter · 2025-02-12T15:59:00Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/add_input_truncated_metric
git_commit_date	1739369245	1739374393
git_commit_sha	`1c9548c`	`5a94e18`
release_version	1.47.0-SNAPSHOT~1c9548cf9b	1.47.0-SNAPSHOT~5a94e18fb2

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739376794	1739376794
ci_job_id	805222462	805222462
ci_pipeline_id	55689169	55689169
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cm6wdgd6-project-304-concurrent-1-7bb0fe1o 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cm6wdgd6-project-304-concurrent-1-7bb0fe1o 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~1c9548cf9b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041376
Total [baseline] (8.648 s) : 0, 8647964
Agent [candidate] (1.041 s) : 0, 1041323
Total [candidate] (8.676 s) : 0, 8675557
section iast
Agent [baseline] (1.17 s) : 0, 1170434
Total [baseline] (9.252 s) : 0, 9252005
Agent [candidate] (1.17 s) : 0, 1170331
Total [candidate] (9.193 s) : 0, 9192652
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1170481
Total [baseline] (9.238 s) : 0, 9238335
Agent [candidate] (1.18 s) : 0, 1179748
Total [candidate] (9.252 s) : 0, 9252210
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168766
Total [baseline] (9.269 s) : 0, 9269038
Agent [candidate] (1.175 s) : 0, 1175183
Total [candidate] (9.209 s) : 0, 9209105

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.17 s	129.057 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.17 s	129.105 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.169 s	127.389 ms (12.2%)
Total	tracing	8.648 s	-
Total	iast	9.252 s	604.041 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.238 s	590.371 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.269 s	621.074 ms (7.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.17 s	129.009 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	138.425 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.175 s	133.86 ms (12.9%)
Total	tracing	8.676 s	-
Total	iast	9.193 s	517.095 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.252 s	576.653 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.209 s	533.549 ms (6.2%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~1c9548cf9b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.253 ms) : 0, 719253
BytebuddyAgent [candidate] (717.03 ms) : 0, 717030
GlobalTracer [baseline] (240.064 ms) : 0, 240064
GlobalTracer [candidate] (240.8 ms) : 0, 240800
AppSec [baseline] (55.49 ms) : 0, 55490
AppSec [candidate] (55.435 ms) : 0, 55435
Remote Config [baseline] (715.091 µs) : 0, 715
Remote Config [candidate] (713.568 µs) : 0, 714
Telemetry [baseline] (10.661 ms) : 0, 10661
Telemetry [candidate] (12.133 ms) : 0, 12133
section iast
BytebuddyAgent [baseline] (834.661 ms) : 0, 834661
BytebuddyAgent [candidate] (834.926 ms) : 0, 834926
GlobalTracer [baseline] (230.717 ms) : 0, 230717
GlobalTracer [candidate] (230.87 ms) : 0, 230870
AppSec [baseline] (57.516 ms) : 0, 57516
AppSec [candidate] (57.153 ms) : 0, 57153
Remote Config [baseline] (620.17 µs) : 0, 620
Remote Config [candidate] (617.016 µs) : 0, 617
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.728 ms) : 0, 8728
IAST [baseline] (22.964 ms) : 0, 22964
IAST [candidate] (22.852 ms) : 0, 22852
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.079 ms) : 0, 835079
BytebuddyAgent [candidate] (843.137 ms) : 0, 843137
GlobalTracer [baseline] (231.293 ms) : 0, 231293
GlobalTracer [candidate] (232.295 ms) : 0, 232295
AppSec [baseline] (56.923 ms) : 0, 56923
AppSec [candidate] (56.906 ms) : 0, 56906
Remote Config [baseline] (616.853 µs) : 0, 617
Remote Config [candidate] (617.627 µs) : 0, 618
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.685 ms) : 0, 8685
IAST [baseline] (22.657 ms) : 0, 22657
IAST [candidate] (22.753 ms) : 0, 22753
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.541 ms) : 0, 833541
BytebuddyAgent [candidate] (839.329 ms) : 0, 839329
GlobalTracer [baseline] (231.333 ms) : 0, 231333
GlobalTracer [candidate] (232.356 ms) : 0, 232356
AppSec [baseline] (55.445 ms) : 0, 55445
AppSec [candidate] (52.017 ms) : 0, 52017
Remote Config [baseline] (606.376 µs) : 0, 606
Remote Config [candidate] (605.81 µs) : 0, 606
Telemetry [baseline] (8.682 ms) : 0, 8682
Telemetry [candidate] (8.601 ms) : 0, 8601
IAST [baseline] (23.964 ms) : 0, 23964
IAST [candidate] (26.997 ms) : 0, 26997

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~1c9548cf9b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040175
Total [baseline] (10.433 s) : 0, 10432936
Agent [candidate] (1.049 s) : 0, 1049287
Total [candidate] (10.425 s) : 0, 10424624
section appsec
Agent [baseline] (1.184 s) : 0, 1183911
Total [baseline] (10.746 s) : 0, 10746158
Agent [candidate] (1.183 s) : 0, 1182708
Total [candidate] (10.726 s) : 0, 10726080
section iast
Agent [baseline] (1.171 s) : 0, 1171073
Total [baseline] (10.956 s) : 0, 10955992
Agent [candidate] (1.173 s) : 0, 1172635
Total [candidate] (10.97 s) : 0, 10969632
section profiling
Agent [baseline] (1.27 s) : 0, 1269948
Total [baseline] (11.002 s) : 0, 11002099
Agent [candidate] (1.263 s) : 0, 1262670
Total [candidate] (10.821 s) : 0, 10821135

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	appsec	1.184 s	143.736 ms (13.8%)
Agent	iast	1.171 s	130.898 ms (12.6%)
Agent	profiling	1.27 s	229.773 ms (22.1%)
Total	tracing	10.433 s	-
Total	appsec	10.746 s	313.222 ms (3.0%)
Total	iast	10.956 s	523.056 ms (5.0%)
Total	profiling	11.002 s	569.163 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.183 s	133.421 ms (12.7%)
Agent	iast	1.173 s	123.348 ms (11.8%)
Agent	profiling	1.263 s	213.384 ms (20.3%)
Total	tracing	10.425 s	-
Total	appsec	10.726 s	301.456 ms (2.9%)
Total	iast	10.97 s	545.008 ms (5.2%)
Total	profiling	10.821 s	396.511 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~1c9548cf9b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.948 ms) : 0, 715948
BytebuddyAgent [candidate] (721.746 ms) : 0, 721746
GlobalTracer [baseline] (240.654 ms) : 0, 240654
GlobalTracer [candidate] (242.571 ms) : 0, 242571
AppSec [baseline] (55.551 ms) : 0, 55551
AppSec [candidate] (56.049 ms) : 0, 56049
Remote Config [baseline] (719.43 µs) : 0, 719
Remote Config [candidate] (714.649 µs) : 0, 715
Telemetry [baseline] (12.138 ms) : 0, 12138
Telemetry [candidate] (12.929 ms) : 0, 12929
section appsec
BytebuddyAgent [baseline] (735.039 ms) : 0, 735039
BytebuddyAgent [candidate] (733.616 ms) : 0, 733616
GlobalTracer [baseline] (237.389 ms) : 0, 237389
GlobalTracer [candidate] (237.415 ms) : 0, 237415
AppSec [baseline] (176.596 ms) : 0, 176596
AppSec [candidate] (176.256 ms) : 0, 176256
Remote Config [baseline] (646.909 µs) : 0, 647
Remote Config [candidate] (664.813 µs) : 0, 665
Telemetry [baseline] (8.215 ms) : 0, 8215
Telemetry [candidate] (8.593 ms) : 0, 8593
IAST [baseline] (21.605 ms) : 0, 21605
IAST [candidate] (21.844 ms) : 0, 21844
section iast
BytebuddyAgent [baseline] (835.661 ms) : 0, 835661
BytebuddyAgent [candidate] (836.232 ms) : 0, 836232
GlobalTracer [baseline] (231.264 ms) : 0, 231264
GlobalTracer [candidate] (231.297 ms) : 0, 231297
AppSec [baseline] (56.856 ms) : 0, 56856
AppSec [candidate] (57.42 ms) : 0, 57420
Remote Config [baseline] (606.376 µs) : 0, 606
Remote Config [candidate] (627.842 µs) : 0, 628
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.804 ms) : 0, 8804
IAST [baseline] (22.777 ms) : 0, 22777
IAST [candidate] (22.99 ms) : 0, 22990
section profiling
ProfilingAgent [baseline] (96.126 ms) : 0, 96126
ProfilingAgent [candidate] (96.379 ms) : 0, 96379
BytebuddyAgent [baseline] (712.835 ms) : 0, 712835
BytebuddyAgent [candidate] (707.959 ms) : 0, 707959
GlobalTracer [baseline] (353.189 ms) : 0, 353189
GlobalTracer [candidate] (351.812 ms) : 0, 351812
AppSec [baseline] (55.534 ms) : 0, 55534
AppSec [candidate] (54.659 ms) : 0, 54659
Remote Config [baseline] (708.079 µs) : 0, 708
Remote Config [candidate] (702.892 µs) : 0, 703
Telemetry [baseline] (8.976 ms) : 0, 8976
Telemetry [candidate] (8.926 ms) : 0, 8926
Profiling [baseline] (96.153 ms) : 0, 96153
Profiling [candidate] (96.407 ms) : 0, 96407

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-12T15:45:11	2025-02-12T15:52:15
git_branch	master	mario.vidal/add_input_truncated_metric
git_commit_date	1739374674	1739374393
git_commit_sha	`3fd5db0`	`5a94e18`
release_version	1.47.0-SNAPSHOT~3fd5db0dc1	1.47.0-SNAPSHOT~5a94e18fb2
start_time	2025-02-12T15:44:57	2025-02-12T15:52:02

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739375892	1739375892
ci_job_id	805222463	805222463
ci_pipeline_id	55689169	55689169
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-gwbi7xyu-project-304-concurrent-0-eugephh3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-gwbi7xyu-project-304-concurrent-0-eugephh3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-94.947µs; -42.864µs] or [-6.022%; -2.719%]	unstable [-445.702op/s; +673.622op/s] or [-15.042%; +22.735%]	1.508ms	3076.923op/s	1.577ms	2962.963op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1366
.   : milestone, 1347,
appsec (1.747 ms) : 1724, 1770
.   : milestone, 1747,
appsec_no_iast (1.769 ms) : 1744, 1794
.   : milestone, 1769,
iast (1.513 ms) : 1489, 1538
.   : milestone, 1513,
profiling (1.577 ms) : 1552, 1602
.   : milestone, 1577,
tracing (1.485 ms) : 1460, 1510
.   : milestone, 1485,
section candidate
no_agent (1.36 ms) : 1340, 1379
.   : milestone, 1360,
appsec (1.716 ms) : 1692, 1740
.   : milestone, 1716,
appsec_no_iast (1.735 ms) : 1710, 1759
.   : milestone, 1735,
iast (1.485 ms) : 1460, 1510
.   : milestone, 1485,
profiling (1.508 ms) : 1484, 1531
.   : milestone, 1508,
tracing (1.478 ms) : 1452, 1504
.   : milestone, 1478,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.347 ms [1.328 ms, 1.366 ms]	-
appsec	1.747 ms [1.724 ms, 1.77 ms]	400.139 µs (29.7%)
appsec_no_iast	1.769 ms [1.744 ms, 1.794 ms]	421.877 µs (31.3%)
iast	1.513 ms [1.489 ms, 1.538 ms]	166.438 µs (12.4%)
profiling	1.577 ms [1.552 ms, 1.602 ms]	229.717 µs (17.1%)
tracing	1.485 ms [1.46 ms, 1.51 ms]	138.297 µs (10.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.34 ms, 1.379 ms]	-
appsec	1.716 ms [1.692 ms, 1.74 ms]	356.07 µs (26.2%)
appsec_no_iast	1.735 ms [1.71 ms, 1.759 ms]	374.986 µs (27.6%)
iast	1.485 ms [1.46 ms, 1.51 ms]	125.083 µs (9.2%)
profiling	1.508 ms [1.484 ms, 1.531 ms]	148.006 µs (10.9%)
tracing	1.478 ms [1.452 ms, 1.504 ms]	118.117 µs (8.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.563 µs) : 358, 399
.   : milestone, 379,
iast (504.551 µs) : 482, 527
.   : milestone, 505,
iast_FULL (733.817 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (547.129 µs) : 525, 569
.   : milestone, 547,
iast_HARDCODED_SECRET_DISABLED (513.155 µs) : 491, 536
.   : milestone, 513,
iast_INACTIVE (463.099 µs) : 441, 485
.   : milestone, 463,
iast_TELEMETRY_OFF (494.417 µs) : 471, 518
.   : milestone, 494,
tracing (453.259 µs) : 432, 474
.   : milestone, 453,
section candidate
no_agent (383.784 µs) : 364, 403
.   : milestone, 384,
iast (506.772 µs) : 485, 529
.   : milestone, 507,
iast_FULL (744.69 µs) : 723, 767
.   : milestone, 745,
iast_GLOBAL (549.099 µs) : 527, 571
.   : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (511.051 µs) : 489, 533
.   : milestone, 511,
iast_INACTIVE (457.638 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (494.434 µs) : 473, 516
.   : milestone, 494,
tracing (451.86 µs) : 431, 473
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.563 µs [358.166 µs, 398.96 µs]	-
iast	504.551 µs [482.25 µs, 526.853 µs]	125.988 µs (33.3%)
iast_FULL	733.817 µs [711.988 µs, 755.646 µs]	355.254 µs (93.8%)
iast_GLOBAL	547.129 µs [525.408 µs, 568.85 µs]	168.566 µs (44.5%)
iast_HARDCODED_SECRET_DISABLED	513.155 µs [490.711 µs, 535.599 µs]	134.592 µs (35.6%)
iast_INACTIVE	463.099 µs [441.159 µs, 485.04 µs]	84.536 µs (22.3%)
iast_TELEMETRY_OFF	494.417 µs [471.274 µs, 517.56 µs]	115.854 µs (30.6%)
tracing	453.259 µs [432.325 µs, 474.192 µs]	74.695 µs (19.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.784 µs [364.228 µs, 403.339 µs]	-
iast	506.772 µs [484.807 µs, 528.736 µs]	122.988 µs (32.0%)
iast_FULL	744.69 µs [722.761 µs, 766.618 µs]	360.906 µs (94.0%)
iast_GLOBAL	549.099 µs [527.385 µs, 570.814 µs]	165.316 µs (43.1%)
iast_HARDCODED_SECRET_DISABLED	511.051 µs [489.011 µs, 533.092 µs]	127.268 µs (33.2%)
iast_INACTIVE	457.638 µs [436.468 µs, 478.808 µs]	73.855 µs (19.2%)
iast_TELEMETRY_OFF	494.434 µs [473.29 µs, 515.579 µs]	110.651 µs (28.8%)
tracing	451.86 µs [431.186 µs, 472.534 µs]	68.077 µs (17.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/add_input_truncated_metric
git_commit_date	1739369245	1739374393
git_commit_sha	`1c9548c`	`5a94e18`
release_version	1.47.0-SNAPSHOT~1c9548cf9b	1.47.0-SNAPSHOT~5a94e18fb2

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739376349	1739376349
ci_job_id	805222465	805222465
ci_pipeline_id	55689169	55689169
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cm6wdgd6-project-304-concurrent-3-gb308wg4 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cm6wdgd6-project-304-concurrent-3-gb308wg4 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~1c9548cf9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.369 ms) : 2325, 2412
.   : milestone, 2369,
iast (2.119 ms) : 2063, 2174
.   : milestone, 2119,
iast_GLOBAL (2.154 ms) : 2099, 2210
.   : milestone, 2154,
profiling (2.459 ms) : 2280, 2639
.   : milestone, 2459,
tracing (1.953 ms) : 1910, 1995
.   : milestone, 1953,
section candidate
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.337 ms) : 2294, 2381
.   : milestone, 2337,
iast (2.113 ms) : 2057, 2168
.   : milestone, 2113,
iast_GLOBAL (2.152 ms) : 2096, 2207
.   : milestone, 2152,
profiling (1.981 ms) : 1937, 2026
.   : milestone, 1981,
tracing (1.943 ms) : 1901, 1985
.   : milestone, 1943,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	2.369 ms [2.325 ms, 2.412 ms]	892.858 µs (60.5%)
iast	2.119 ms [2.063 ms, 2.174 ms]	642.616 µs (43.5%)
iast_GLOBAL	2.154 ms [2.099 ms, 2.21 ms]	678.423 µs (46.0%)
profiling	2.459 ms [2.28 ms, 2.639 ms]	983.367 µs (66.6%)
tracing	1.953 ms [1.91 ms, 1.995 ms]	476.539 µs (32.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.466 ms, 1.489 ms]	-
appsec	2.337 ms [2.294 ms, 2.381 ms]	860.298 µs (58.2%)
iast	2.113 ms [2.057 ms, 2.168 ms]	635.643 µs (43.0%)
iast_GLOBAL	2.152 ms [2.096 ms, 2.207 ms]	674.506 µs (45.7%)
profiling	1.981 ms [1.937 ms, 2.026 ms]	504.192 µs (34.1%)
tracing	1.943 ms [1.901 ms, 1.985 ms]	465.475 µs (31.5%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a94e18fb2, baseline=1.47.0-SNAPSHOT~1c9548cf9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.546 s) : 15546000, 15546000
.   : milestone, 15546000,
appsec (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
iast (18.753 s) : 18753000, 18753000
.   : milestone, 18753000,
iast_GLOBAL (18.269 s) : 18269000, 18269000
.   : milestone, 18269000,
profiling (15.708 s) : 15708000, 15708000
.   : milestone, 15708000,
tracing (14.802 s) : 14802000, 14802000
.   : milestone, 14802000,
section candidate
no_agent (14.832 s) : 14832000, 14832000
.   : milestone, 14832000,
appsec (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
iast (18.566 s) : 18566000, 18566000
.   : milestone, 18566000,
iast_GLOBAL (17.696 s) : 17696000, 17696000
.   : milestone, 17696000,
profiling (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
tracing (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.546 s [15.546 s, 15.546 s]	-
appsec	14.923 s [14.923 s, 14.923 s]	-623.0 ms (-4.0%)
iast	18.753 s [18.753 s, 18.753 s]	3.207 s (20.6%)
iast_GLOBAL	18.269 s [18.269 s, 18.269 s]	2.723 s (17.5%)
profiling	15.708 s [15.708 s, 15.708 s]	162.0 ms (1.0%)
tracing	14.802 s [14.802 s, 14.802 s]	-744.0 ms (-4.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.832 s [14.832 s, 14.832 s]	-
appsec	15.21 s [15.21 s, 15.21 s]	378.0 ms (2.5%)
iast	18.566 s [18.566 s, 18.566 s]	3.734 s (25.2%)
iast_GLOBAL	17.696 s [17.696 s, 17.696 s]	2.864 s (19.3%)
profiling	14.98 s [14.98 s, 14.98 s]	148.0 ms (1.0%)
tracing	15.01 s [15.01 s, 15.01 s]	178.0 ms (1.2%)

Upgrade libddwaf and add InputTruncated metric

aba526c

Mariovido added type: enhancement comp: asm waf Application Security Management (WAF) labels Feb 12, 2025

Add tests

5a94e18

smola requested changes Feb 12, 2025

View reviewed changes

Adapt to new version of libddwaf-java

d3cbc7e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create metric: appsec.waf.input_truncated #8375

Create metric: appsec.waf.input_truncated #8375

Mariovido commented Feb 12, 2025 •

edited

Loading

smola Feb 12, 2025

Mariovido Feb 12, 2025

smola Feb 12, 2025

Mariovido Feb 12, 2025 •

edited

Loading

pr-commenter bot commented Feb 12, 2025 •

edited

Loading

		@@ -0,0 +1,22 @@
		package datadog.trace.api.telemetry;

		public enum TruncatedType {

Create metric: appsec.waf.input_truncated #8375

Are you sure you want to change the base?

Create metric: appsec.waf.input_truncated #8375

Conversation

Mariovido commented Feb 12, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

smola Feb 12, 2025

Choose a reason for hiding this comment

Mariovido Feb 12, 2025

Choose a reason for hiding this comment

smola Feb 12, 2025

Choose a reason for hiding this comment

Mariovido Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

pr-commenter bot commented Feb 12, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Mariovido commented Feb 12, 2025 •

edited

Loading

Mariovido Feb 12, 2025 •

edited

Loading

pr-commenter bot commented Feb 12, 2025 •

edited

Loading