Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load telemetry only when needed #5255

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

lazy load telemetry only when needed #5255

wants to merge 3 commits into from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 12, 2025

What does this PR do?

Lazy load telemetry only when needed.

Motivation

Right now when telemetry is disabled, the code is still loaded which impacts startup time.

Additional Notes

For now I only handled this for tracing specifically. There are other places that use telemetry internals directly, for example AppSec, but this will be handled in a second pass later on as right now we are focusing on the default.

@rochdev rochdev changed the title Lazy telemetry lazy load telemetry only when needed Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (8e8898d) to head (4572fbf).

Files with missing lines Patch % Lines
packages/dd-trace/src/telemetry/telemetry.js 92.77% 12 Missing ⚠️
packages/datadog-plugin-dd-trace-api/src/index.js 40.00% 3 Missing ⚠️
packages/dd-trace/src/opentracing/span.js 60.00% 2 Missing ⚠️
packages/dd-trace/src/config.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5255      +/-   ##
==========================================
- Coverage   81.24%   80.36%   -0.88%     
==========================================
  Files         487      465      -22     
  Lines       21703    20993     -710     
==========================================
- Hits        17633    16872     -761     
- Misses       4070     4121      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 12, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 12, 2025

Datadog Report

Branch report: lazy-telemetry
Commit report: d339b63
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 627 Passed, 0 Skipped, 11m 41.9s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-13 00:44:51

Comparing candidate commit 4572fbf in PR branch lazy-telemetry with baseline commit 8e8898d in branch master.

Found 14 performance improvements and 0 performance regressions! Performance is the same for 889 metrics, 30 unstable metrics.

scenario:debugger-enabled-but-breakpoint-not-hit-20

  • 🟩 instructions [-86.1M instructions; -82.8M instructions] or [-5.892%; -5.661%]

scenario:debugger-enabled-but-breakpoint-not-hit-22

  • 🟩 instructions [-78.6M instructions; -75.1M instructions] or [-5.535%; -5.291%]

scenario:debugger-line-probe-with-snapshot-minimal-20

  • 🟩 instructions [-79.9M instructions; -75.9M instructions] or [-7.131%; -6.773%]

scenario:debugger-line-probe-with-snapshot-minimal-22

  • 🟩 instructions [-80.0M instructions; -76.2M instructions] or [-7.401%; -7.050%]

scenario:debugger-line-probe-without-snapshot-20

  • 🟩 instructions [-87.7M instructions; -82.5M instructions] or [-6.358%; -5.987%]

scenario:debugger-line-probe-without-snapshot-22

  • 🟩 instructions [-77.1M instructions; -75.0M instructions] or [-5.731%; -5.579%]

scenario:log-skip-log-22

  • 🟩 cpu_user_time [-25.400ms; -19.857ms] or [-8.403%; -6.569%]
  • 🟩 execution_time [-25.764ms; -21.853ms] or [-7.402%; -6.278%]

scenario:log-with-debug-22

  • 🟩 cpu_user_time [-25.893ms; -20.895ms] or [-8.622%; -6.958%]
  • 🟩 execution_time [-27.202ms; -25.018ms] or [-7.841%; -7.212%]

scenario:log-with-error-22

  • 🟩 cpu_user_time [-27.487ms; -22.666ms] or [-9.220%; -7.603%]
  • 🟩 execution_time [-26.278ms; -24.720ms] or [-7.673%; -7.217%]

scenario:log-without-log-22

  • 🟩 cpu_user_time [-27.666ms; -22.733ms] or [-9.929%; -8.159%]
  • 🟩 execution_time [-26.381ms; -25.289ms] or [-8.128%; -7.792%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant