Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load public api + profiling + crashtracking + span stats #5256

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 12, 2025

What does this PR do?

Lazy load non-tracing public API, profiling, crashtracking and span stats.

Motivation

These are all costly to import and increase startup time even when not needed.

Copy link

github-actions bot commented Feb 12, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (6b97186) to head (21b9e4d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5256      +/-   ##
==========================================
- Coverage   81.29%   81.25%   -0.05%     
==========================================
  Files         481      487       +6     
  Lines       21598    21708     +110     
==========================================
+ Hits        17558    17638      +80     
- Misses       4040     4070      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 12, 2025

Datadog Report

Branch report: lazy-api-and-friends
Commit report: 2da5212
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 630 Passed, 0 Skipped, 15m 49.7s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-13 22:10:17

Comparing candidate commit 21b9e4d in PR branch lazy-api-and-friends with baseline commit 6b97186 in branch master.

Found 5 performance improvements and 4 performance regressions! Performance is the same for 817 metrics, 22 unstable metrics.

scenario:appsec-iast-startup-time-iast-enabled-20

  • 🟥 max_rss_usage [+8.810MB; +11.479MB] or [+6.547%; +8.530%]

scenario:exporting-pipeline-0.5-18

  • 🟩 cpu_user_time [-16.231ms; -12.509ms] or [-7.415%; -5.714%]

scenario:exporting-pipeline-0.5-20

  • 🟩 cpu_user_time [-18.158ms; -14.882ms] or [-8.659%; -7.097%]
  • 🟩 execution_time [-17.647ms; -14.811ms] or [-7.074%; -5.938%]

scenario:exporting-pipeline-0.5-22

  • 🟩 cpu_user_time [-17.948ms; -15.313ms] or [-9.530%; -8.131%]
  • 🟩 execution_time [-16.449ms; -14.738ms] or [-7.536%; -6.752%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+63.684MB; +126.128MB] or [+7.346%; +14.550%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+66.034MB; +116.762MB] or [+7.703%; +13.622%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+104.886MB; +115.818MB] or [+12.122%; +13.385%]

@rochdev rochdev marked this pull request as ready for review February 12, 2025 20:47
@rochdev rochdev requested review from a team as code owners February 12, 2025 20:47
const profilingEnabledEnv = coalesce(
DD_EXPERIMENTAL_PROFILING_ENABLED,
DD_PROFILING_ENABLED,
this._isInServerlessEnvironment() ? 'false' : undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, I see what you did here. Clever 😃.

For consistency, I'd probably move these to _applyCalculated. I know it's not particularly interesting since you said we don't report telemetry but it's still conceptually cleaner. You could just put this in _applyCalculated():

    if (this._isInServerlessEnvironment()) {
      this._setValue(calc, 'profiling.enabled', 'false')
      this._setValue(calc, 'crashtracking.enabled', false)
    }

Copy link
Member Author

@rochdev rochdev Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, I moved them here for consistency, as other options are also calculated in this way in _applyEnv. For now let's keep it there and we can revisit in a separate PR if needed, although I kind of think it makes sense to be in _applyEnv as Serverless is an environment. In any case, I'd consider this out of scope of this PR since there are other occurrences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought "Env" in "_applyEnv" meant "environment variables". But you're right that some uses of specifically _isInServerlessEnvironment have already snuck in, so by that reasoning I can accept these being there as well. If someone gets sufficiently irritated by it, they can fix it later.

@rochdev rochdev force-pushed the lazy-api-and-friends branch from 8e9a33c to 21b9e4d Compare February 13, 2025 21:58
Copy link
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for profiling.

Copy link
Collaborator

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for llmobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants