Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load dsm only when needed #5305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lazy load dsm only when needed #5305

wants to merge 2 commits into from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 21, 2025

What does this PR do?

Lazy load DSM only when needed.

Motivation

DSM loads a lot of code and some pretty heavy dependencies which increase startup time when not needed.

@@ -0,0 +1,53 @@
'use strict'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helpers in this file were copied from processor.js untouched.

Copy link

github-actions bot commented Feb 21, 2025

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 78.78788% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (96bb84a) to head (4d315a9).

Files with missing lines Patch % Lines
packages/dd-trace/src/datastreams/size.js 50.00% 12 Missing ⚠️
packages/dd-trace/src/tracer.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5305      +/-   ##
==========================================
- Coverage   80.94%   80.85%   -0.09%     
==========================================
  Files         488      489       +1     
  Lines       21844    21751      -93     
==========================================
- Hits        17681    17587      -94     
- Misses       4163     4164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 21, 2025

Datadog Report

Branch report: lazy-load-dsm
Commit report: e5e535d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 668 Passed, 0 Skipped, 15m 43.11s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-21 01:41:57

Comparing candidate commit 4d315a9 in PR branch lazy-load-dsm with baseline commit 96bb84a in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 801 metrics, 14 unstable metrics.

scenario:spans-finish-later-22

  • 🟩 instructions [-266.9M instructions; -211.8M instructions] or [-9.323%; -7.399%]

scenario:startup-with-tracer-22

  • 🟥 execution_time [+13.617ms; +15.093ms] or [+5.875%; +6.512%]

@rochdev rochdev marked this pull request as ready for review February 21, 2025 01:44
@rochdev rochdev requested review from a team as code owners February 21, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant