Skip to content

Conversation

@CarlesDD
Copy link
Contributor

@CarlesDD CarlesDD commented Nov 12, 2025

What does this PR do?

Implements the correct handling of AAP service activation origin reporting via configuration telemetry.
Removes legacy implementation of AAP service activation origin reporting.

Plugin Checklist

  • Unit tests.

Additional Notes

System Tests:

  • Enabled test for this implementation (#5711)
  • Capped test for legacy implementation (#5714)

APPSEC-59787

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Overall package size

Self size: 13.23 MB
Deduped: 116.13 MB
No deduping: 131.15 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.55 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.15 | 106.53 kB | 424.55 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.83%. Comparing base (315020a) to head (aaad6a7).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6896      +/-   ##
==========================================
- Coverage   83.84%   83.83%   -0.02%     
==========================================
  Files         506      506              
  Lines       21373    21358      -15     
==========================================
- Hits        17921    17906      -15     
  Misses       3452     3452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2025

Benchmarks

Benchmark execution time: 2025-11-14 10:00:53

Comparing candidate commit aaad6a7 in PR branch ccapell/appsec-activation-origin-config with baseline commit 315020a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1600 metrics, 70 unstable metrics.

@CarlesDD CarlesDD force-pushed the ccapell/appsec-activation-origin-config branch from b11bf1c to 0c4f6b9 Compare November 13, 2025 08:16
@CarlesDD CarlesDD self-assigned this Nov 13, 2025
@CarlesDD CarlesDD changed the title [Appsec] Send appsec.enabled origin by telemetry [Appsec] AAP Requirements - Activation Origin Nov 13, 2025
@CarlesDD
Copy link
Contributor Author

ST green

@CarlesDD CarlesDD force-pushed the ccapell/appsec-activation-origin-config branch from 7389f94 to aaad6a7 Compare November 14, 2025 09:20
@CarlesDD CarlesDD marked this pull request as ready for review November 14, 2025 10:01
@CarlesDD CarlesDD requested review from a team as code owners November 14, 2025 10:01
@CarlesDD CarlesDD requested review from khanayan123 and removed request for a team November 14, 2025 10:01
@CarlesDD CarlesDD merged commit 8378ffd into master Nov 17, 2025
778 checks passed
@CarlesDD CarlesDD deleted the ccapell/appsec-activation-origin-config branch November 17, 2025 05:30
dd-octo-sts bot pushed a commit that referenced this pull request Nov 17, 2025
* Update origin for appsec.enabled

* Revert "Add appsec.enabled origin gauge metric (#5794)"

This reverts commit c21e73b.

* Remove telemetry test

* New config singleton

* Fix linting

* Fix config + teset

* Fix config in test

* Refactor
@dd-octo-sts dd-octo-sts bot mentioned this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants