Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Disable APM Tracing #3080

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Feb 11, 2025

Description

Implement Disable APM Tracing

APPSEC-56460

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana changed the title Replace DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED with DD_APM_TRACING… Implement Disable APM Tracing Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (c199419) to head (a5c83d0).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3080       +/-   ##
=============================================
+ Coverage     51.86%   72.93%   +21.07%     
  Complexity     2790     2790               
=============================================
  Files           112      139       +27     
  Lines         11042    15280     +4238     
  Branches          0     1047     +1047     
=============================================
+ Hits           5727    11145     +5418     
+ Misses         5315     3582     -1733     
- Partials          0      553      +553     
Flag Coverage Δ
appsec-extension 68.28% <100.00%> (?)
tracer-php 74.72% <ø> (+22.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/configuration.h 100.00% <ø> (ø)
appsec/src/extension/tags.c 80.85% <100.00%> (ø)

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c199419...a5c83d0. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-02-11 17:03:26

Comparing candidate commit a5c83d0 in PR branch estringana/asm-standalone-v3 with baseline commit c199419 in branch master.

Found 4 performance improvements and 1 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-8.747µs; -7.553µs] or [-3.898%; -3.366%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-10.682µs; -8.518µs] or [-4.796%; -3.824%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+8.731µs; +15.801µs] or [+4.732%; +8.565%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-14.944µs; -8.807µs] or [-7.677%; -4.524%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟩 execution_time [-453.020ns; -148.980ns] or [-6.111%; -2.010%]

@estringana estringana force-pushed the estringana/asm-standalone-v3 branch from fb6dd8d to 479b78f Compare February 11, 2025 16:12
@estringana estringana force-pushed the estringana/asm-standalone-v3 branch from 479b78f to a5c83d0 Compare February 11, 2025 16:34
@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-02-11 17:11:43

Comparing candidate commit a5c83d0 in PR branch estringana/asm-standalone-v3 with baseline commit c199419 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants