Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace): crash when disabled by webserver config #3089

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morrisonlevi
Copy link
Collaborator

Description

I found this looking through crash reports. Bob surmised the issue when I shared it with him.

We haven't tested this theory yet. I'm pushing this PR so CI can package it up nicely for us, so we have installable artifacts to try to A/B test.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi force-pushed the levi/fix-ddtrace_close_all_open_spans branch from 563e1a5 to ebfea19 Compare February 14, 2025 20:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.95%. Comparing base (13d1512) to head (ebfea19).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3089      +/-   ##
============================================
- Coverage     74.72%   72.95%   -1.78%     
  Complexity     2790     2790              
============================================
  Files           112      139      +27     
  Lines         11042    15280    +4238     
  Branches          0     1047    +1047     
============================================
+ Hits           8251    11147    +2896     
- Misses         2791     3580     +789     
- Partials          0      553     +553     
Flag Coverage Δ
appsec-extension 68.28% <ø> (?)
tracer-php 74.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d1512...ebfea19. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Feb 14, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-02-14 21:24:54

Comparing candidate commit ebfea19 in PR branch levi/fix-ddtrace_close_all_open_spans with baseline commit 13d1512 in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit

  • 🟩 execution_time [-519.405ns; -190.595ns] or [-6.546%; -2.402%]

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟩 execution_time [-532.342ns; -169.658ns] or [-6.620%; -2.110%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants