Skip to content

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Sep 2, 2025

Description

Support PHP 8.5 for the Tracer, Appsec and the profiler.

Note: This version of PHP is meant to be released on November 20th.

@pr-commenter
Copy link

pr-commenter bot commented Sep 2, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-11-07 14:17:05

Comparing candidate commit ab77adb in PR branch leiyks/php-8.5 with baseline commit 789048a in branch master.

Found 1 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 1 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+5.574µs; +7.706µs] or [+5.249%; +7.258%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+37.148ns; +115.052ns] or [+3.080%; +9.538%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+37.634ns; +111.966ns] or [+3.130%; +9.313%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 mem_peak [+946.680KB; +976.086KB] or [+2.251%; +2.321%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-34.617µs; -20.283µs] or [-7.919%; -4.640%]

@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 3 times, most recently from c3d6bb6 to 76324f3 Compare September 8, 2025 14:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.76%. Comparing base (789048a) to head (e03aec6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3400      +/-   ##
==========================================
- Coverage   61.86%   61.76%   -0.10%     
==========================================
  Files         142      142              
  Lines       12895    12895              
  Branches     1689     1689              
==========================================
- Hits         7977     7965      -12     
- Misses       4161     4171      +10     
- Partials      757      759       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789048a...e03aec6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 7 times, most recently from b6000bf to 7d6345a Compare September 17, 2025 15:34
@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 5 times, most recently from 0aff6bc to 2bc1c1d Compare September 29, 2025 15:53
@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-11-07 13:25:55

Comparing candidate commit ab77adb in PR branch leiyks/php-8.5 with baseline commit 789048a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@realFlowControl realFlowControl force-pushed the leiyks/php-8.5 branch 2 times, most recently from e248dc5 to c2d5d7b Compare October 1, 2025 11:58
@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 9 times, most recently from fa8e2eb to df0433d Compare October 7, 2025 11:50
@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 4 times, most recently from 55c4015 to 745c0de Compare October 30, 2025 23:02
Leiyks and others added 18 commits November 7, 2025 14:09
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
CentOS 7's glibc lacks __builtin_cpu_init() support, causing IFUNC
resolvers to crash during dynamic linking when detecting AVX2 support.
Disable IFUNC and use runtime function pointer initialization instead.
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
@bwoebi bwoebi changed the title feat: add php 8.5 docker images feat: add php 8.5 support Nov 7, 2025
bwoebi
bwoebi previously approved these changes Nov 7, 2025
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, the changes look solid.
Thanks for working on this :-)

@bwoebi bwoebi dismissed their stale review November 7, 2025 15:52

Integration tests for 8.5 seem to be missing?

Signed-off-by: Alexandre Rulleau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants