-
Notifications
You must be signed in to change notification settings - Fork 167
feat: add php 8.5 support #3400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Benchmarks [ tracer ]Benchmark execution time: 2025-11-07 14:17:05 Comparing candidate commit ab77adb in PR branch Found 1 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
c3d6bb6 to
76324f3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3400 +/- ##
==========================================
- Coverage 61.86% 61.76% -0.10%
==========================================
Files 142 142
Lines 12895 12895
Branches 1689 1689
==========================================
- Hits 7977 7965 -12
- Misses 4161 4171 +10
- Partials 757 759 +2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
b6000bf to
7d6345a
Compare
ffba8ab to
82c64a8
Compare
0aff6bc to
2bc1c1d
Compare
Benchmarks [ profiler ]Benchmark execution time: 2025-11-07 13:25:55 Comparing candidate commit ab77adb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
e248dc5 to
c2d5d7b
Compare
fa8e2eb to
df0433d
Compare
55c4015 to
745c0de
Compare
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
CentOS 7's glibc lacks __builtin_cpu_init() support, causing IFUNC resolvers to crash during dynamic linking when detecting AVX2 support. Disable IFUNC and use runtime function pointer initialization instead.
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
745c0de to
ab77adb
Compare
bwoebi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, the changes look solid.
Thanks for working on this :-)
Integration tests for 8.5 seem to be missing?
ab77adb to
fcc2195
Compare
Signed-off-by: Alexandre Rulleau <[email protected]>
fcc2195 to
e03aec6
Compare
Description
Support PHP 8.5 for the Tracer, Appsec and the profiler.
Note: This version of PHP is meant to be released on November 20th.